netcat-openbsd: fix implicit dependency on pkg-config
PATCH 1/1 netcat-openbsd: fix implicit dependency on pkg-config
In the report at http://errors.yoctoproject.org/Errors/Details/130673/
we see the following:
i586-oe-linux-gcc -m32 -march=i586 <snip> netcat.o atomicio.o socks.o pkg-config --libs libbsd -lresolv -o nc /bin/sh: 1: pkg-config: not found
What follows is a bunch of link errors for BSD library functions, as the backtick didn't return anything but an empty string and hence no BSD library was involved in the link.
I was able to reproduce this by temporarily removing my host version of pkg-config, and then validated that this fix solves it while still having the host binary removed. So it should fix the reported issue. I also confirmed pkg-config was in the sysroot after the change.
meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb +1 -3
@@ -4,7 +4,7 @@ HOMEPAGE = "http://ftp.debian.org" LICENSE = "BSD-3-Clause" LIC_FILES_CHKSUM = "file://../debian/copyright;md5=ee6bbaacb5db5f2973818f0902c3ae6f" -DEPENDS += "glib-2.0 libbsd" +DEPENDS += "glib-2.0 libbsd pkgconfig-native" SRC_URI = "${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}.orig.tar.gz;name=netcat \ ${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}-7.debian.tar.gz;name=netcat-patch"
@@ -42,5 +42,3 @@ do_install() { install -m 755 ${S}/nc ${D}${bindir}/nc.${BPN} } ALTERNATIVE_PRIORITY = "60" - -PNBLACKLIST[netcat-openbsd] ?= "Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130673/"
Signature · 1 line
2.7.4
Quoted 30 lines · Paul Gortmaker
In the report at http://errors.yoctoproject.org/Errors/Details/130673/
we see the following:i586-oe-linux-gcc -m32 -march=i586 <snip> netcat.o atomicio.o socks.o
pkg-config --libs libbsd-lresolv -o nc/bin/sh: 1: pkg-config: not foundWhat follows is a bunch of link errors for BSD library functions, as the backtick didn't return anything but an empty string and hence no BSD library was involved in the link.
I was able to reproduce this by temporarily removing my host version of pkg-config, and then validated that this fix solves it while still having the host binary removed. So it should fix the reported issue. I also confirmed pkg-config was in the sysroot after the change.
Cc Martin Jansa <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>(quoted diff) +0
-0netcat-openbsd_1.105.bb b/meta-networking/recipes-support/netcat/ netcat-openbsd_1.105.bb
indexbb21e0cfeede..06206a5a59d1100644meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb +0
-0@@ -4,7 +4,7 @@ HOMEPAGE = "http://ftp.debian.org" LICENSE = "BSD-3-Clause" LIC_FILES_CHKSUM ="file://../debian/copyright;md5=ee6bbaacb5db5f2973818f0902c3ae6f"
meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb HOMEPAGE = "http://ftp.debian.org" · line 7
Quoted 2 lines
meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb +1
-1-DEPENDS += "glib-2.0 libbsd" +DEPENDS += "glib-2.0 libbsd pkgconfig-native"
I think inherit pkgconfig should be the way to go here
Quoted 23 lines
SRC_URI=
"${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}.orig.tar.gz;name=netcat \${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}-7.debian.tar.gz;name=netcat-patch"
meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb +0
-2@@ -42,5 +42,3 @@ do_install() { install -m 755 ${S}/nc ${D}${bindir}/nc.${BPN} } ALTERNATIVE_PRIORITY = "60" - -PNBLACKLIST[netcat-openbsd] ?= "Fails to build with RSShttp://errors.yoctoproject.org/Errors/Details/130673/"
--
2.7.4--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 3 lines · [Re: [oe] [PATCH] netcat-openbsd: fix implicit dependency on pkg-config] On…
On Sat, Feb 18, 2017 at 5:12 PM Paul Gortmaker <[email protected]> wrote:
[...]
Quoted 6 lines
meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb HOMEPAGE = "http://ftp.debian.org" · line 7
Quoted 3 lines
meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb +1
-1-DEPENDS += "glib-2.0 libbsd" +DEPENDS += "glib-2.0 libbsd pkgconfig-native"I think inherit pkgconfig should be the way to go here
That seems reasonable and would explain why I wasn't seeing a lot of pre-existing depends on pkgconfig. I'll test that and send a v2.
Thanks,
Paul.
--
Quoted 29 lines
Quoted 24 lines
SRC_URI=
"${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}.orig.tar.gz;name=netcat \${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}-7.debian.tar.gz;name=netcat-patch"
meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb +0
-2@@ -42,5 +42,3 @@ do_install() { install -m 755 ${S}/nc ${D}${bindir}/nc.${BPN} } ALTERNATIVE_PRIORITY = "60" - -PNBLACKLIST[netcat-openbsd] ?= "Fails to build with RSShttp://errors.yoctoproject.org/Errors/Details/130673/"
--
2.7.4--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develSignature · 4 lines
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
PATCH v2 1/1 netcat-openbsd: fix implicit dependency on pkg-config
In reply to Khem RajIn the report at http://errors.yoctoproject.org/Errors/Details/130673/
we see the following:
i586-oe-linux-gcc -m32 -march=i586 <snip> netcat.o atomicio.o socks.o pkg-config --libs libbsd -lresolv -o nc /bin/sh: 1: pkg-config: not found
What follows is a bunch of link errors for BSD library functions, as the backtick didn't return anything but an empty string and hence no BSD library was involved in the link.
I was able to reproduce this by temporarily removing my host version of pkg-config, and then validated that this fix solves it while still having the host binary removed. So it should fix the reported issue. I also confirmed pkg-config was in the sysroot after the change.
---
[v2: use inherit pkgconfig vs. depending on it, as per what
Khem suggested as being the more conventional route. ]
meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb +2 -2
@@ -14,6 +14,8 @@ SRC_URI[netcat.sha256sum] = "40653fe66c1516876b61b07e093d826e2a5463c5d994f1b7e6c SRC_URI[netcat-patch.md5sum] = "e914f8eb7eda5c75c679dd77787ac76b" SRC_URI[netcat-patch.sha256sum] = "eee759327ffea293e81d0dde67921b7fcfcad279ffd7a2c9d037bbc8f882b363" +inherit pkgconfig + S = "${WORKDIR}/${BPN}-${PV}" EXTRA_OEMAKE += "'LDFLAGS=${LDFLAGS}'"
@@ -42,5 +44,3 @@ do_install() { install -m 755 ${S}/nc ${D}${bindir}/nc.${BPN} } ALTERNATIVE_PRIORITY = "60" - -PNBLACKLIST[netcat-openbsd] ?= "Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130673/"
Signature · 1 line
2.7.4