fs/pstore: constify pstore_zbackend structures
PATCH 1/1 fs/pstore: constify pstore_zbackend structures
The references of pstore_zbackend structures are stored into the pointer zbackend of type struct pstore_zbackend. The pointer zbackend can be made const as it is only dereferenced. After making this change the pstore_zbackend structures whose references are stored into the pointer zbackend can be made const too.
File size before:
text data bss dec hex filename
4817 541 172 5530 159a fs/pstore/platform.o
File size after:
text data bss dec hex filename
4865 477 172 5514 158a fs/pstore/platform.o
--- fs/pstore/platform.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
fs/pstore/platform.c +4 -4
@@ -267,7 +267,7 @@ static void free_zlib(void) big_oops_buf_sz =0 ; } -static struct pstore_zbackend backend_zlib = { +static const struct pstore_zbackend backend_zlib = { .compress = compress_zlib, .decompress = decompress_zlib, .allocate = allocate_zlib,
@@ -328,7 +328,7 @@ static void free_lzo(void) big_oops_buf_sz =0 ; } -static struct pstore_zbackend backend_lzo = { +static const struct pstore_zbackend backend_lzo = { .compress = compress_lzo, .decompress = decompress_lzo, .allocate = allocate_lzo,
@@ -389,7 +389,7 @@ static void free_lz4(void) big_oops_buf_sz =0 ; } -static struct pstore_zbackend backend_lz4 = { +static const struct pstore_zbackend backend_lz4 = { .compress = compress_lz4, .decompress = decompress_lz4, .allocate = allocate_lz4,
@@ -398,7 +398,7 @@ static void free_lz4(void) };#endif -static struct pstore_zbackend *zbackend = +static const struct pstore_zbackend *zbackend =#if defined(CONFIG_PSTORE_ZLIB_COMPRESS ) &backend_zlib;#elif defined(CONFIG_PSTORE_LZO_COMPRESS )
Signature · 1 line
1.9.1
Quoted 10 lines · Bhumika Goyal
The references of
pstore_zbackendstructures are stored into the pointer zbackend of type structpstore_zbackend. The pointer zbackend can be made const as it is only dereferenced. After making this change thepstore_zbackendstructures whose references are stored into the pointer zbackend can be made const too.File size before:
text data bss dec hex filename
4817 541 172 5530 159afs/pstore/platform.o
Quoted 5 lines
File size after:
text data bss dec hex filename
4865 477 172 5514 158afs/pstore/platform.oSigned-off-by Bhumika Goyal <[email protected]>
Awesome, thanks! I've applied this to my tree; it should be visible in -next soon.
-Kees
Signature · 2 lines
Kees Cook Pixel Security