mm/thp/autonuma: Use TNF flag instead of vm fault.
Subsystems (2)
PATCH 1/1 mm/thp/autonuma: Use TNF flag instead of vm fault.
We are using wrong flag value in task_numa_falt function. This can result in us doing wrong numa fault statistics update, because we update num_pages_migrate and numa_fault_locality etc based on the flag argument passed.
--- mm/huge_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/huge_memory.c +1 -1
@@ -1333,7 +1333,7 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)if (page_nid !=-1 )task_numa_fault (last_cpupid, page_nid,HPAGE_PMD_NR , - vmf->flags); + flags);return 0 ; }
Signature · 7 lines
2.7.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 6 lines · Aneesh Kumar K.V
We are using wrong flag value in
task_numa_faltfunction. This can result in us doing wrong numa fault statistics update, because we updatenum_pages_migrateandnuma_fault_localityetc based on the flag argument passed.Signed-off-by Aneesh Kumar K.V <[email protected]>
Fix: bae473a423 ("mm: introduce fault_env")
Quoted 18 lines
--- mm/huge_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/huge_memory.c +1
-2@@ -1333,7 +1333,7 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)if (page_nid !=-1 )task_numa_fault (last_cpupid, page_nid,HPAGE_PMD_NR , - vmf->flags); + flags);return 0 ; } --
Quoted 1 line
2.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 7 lines · Aneesh Kumar K.V
We are using wrong flag value in
task_numa_faltfunction. This can result in
us doing wrong numa fault statistics update, because we updatenum_pages_migrate
andnuma_fault_localityetc based on the flag argument passed.Signed-off-by Aneesh Kumar K.V <[email protected]>
Signature · 1 line
All Rights Reversed.
Quoted 5 lines · Aneesh Kumar K.V
We are using wrong flag value in
task_numa_faltfunction. This can result in us doing wrong numa fault statistics update, because we updatenum_pages_migrateandnuma_fault_localityetc based on the flag argument passed.Signed-off-by Aneesh Kumar K.V <[email protected]>
Ouch. My bad.
Signature · 7 lines
Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>