Skip to contentSkip to conversation

rockchip: tinker: configs: use correct mmc instance as boot target device

U-Boot Eddie Cai 2 participants 3 messages Feb 20, 2017 – Feb 23, 2017

lore
Share & tools
lore

Eddie Cai

author
#0 lore raw

We are using wrong mmc instance as boot target device now. below Jaehoon Chung's patch use mmc alias which correct it. That make tinker board can not find mmc device. So give it correct mmc device instance.

commit 02ad33aa3a84821c8d9a6c4f167f143f6248b084
Author: Jaehoon Chung <[email protected]>
Date: Thu Feb 2 13:41:14 2017 +0900

mmc: mmc-uclass: use the fixed devnum with alias node

---
 include/configs/tinker_rk3288.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/tinker_rk3288.h +1 -1
index 860eb40..c398e07 100644
@@ -13,7 +13,7 @@
 #undef BOOT_TARGET_DEVICES
 
 #define BOOT_TARGET_DEVICES(func) \
-	func(MMC, mmc, 0)
+	func(MMC, mmc, 1)
 
 #define CONFIG_ENV_IS_IN_MMC
 #define CONFIG_SYS_MMC_ENV_DEV 0
Signature · 1 line
2.7.4
Acked-by
#1 lore raw
Quoted 8 lines · Eddie Cai

We are using wrong mmc instance as boot target device now. below Jaehoon Chung's patch use mmc alias which correct it. That make tinker board can not find mmc device. So give it correct mmc device instance.

commit 02ad33aa3a84821c8d9a6c4f167f143f6248b084
Author: Jaehoon Chung <[email protected]>
Date: Thu Feb 2 13:41:14 2017 +0900

Quoted 6 lines

mmc: mmc-uclass: use the fixed devnum with alias node

---
 include/configs/tinker_rk3288.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
#2 lore raw
Quoted 9 lines · Simon Glass
Quoted 8 lines · Eddie Cai

We are using wrong mmc instance as boot target device now. below Jaehoon Chung's patch use mmc alias which correct it. That make tinker board can not find mmc device. So give it correct mmc device instance.

        commit 02ad33aa3a84821c8d9a6c4f167f143f6248b084
        Author: Jaehoon Chung <[email protected]>
        Date:   Thu Feb 2 13:41:14 2017 +0900
Quoted 8 lines
Quoted 6 lines

mmc: mmc-uclass: use the fixed devnum with alias node

---
 include/configs/tinker_rk3288.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-rockchip, thanks!