macsec: fix validation failed in asynchronous operation.
Subsystems (4)
PATCH v2 1/1 macsec: fix validation failed in asynchronous operation.
MACSec test failed when asynchronous crypto operations is used. It encounters packet validation failed since macsec_skb_cb(skb)->valid is always 'false'.
This patch adds missing "macsec_skb_cb(skb)->valid = true" in macsec_decrypt_done() when "err == 0".
---
Changes since v2:
- fix indentation and replace "err == 0" with "!err". Changes since v1:
- add "err == 0" to check decrypt status.
drivers/net/macsec.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/macsec.c +3 -0
@@ -879,6 +879,9 @@ static void macsec_decrypt_done(struct crypto_async_request *base, int err)aead_request_free (macsec_skb_cb (skb)->req); +if (!err) +macsec_skb_cb (skb)->valid = true; +rcu_read_lock_bh (); pn =ntohl (macsec_ethhdr (skb)->packet_number);if (!macsec_post_decrypt (skb, &macsec->secy, pn)) {
Signature · 1 line
1.9.1
From: Ryder Lee <[email protected]>
Date: Tue, 21 Feb 2017 17:40:45 +0800
Quoted 8 lines
MACSec test failed when asynchronous crypto operations is used. It encounters packet validation failed since macsec_skb_cb(skb)->valid is always 'false'.
This patch adds missing "macsec_skb_cb(skb)->valid = true" in
macsec_decrypt_done()when "err == 0".Signed-off-by Ryder Lee <[email protected]>
Applied, thanks.