proc: Remove cast from memory allocation
Subsystems (2)
PATCH 1/1 proc: Remove cast from memory allocation
Coccinelle emits WARNING: casting value returned by memory allocation function to (struct proc_inode *) is useless.
Remove unnecessary cast.
Signed-off-by Tobin C. Harding <[email protected]>
--- fs/proc/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/proc/inode.c +1 -1
@@ -57,7 +57,7 @@ static struct inode *proc_alloc_inode(struct super_block *sb)struct proc_inode *ei;struct inode *inode; - ei = (struct proc_inode *)kmem_cache_alloc (proc_inode_cachep,GFP_KERNEL ); + ei =kmem_cache_alloc (proc_inode_cachep,GFP_KERNEL );if (!ei)return NULL ; ei->pid =NULL ;
Signature · 1 line
2.7.4
Quoted 6 lines · Tobin C. Harding
Coccinelle emits WARNING: casting value returned by memory allocation function to (struct
proc_inode*) is useless.Remove unnecessary cast.
Signed-off-by Tobin C. Harding <[email protected]>
Acked-by Kees Cook <[email protected]>
-Kees
Quoted 20 lines
--- fs/proc/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/proc/inode.c +1
-2@@ -57,7 +57,7 @@ static struct inode *proc_alloc_inode(struct super_block *sb)struct proc_inode *ei;struct inode *inode; - ei = (struct proc_inode *)kmem_cache_alloc (proc_inode_cachep,GFP_KERNEL ); + ei =kmem_cache_alloc (proc_inode_cachep,GFP_KERNEL );if (!ei)return NULL ; ei->pid =NULL ; --2.7.4
Signature · 2 lines
Kees Cook Pixel Security