drm/i915/selftests: don't leak the gem object
Subsystems (2)
PATCH 1/1 drm/i915/selftests: don't leak the gem object
For our fake dma objects we can leak the underlying gem object if we fail to pin our "backing storage".
[ 39.952618] ============================================================================= [ 39.952625] BUG mock_object (Tainted: G U ): Objects remaining in mock_object on __kmem_cache_shutdown() [ 39.952629] -----------------------------------------------------------------------------
[ 39.952633] Disabling lock debugging due to kernel taint [ 39.952635] INFO: Slab 0xffffea00086c6a00 objects=21 used=1 fp=0xffff88021b1abc00 flags=0x5fff8000008100 [ 39.952640] CPU: 1 PID: 1258 Comm: drv_selftest Tainted: G BU 4.10.0+ #46 [ 39.952641] Hardware name: Apple Inc. MacBookPro11,1/Mac-189A3D4F975D5FFC, BIOS MBP111.88Z.0138.B17.1602221718 02/22/2016 [ 39.952642] Call Trace: [ 39.952648] dump_stack+0x4d/0x6f [ 39.952651] slab_err+0x9d/0xb0 [ 39.952654] ? ksm_migrate_page+0xe0/0xe0 [ 39.952657] ? on_each_cpu_cond+0x9a/0xc0 [ 39.952658] ? __kmalloc+0x1af/0x1c0 [ 39.952660] ? __kmem_cache_shutdown+0x173/0x3e0 [ 39.952661] __kmem_cache_shutdown+0x196/0x3e0 [ 39.952664] kmem_cache_destroy+0xa0/0x150 [ 39.952708] mock_device_release+0x113/0x140 [i915] [ 39.952726] drm_dev_release+0x20/0x40 [drm] [ 39.952735] drm_dev_unref+0x23/0x30 [drm] [ 39.952768] i915_gem_gtt_mock_selftests+0x55/0x70 [i915] [ 39.952803] __run_selftests+0x169/0x1c0 [i915] [ 39.952805] ? 0xffffffffa0151000 [ 39.952840] i915_mock_selftests+0x30/0x60 [i915] [ 39.952869] i915_init+0xc/0x78 [i915] [ 39.952870] ? 0xffffffffa0151000 [ 39.952872] do_one_initcall+0x43/0x170 [ 39.952874] ? __vunmap+0x81/0xd0 [ 39.952875] ? kmem_cache_alloc_trace+0x37/0x170 [ 39.952877] ? do_init_module+0x27/0x1f8 [ 39.952879] do_init_module+0x5f/0x1f8 [ 39.952881] load_module+0x2423/0x29b0 [ 39.952882] ? __symbol_put+0x40/0x40 [ 39.952885] ? kernel_read_file+0x1a3/0x1c0 [ 39.952887] SYSC_finit_module+0xbc/0xf0 [ 39.952889] SyS_finit_module+0xe/0x10 [ 39.952892] entry_SYSCALL_64_fastpath+0x13/0x94
--- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +3 -1
@@ -111,8 +111,10 @@ fake_dma_object(struct drm_i915_private *i915, u64 size) obj->cache_level =I915_CACHE_NONE ;/* Preallocate the "backing storage" */ -if (i915_gem_object_pin_pages (obj)) +if (i915_gem_object_pin_pages (obj)) { +i915_gem_object_free (obj);return ERR_PTR (-ENOMEM ); + }i915_gem_object_unpin_pages (obj);return obj;
Signature · 6 lines
2.9.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/selftests: don't leak the gem object
== Series Details ==
== Series Details ==
Series: drm/i915/selftests: don't leak the gem object
URL : https://patchwork.freedesktop.org/series/20050/
State : success
== Summary ==
Series 20050v1 drm/i915/selftests: don't leak the gem object
https://patchwork.freedesktop.org/api/1.0/series/20050/revisions/1/mbox/
fi-bdw-5557u total:253 pass:242 dwarn:0 dfail:0 fail:0 skip:11 fi-bsw-n3050 total:253 pass:214 dwarn:0 dfail:0 fail:0 skip:39 fi-bxt-j4205 total:253 pass:234 dwarn:0 dfail:0 fail:0 skip:19 fi-bxt-t5700 total:83 pass:70 dwarn:0 dfail:0 fail:0 skip:12 fi-byt-j1900 total:253 pass:226 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-n2820 total:253 pass:222 dwarn:0 dfail:0 fail:0 skip:31 fi-hsw-4770 total:253 pass:237 dwarn:0 dfail:0 fail:0 skip:16 fi-hsw-4770r total:253 pass:237 dwarn:0 dfail:0 fail:0 skip:16 fi-ilk-650 total:253 pass:203 dwarn:0 dfail:0 fail:0 skip:50 fi-ivb-3520m total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-ivb-3770 total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-kbl-7500u total:253 pass:235 dwarn:0 dfail:0 fail:0 skip:18 fi-skl-6260u total:253 pass:243 dwarn:0 dfail:0 fail:0 skip:10 fi-skl-6700hq total:253 pass:236 dwarn:0 dfail:0 fail:0 skip:17 fi-skl-6700k total:253 pass:231 dwarn:4 dfail:0 fail:0 skip:18 fi-skl-6770hq total:253 pass:243 dwarn:0 dfail:0 fail:0 skip:10 fi-snb-2520m total:253 pass:225 dwarn:0 dfail:0 fail:0 skip:28 fi-snb-2600 total:253 pass:224 dwarn:0 dfail:0 fail:0 skip:29
e922d8924920be31fc76f5813bc1fde5d6cbf950 drm-tip: 2017y-02m-21d-16h-18m-14s UTC integration manifest 48c35ad drm/i915/selftests: don't leak the gem object
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3924/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for drm/i915/selftests: don't leak the gem object
Quoted 10 lines · Patchwork
== Series Details ==
Series: drm/i915/selftests: don't leak the gem object
URL : https://patchwork.freedesktop.org/series/20050/
State : success== Summary ==
Series 20050v1 drm/i915/selftests: don't leak the gem object
https://patchwork.freedesktop.org/api/1.0/series/20050/revisions/1/mbox/
Hmm, checked on pw, probably better to use i915_gem_object_put(). Calling free_object directly is a bad habit :)
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 45 lines · Matthew Auld
For our fake dma objects we can leak the underlying gem object if we fail to pin our "backing storage".
[ 39.952618] =============================================================================
[ 39.952625] BUGmock_object(Tainted: G U ): Objects remaining inmock_objecton__kmem_cache_shutdown()[ 39.952629] -----------------------------------------------------------------------------[ 39.952633] Disabling lock debugging due to kernel taint
[ 39.952635] INFO: Slab0xffffea00086c6a00objects=21 used=1 fp=0xffff88021b1abc00 flags=0x5fff8000008100 [ 39.952640] CPU: 1 PID: 1258 Comm:drv_selftestTainted: G BU 4.10.0+ #46
[ 39.952641] Hardware name: Apple Inc. MacBookPro11,1/Mac-189A3D4F975D5FFC, BIOS MBP111.88Z.0138.B17.1602221718 02/22/2016 [ 39.952642] Call Trace:
[ 39.952648] dump_stack+0x4d/0x6f
[ 39.952651] slab_err+0x9d/0xb0
[ 39.952654] ?ksm_migrate_page+0xe0/0xe0
[ 39.952657] ?on_each_cpu_cond+0x9a/0xc0
[ 39.952658] ?__kmalloc+0x1af/0x1c0
[ 39.952660] ?__kmem_cache_shutdown+0x173/0x3e0
[ 39.952661] __kmem_cache_shutdown+0x196/0x3e0
[ 39.952664] kmem_cache_destroy+0xa0/0x150
[ 39.952708] mock_device_release+0x113/0x140 [i915]
[ 39.952726] drm_dev_release+0x20/0x40 [drm]
[ 39.952735] drm_dev_unref+0x23/0x30 [drm]
[ 39.952768] i915_gem_gtt_mock_selftests+0x55/0x70 [i915]
[ 39.952803] __run_selftests+0x169/0x1c0 [i915]
[ 39.952805] ?0xffffffffa0151000
[ 39.952840] i915_mock_selftests+0x30/0x60 [i915]
[ 39.952869] i915_init+0xc/0x78 [i915]
[ 39.952870] ?0xffffffffa0151000
[ 39.952872] do_one_initcall+0x43/0x170
[ 39.952874] ?__vunmap+0x81/0xd0
[ 39.952875] ?kmem_cache_alloc_trace+0x37/0x170
[ 39.952877] ?do_init_module+0x27/0x1f8
[ 39.952879] do_init_module+0x5f/0x1f8
[ 39.952881] load_module+0x2423/0x29b0
[ 39.952882] ?__symbol_put+0x40/0x40
[ 39.952885] ?kernel_read_file+0x1a3/0x1c0
[ 39.952887] SYSC_finit_module+0xbc/0xf0
[ 39.952889] SyS_finit_module+0xe/0x10
[ 39.952892] entry_SYSCALL_64_fastpath+0x13/0x94Fixes 8d28ba4568f4 ("drm/i915: Exercise filling the top/bottom portions of the ppgtt")Signed-off-by Matthew Auld <[email protected]>Cc Chris Wilson <[email protected]>Cc Joonas Lahtinen <[email protected]>
<SNIP>
Review fake_dma_object(struct drm_i915_private *i915, u64 size)
Quoted 1 line
(quoted diff) +0
-0@@ -111,8 +111,10 @@ fake_dma_object(struct drm_i915_private *i915, u64 size)
if (!obj)
goto err;
<SNIP>
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c fake_dma_object(struct drm_i915_private *i915, u64 size) · line 114
Quoted 4 lines
obj->cache_level=I915_CACHE_NONE;
/* Preallocate the "backing storage" */drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +0
-1-if (i915_gem_object_pin_pages (obj))
goto err_obj;
Quoted 7 lines
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +2
-0+if (i915_gem_object_pin_pages (obj)) { +i915_gem_object_free (obj);return
ERR_PTR(-ENOMEM);drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +1
-0+ }
i915_gem_object_unpin_pages(obj);
return obj;
err_obj:
i915_gem_object_free(obj); err: return ERR_PTR(-ENOMEM);
With the proper onion teardown;
Regards, Joonas
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx