Skip to contentSkip to conversation

ncpfs: Remove cast from memory allocation

PATCH Superseded Tobin C. Harding 2 participants 2 messages Feb 22, 2017 Kernel janitors

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ncpfs: Remove cast from memory allocation

Coccinelle emits WARNING: casting value returned by memory allocation function to (struct ncp_inode_info *) is useless.

Remove unnecessary cast.

Changes since v1:
- Fix up typo

---

Kernel built successfully with patch applied.

 fs/ncpfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ncpfs/inode.c +1 -1
index 7eb89c2..7a9ed33 100644
@@ -52,7 +52,7 @@ static struct kmem_cache * ncp_inode_cachep;
 static struct inode *ncp_alloc_inode(struct super_block *sb)
 {
 	struct ncp_inode_info *ei;
-	ei = (struct ncp_inode_info *)kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
+	ei = kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
 	if (!ei)
 		return NULL;
 	return &ei->vfs_inode;
Signature · 1 line
2.7.4
#1 lore raw
Quoted 7 lines · Tobin C. Harding

Coccinelle emits WARNING: casting value returned by memory allocation function to (struct ncp_inode_info *) is useless.

Remove unnecessary cast.

Changes since v1:
- Fix up typo

Changes since v1 goes below the ---. When this ends up in the git history, no one will care about the changes since v1, because v1 won't be part of the history.

julia

Quoted 30 lines

---

Kernel built successfully with patch applied.

 fs/ncpfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ncpfs/inode.c +1 -2
index 7eb89c2..7a9ed33 100644
@@ -52,7 +52,7 @@ static struct kmem_cache * ncp_inode_cachep;
 static struct inode *ncp_alloc_inode(struct super_block *sb)
 {
 	struct ncp_inode_info *ei;
-	ei = (struct ncp_inode_info *)kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
+	ei = kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
 	if (!ei)
 		return NULL;
 	return &ei->vfs_inode;
--

2.7.4

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html