hpsa: expose enclosures
Subsystems (2)
PATCH v2 1/1 hpsa: expose enclosures
Some servers have a built-in enclosure which will show up on the same bus as the internal physical devices. This patch fixes the driver to expose them.
--- drivers/scsi/hpsa.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/scsi/hpsa.c +4 -1
@@ -4407,7 +4407,10 @@ static void hpsa_update_scsi_devices(struct ctlr_info *h)* Expose all devices except for physical devices that * are masked. */ -if (MASKED_DEVICE (lunaddrbytes) && this_device->physical_device) +if (this_device->devtype ==TYPE_ENCLOSURE ) + this_device->expose_device =1 ; +else if (MASKED_DEVICE (lunaddrbytes) && + this_device->physical_device) this_device->expose_device =0 ;else this_device->expose_device =1 ;
Signature · 1 line
1.8.5.6
Quoted 13 lines
-----Original Message-----
From: Hannes Reinecke [mailto:[email protected]]
Sent: Thursday, February 23, 2017 4:55 AM
To: Martin K. Petersen <[email protected]>
Cc: Christoph Hellwig <[email protected]>; James Bottomley <[email protected]>; [email protected]; Hannes Reinecke <[email protected]>; Don Brace <[email protected]>; Hannes Reinecke <[email protected]>
Subject: [PATCHv2] hpsa: expose enclosuresEXTERNAL EMAIL
Quoted 6 lines
Some servers have a built-in enclosure which will show up on the same bus as the internal physical devices. This patch fixes the driver to expose them.
Cc Don Brace <[email protected]>Signed-off-by Hannes Reinecke <[email protected]>
Masking various SES targets is a conscious choice, not a design oversight. So, I have to decline this patch.,
Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation
Quoted 24 lines
--- drivers/scsi/hpsa.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/scsi/hpsa.c +4
-1@@ -4407,7 +4407,10 @@ static void hpsa_update_scsi_devices(structctlr_info *h) * Expose all devices except for physical devices that * are masked. */ -if (MASKED_DEVICE (lunaddrbytes) && this_device- >physical_device) +if (this_device->devtype ==TYPE_ENCLOSURE ) + this_device->expose_device =1 ; +else if (MASKED_DEVICE (lunaddrbytes) && + this_device->physical_device) this_device->expose_device =0 ;else this_device->expose_device = 1;--
1.8.5.6
Quoted 17 lines · Don Brace
Quoted 17 lines
-----Original Message-----
From: Hannes Reinecke [mailto:[email protected]]
Sent: Thursday, February 23, 2017 4:55 AM
To: Martin K. Petersen <[email protected]>
Cc: Christoph Hellwig <[email protected]>; James Bottomley <[email protected]>; [email protected]; Hannes Reinecke <[email protected]>; Don Brace <[email protected]>; Hannes Reinecke <[email protected]>
Subject: [PATCHv2] hpsa: expose enclosuresEXTERNAL EMAIL
Some servers have a built-in enclosure which will show up on the same bus as the internal physical devices. This patch fixes the driver to expose them.
Quoted 6 lines
Quoted 2 lines
Cc Don Brace <[email protected]>Signed-off-by Hannes Reinecke <[email protected]>Masking various SES targets is a conscious choice, not a design oversight. So, I have to decline this patch.,
Would you be okay with a module parameter for this?
It really feels stupid to present the user with an enclosure device during boot (as hpsa presents all physical LUNs during booting), but not exporting it to the user.
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
Quoted 37 lines
-----Original Message-----
From: Hannes Reinecke [mailto:[email protected]]
Sent: Tuesday, March 07, 2017 9:25 AM
To: Don Brace <[email protected]>; Hannes Reinecke <[email protected]>; Martin K. Petersen <[email protected]>
Cc: Christoph Hellwig <[email protected]>; James Bottomley <[email protected]>; [email protected]
Subject: Re: [PATCHv2] hpsa: expose enclosuresEXTERNAL EMAIL
Quoted 17 lines · Don Brace
Quoted 17 lines
-----Original Message-----
From: Hannes Reinecke [mailto:[email protected]]
Sent: Thursday, February 23, 2017 4:55 AM
To: Martin K. Petersen <[email protected]>
Cc: Christoph Hellwig <[email protected]>; James Bottomley <[email protected]>; [email protected]; Hannes Reinecke <[email protected]>; Don Brace <[email protected]>; Hannes Reinecke <[email protected]>
Subject: [PATCHv2] hpsa: expose enclosuresEXTERNAL EMAIL
Some servers have a built-in enclosure which will show up on the same bus as the internal physical devices. This patch fixes the driver to expose them.
Quoted 6 lines
Quoted 2 lines
Cc Don Brace <[email protected]>Signed-off-by Hannes Reinecke <[email protected]>Masking various SES targets is a conscious choice, not a design oversight. So, I have to decline this patch.,
Quoted 8 lines
Would you be okay with a module parameter for this?
It really feels stupid to present the user with an enclosure device during boot (as hpsa presents all physical LUNs during booting), but not exporting it to the user.Cheers,
Hannes
We would not be able to support this as it can cause issues with
LED management. A customer could pull the wrong drive and lose data because the LED state was incorrect. That results in support issues.
We like to show the enclosures even if masked as it helps with diagnosing problems.
Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation
Quoted 6 lines
--
Dr. Hannes Reinecke zSeries & Storage
[email protected] +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)