Skip to contentSkip to conversation

travis-ci: add "make distcheck" to test scenario

PATCH In review Ilya Shipitsin 2 participants 4 messages Feb 23, 2017 – Feb 25, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 travis-ci: add "make distcheck" to test scenario

in rare cases openvpn is built from tarball, it happens during "installer build" process. "make distcheck" helps to prevent problems during such builds.

---
 .travis.yml | 1 +
 1 file changed, 1 insertion(+)
.travis.yml +1 -0
index a68374a..6ebfa39 100644
@@ -79,6 +79,7 @@ script:
   - if [ "${TRAVIS_OS_NAME}" = "osx"   ]; then export DYLD_LIBRARY_PATH="${PREFIX}/lib:${DYLD_LIBRARY_PATH}"; fi
   - autoreconf -vi
   - ./configure --with-crypto-library="${SSLLIB}" ${EXTRA_CONFIG} || (cat config.log && exit 1)
+  - make distcheck > build.log 2>&1 || (cat build.log && exit 1)
   - make -j$JOBS
   - src/openvpn/openvpn --version || true
   - if [ "${TRAVIS_OS_NAME}" = "linux" ]; then ldd src/openvpn/openvpn; fi
Signature · 1 line
2.5.5
#1 lore raw

ack ? nack ?

2017-02-23 23:22 GMT+05:00 Ilya Shipitsin <[email protected]...>:

Quoted 27 lines

in rare cases openvpn is built from tarball, it happens during "installer build"
process. "make distcheck" helps to prevent problems during such builds.

---
 .travis.yml | 1 +
 1 file changed, 1 insertion(+)
.travis.yml +0 -0
index a68374a..6ebfa39 100644
@@ -79,6 +79,7 @@ script:
   - if [ "${TRAVIS_OS_NAME}" = "osx"   ]; then export

DYLD_LIBRARY_PATH="${PREFIX}/lib:${DYLD_LIBRARY_PATH}"; fi
- autoreconf -vi
- ./configure --with-crypto-library="${SSLLIB}" ${EXTRA_CONFIG} ||
(cat config.log && exit 1)
+ - make distcheck > build.log 2>&1 || (cat build.log && exit 1)
- make -j$JOBS
- src/openvpn/openvpn --version || true
- if [ "${TRAVIS_OS_NAME}" = "linux" ]; then ldd src/openvpn/openvpn; fi
--
2.5.5

#2 lore raw
In reply to Ilya Shipitsin

Hi,

Quoted 14 lines · Ilya Shipitsin

in rare cases openvpn is built from tarball, it happens during "installer build" process. "make distcheck" helps to prevent problems during such builds.

---
 .travis.yml | 1 +
 1 file changed, 1 insertion(+)
.travis.yml +0 -0
index a68374a..6ebfa39 100644

.travis.yml script: · line 85

Quoted 7 lines
.travis.yml +1 -0
@@ -79,6 +79,7 @@ script:
   - if [ "${TRAVIS_OS_NAME}" = "osx"   ]; then export DYLD_LIBRARY_PATH="${PREFIX}/lib:${DYLD_LIBRARY_PATH}"; fi
   - autoreconf -vi
   - ./configure --with-crypto-library="${SSLLIB}" ${EXTRA_CONFIG} || (cat config.log && exit 1)
+  - make distcheck > build.log 2>&1 || (cat build.log && exit 1)
   - make -j$JOBS
   - src/openvpn/openvpn --version || true
   - if [ "${TRAVIS_OS_NAME}" = "linux" ]; then ldd src/openvpn/openvpn; fi

Running 'make distcheck' from travis is a good idea. But, I think it should be done *after* 'make check'. Futhermore, it would be nice to only do this for one of the configurations, to keep our travis runs as lightweight as possible (saves devs some waiting time, saves travis energy/capacity).

-Steffan

#3 lore raw

2017-02-25 21:10 GMT+05:00 Steffan Karger <[email protected]...>:

Quoted 26 lines

Hi,

Quoted 1 line · Ilya Shipitsin

in rare cases openvpn is built from tarball, it happens during

"installer build"

.travis.yml script: · line 79

Quoted 13 lines

process. "make distcheck" helps to prevent problems during such builds.

---
 .travis.yml | 1 +
 1 file changed, 1 insertion(+)
.travis.yml +0 -0
index a68374a..6ebfa39 100644
@@ -79,6 +79,7 @@ script:
   - if [ "${TRAVIS_OS_NAME}" = "osx"   ]; then export

DYLD_LIBRARY_PATH="${PREFIX}/lib:${DYLD_LIBRARY_PATH}"; fi

.travis.yml script: · line 81

Quoted 2 lines
.travis.yml +0 -0
   - autoreconf -vi
   - ./configure --with-crypto-library="${SSLLIB}" ${EXTRA_CONFIG} ||

(cat config.log && exit 1)

.travis.yml script:

Quoted 4 lines
.travis.yml +1 -0
+  - make distcheck > build.log 2>&1 || (cat build.log && exit 1)
   - make -j$JOBS
   - src/openvpn/openvpn --version || true
   - if [ "${TRAVIS_OS_NAME}" = "linux" ]; then ldd src/openvpn/openvpn;
Quoted 9 lines

fi

Quoted 1 line

Running 'make distcheck' from travis is a good idea. But, I think it should be done *after* 'make check'. Futhermore, it would be nice to only do this for one of the configurations, to keep our travis runs as lightweight as possible (saves devs some waiting time, saves travis energy/capacity).

I think we can introduce ADDITIONAL_SCRIPT env, and, if it is defined, run script defined in that variable

Quoted 12 lines

-Steffan

------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel