tpm: msleep() delays - replace with usleep_range() in i2c nuvoton driver
RFC PATCH 1/1 tpm: msleep() delays - replace with usleep_range() in i2c nuvoton driver
Commit 500462a9de65 "timers: Switch to a non-cascading wheel" replaced the 'classic' timer wheel, which aimed for near 'exact' expiry of the timers. Their analysis was that the vast majority of timeout timers are used as safeguards, not as real timers, and are cancelled or rearmed before expiration. The only exception noted to this were networking timers with a small expiry time.
Not included in the analysis was the TPM polling timer, which resulted in a longer normal delay and, every so often, a very long delay. The non-cascading wheel delay is based on CONFIG_HZ. For a description of the different rings and their delays, refer to the comments in kernel/time/timer.c.
Below are the delays given for rings 0 - 2, which explains the longer "normal" delays and the very, long delays as seen on systems with CONFIG_HZ 250.
* HZ 1000 steps
* Level Offset Granularity Range
* 0 0 1 ms 0 ms - 63 ms * 1 64 8 ms 64 ms - 511 ms * 2 128 64 ms 512 ms - 4095 ms (512ms - ~4s)
* HZ 250
* Level Offset Granularity Range
* 0 0 4 ms 0 ms - 255 ms * 1 64 32 ms 256 ms - 2047 ms (256ms - ~2s) * 2 128 256 ms 2048 ms - 16383 ms (~2s - ~16s)
Below is a comparison of extending the TPM with 1000 measurements, using msleep() vs. usleep_delay() when configured for 1000 hz vs. 250 hz, before and after commit 500462a9de65.
linux-4.7 | msleep() usleep_range()
1000 hz: 0m44.628s | 1m34.497s 29.243s
250 hz: 1m28.510s | 4m49.269s 32.386s
linux-4.7 | min-max (msleep) min-max (usleep_range)
1000 hz: 0:017 - 2:760s | 0:015 - 3:967s 0:014 - 0:418s 250 hz: 0:028 - 1:954s | 0:040 - 4:096s 0:016 - 0:816s
This patch replaces the msleep() with usleep_range() calls in the i2c nuvoton driver with a consistent max range value.
--- drivers/char/tpm/tpm_i2c_nuvoton.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/char/tpm/tpm_i2c_nuvoton.c +10 -8
@@ -49,9 +49,9 @@*/ #define TPM_I2C_MAX_BUF_SIZE 32#define TPM_I2C_RETRY_COUNT 32 -#define TPM_I2C_BUS_DELAY 1/* msec */ -#define TPM_I2C_RETRY_DELAY_SHORT 2/* msec */ -#define TPM_I2C_RETRY_DELAY_LONG 10/* msec */ +#define TPM_I2C_BUS_DELAY 1000/* usec */ +#define TPM_I2C_RETRY_DELAY_SHORT 2 * 1000/* usec */ +#define TPM_I2C_RETRY_DELAY_LONG 10 * 1000/* usec */ #define OF_IS_TPM2 ((void *)1)#define I2C_IS_TPM2 1
@@ -123,7 +123,7 @@ static s32 i2c_nuvoton_write_status(struct i2c_client *client, u8 data)/* this causes the current command to be aborted */ for (i =0 , status =-1 ; i <TPM_I2C_RETRY_COUNT && status <0 ; i++) { status =i2c_nuvoton_write_buf (client,TPM_STS ,1 , &data); -msleep (TPM_I2C_BUS_DELAY ); +usleep_range (TPM_I2C_BUS_DELAY ,TPM_I2C_BUS_DELAY +300 ); }return status; }
@@ -160,7 +160,7 @@ static int i2c_nuvoton_get_burstcount(struct i2c_client *client, burst_count =min_t (u8,TPM_I2C_MAX_BUF_SIZE , data);break ; } -msleep (TPM_I2C_BUS_DELAY ); +usleep_range (TPM_I2C_BUS_DELAY ,TPM_I2C_BUS_DELAY +300 ); }while (time_before (jiffies, stop));return burst_count;
@@ -203,13 +203,15 @@ static int i2c_nuvoton_wait_for_stat(struct tpm_chip *chip, u8 mask, u8 value,return 0 ;/* use polling to wait for the event */ - ten_msec = jiffies +msecs_to_jiffies (TPM_I2C_RETRY_DELAY_LONG ); + ten_msec = jiffies +usecs_to_jiffies (TPM_I2C_RETRY_DELAY_LONG ); stop = jiffies + timeout; do { if (time_before(jiffies, ten_msec)) - msleep(TPM_I2C_RETRY_DELAY_SHORT); + usleep_range(TPM_I2C_RETRY_DELAY_SHORT, + TPM_I2C_RETRY_DELAY_SHORT + 300); else - msleep(TPM_I2C_RETRY_DELAY_LONG); + usleep_range(TPM_I2C_RETRY_DELAY_LONG, + TPM_I2C_RETRY_DELAY_LONG + 300); status_valid = i2c_nuvoton_check_status(chip, mask, value); if (status_valid)
Signature · 6 lines
2.9.3 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
Quoted 41 lines · Mimi Zohar
Commit
500462a9de65"timers: Switch to a non-cascading wheel" replaced the 'classic' timer wheel, which aimed for near 'exact' expiry of the timers. Their analysis was that the vast majority of timeout timers are used as safeguards, not as real timers, and are cancelled or rearmed before expiration. The only exception noted to this were networking timers with a small expiry time.Not included in the analysis was the TPM polling timer, which resulted in a longer normal delay and, every so often, a very long delay. The non-cascading wheel delay is based on
CONFIG_HZ. For a description of the different rings and their delays, refer to the comments inkernel/time/timer.c.Below are the delays given for rings 0 - 2, which explains the longer "normal" delays and the very, long delays as seen on systems with
CONFIG_HZ250.* HZ 1000 steps
* Level Offset Granularity Range* 0 0 1 ms 0 ms - 63 ms * 1 64 8 ms 64 ms - 511 ms * 2 128 64 ms 512 ms - 4095 ms (512ms - ~4s)* HZ 250
* Level Offset Granularity Range* 0 0 4 ms 0 ms - 255 ms * 1 64 32 ms 256 ms - 2047 ms (256ms - ~2s) * 2 128 256 ms 2048 ms - 16383 ms (~2s - ~16s)Below is a comparison of extending the TPM with 1000 measurements, using
msleep()vs.usleep_delay()when configured for 1000 hz vs. 250 hz, before and after commit500462a9de65.linux-4.7 | msleep() usleep_range()1000 hz: 0m44.628s | 1m34.497s 29.243s
250 hz: 1m28.510s | 4m49.269s 32.386slinux-4.7 | min-max (msleep) min-max (
usleep_range)1000 hz: 0:017 - 2:760s | 0:015 - 3:967s 0:014 - 0:418s 250 hz: 0:028 - 1:954s | 0:040 - 4:096s 0:016 - 0:816s
Quoted 7 lines
This patch replaces the
msleep()withusleep_range()calls in the i2c nuvoton driver with a consistent max range value.Signed-of-by Mimi Zohar <[email protected]>Reviewed-by Nayna Jain <[email protected]>drivers/char/tpm/tpm_i2c_nuvoton.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
I wasn't aware of any of these, changes it but it makes sense to me..
drivers/char/tpm/tpm_i2c_nuvoton.c line 54
Quoted 13 lines
drivers/char/tpm/tpm_i2c_nuvoton.c +4
-3+++ b/drivers/char/tpm/tpm_i2c_nuvoton.c@@ -49,9 +49,9 @@*/ #define TPM_I2C_MAX_BUF_SIZE 32#define TPM_I2C_RETRY_COUNT 32 -#define TPM_I2C_BUS_DELAY 1/* msec */ -#define TPM_I2C_RETRY_DELAY_SHORT 2/* msec */ -#define TPM_I2C_RETRY_DELAY_LONG 10/* msec */ +#define TPM_I2C_BUS_DELAY 1000/* usec */ +#define TPM_I2C_RETRY_DELAY_SHORT 2 * 1000/* usec */ +#define TPM_I2C_RETRY_DELAY_LONG 10 * 1000/* usec */
While you are here could you put () around those #define expressions?
drivers/char/tpm/tpm_i2c_nuvoton.c line 55
Quoted 2 lines
drivers/char/tpm/tpm_i2c_nuvoton.c +1
-1-msleep (TPM_I2C_BUS_DELAY ); +usleep_range (TPM_I2C_BUS_DELAY ,TPM_I2C_BUS_DELAY +300 );
And we may as well have a constant for the 300 with a little explanation comment that usleep_range is now required to get small sleeps.
Jason
Quoted 52 lines · Jason Gunthorpe
Quoted 41 lines · Mimi Zohar
Commit
500462a9de65"timers: Switch to a non-cascading wheel" replaced the 'classic' timer wheel, which aimed for near 'exact' expiry of the timers. Their analysis was that the vast majority of timeout timers are used as safeguards, not as real timers, and are cancelled or rearmed before expiration. The only exception noted to this were networking timers with a small expiry time.Not included in the analysis was the TPM polling timer, which resulted in a longer normal delay and, every so often, a very long delay. The non-cascading wheel delay is based on
CONFIG_HZ. For a description of the different rings and their delays, refer to the comments inkernel/time/timer.c.Below are the delays given for rings 0 - 2, which explains the longer "normal" delays and the very, long delays as seen on systems with
CONFIG_HZ250.* HZ 1000 steps
* Level Offset Granularity Range* 0 0 1 ms 0 ms - 63 ms * 1 64 8 ms 64 ms - 511 ms * 2 128 64 ms 512 ms - 4095 ms (512ms - ~4s)* HZ 250
* Level Offset Granularity Range* 0 0 4 ms 0 ms - 255 ms * 1 64 32 ms 256 ms - 2047 ms (256ms - ~2s) * 2 128 256 ms 2048 ms - 16383 ms (~2s - ~16s)Below is a comparison of extending the TPM with 1000 measurements, using
msleep()vs.usleep_delay()when configured for 1000 hz vs. 250 hz, before and after commit500462a9de65.linux-4.7 | msleep() usleep_range()1000 hz: 0m44.628s | 1m34.497s 29.243s
250 hz: 1m28.510s | 4m49.269s 32.386slinux-4.7 | min-max (msleep) min-max (
usleep_range)1000 hz: 0:017 - 2:760s | 0:015 - 3:967s 0:014 - 0:418s 250 hz: 0:028 - 1:954s | 0:040 - 4:096s 0:016 - 0:816sQuoted 7 lines
This patch replaces the
msleep()withusleep_range()calls in the i2c nuvoton driver with a consistent max range value.Signed-of-by Mimi Zohar <[email protected]>Reviewed-by Nayna Jain <[email protected]>drivers/char/tpm/tpm_i2c_nuvoton.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)I wasn't aware of any of these, changes it but it makes sense to me..
Quoted 15 lines
drivers/char/tpm/tpm_i2c_nuvoton.c line 54
Quoted 13 lines
drivers/char/tpm/tpm_i2c_nuvoton.c +4
-3+++ b/drivers/char/tpm/tpm_i2c_nuvoton.c@@ -49,9 +49,9 @@*/ #define TPM_I2C_MAX_BUF_SIZE 32#define TPM_I2C_RETRY_COUNT 32 -#define TPM_I2C_BUS_DELAY 1/* msec */ -#define TPM_I2C_RETRY_DELAY_SHORT 2/* msec */ -#define TPM_I2C_RETRY_DELAY_LONG 10/* msec */ +#define TPM_I2C_BUS_DELAY 1000/* usec */ +#define TPM_I2C_RETRY_DELAY_SHORT 2 * 1000/* usec */ +#define TPM_I2C_RETRY_DELAY_LONG 10 * 1000/* usec */ While you are here could you put () around those #define expressions?
Sure
Quoted 6 lines
drivers/char/tpm/tpm_i2c_nuvoton.c line 55
Quoted 2 lines
drivers/char/tpm/tpm_i2c_nuvoton.c +1
-1-msleep (TPM_I2C_BUS_DELAY ); +usleep_range (TPM_I2C_BUS_DELAY ,TPM_I2C_BUS_DELAY +300 );And we may as well have a constant for the 300 with a little explanation comment that
usleep_rangeis now required to get small sleeps.
For 250 hz, level 0 delay should be between 0 - 255ms, which is less than the 300 defined here. So before we start changing everything to use usleep_range(), I think we need to better understand what is happening. Any suggestions/recommendations would be much appreciated!
Mimi
We continued analyzing the msleep() behaviour. I tested running msleep() (without TPM interactions), by writing a kernel module that runs msleep() in a loop for a fixed number of iterations.
Based on these test results, as shown below, the observations are:
1. Non-cascading timers, as introduced by commit 500462a9de65, is working as expected, since all the timers expired well within ring 0.
2. However, the minimum delay doubled, causing the average delay to increase by ~30%.
CONFIG_HZ = 250:
For 1000 iterations, each of 1 msecs
=====================================
Kernel/Timer | msleep | usleep_range |
4.7 | Min: 4.89, Avg: 8 | Min: 1.12 Avg: 1.58 | 4.10 | Min: 11.9, Avg: 11.19 | Min: 1.31 Avg: 1.36 |
For 3000 iterations, each of 1 msecs.
=====================================
Kernel/Timer | msleep | usleep_range |
4.7 | Min: 6.55, Avg: 8.02 | Min: 1.05 Avg: 1.53 | 4.10 | Min: 11.8, Avg: 12.04 | Min: 1.02 Avg: 1.35 |
Thomas, can the minimum delay be improved ?
Thanks & Regards,
- Nayna
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 38 lines · Mimi Zohar
Commit
500462a9de65"timers: Switch to a non-cascading wheel" replaced the 'classic' timer wheel, which aimed for near 'exact' expiry of the timers. Their analysis was that the vast majority of timeout timers are used as safeguards, not as real timers, and are cancelled or rearmed before expiration. The only exception noted to this were networking timers with a small expiry time.Not included in the analysis was the TPM polling timer, which resulted in a longer normal delay and, every so often, a very long delay. The non-cascading wheel delay is based on
CONFIG_HZ. For a description of the different rings and their delays, refer to the comments inkernel/time/timer.c.Below are the delays given for rings 0 - 2, which explains the longer "normal" delays and the very, long delays as seen on systems with
CONFIG_HZ250.* HZ 1000 steps
* Level Offset Granularity Range* 0 0 1 ms 0 ms - 63 ms * 1 64 8 ms 64 ms - 511 ms * 2 128 64 ms 512 ms - 4095 ms (512ms - ~4s)* HZ 250
* Level Offset Granularity Range* 0 0 4 ms 0 ms - 255 ms * 1 64 32 ms 256 ms - 2047 ms (256ms - ~2s) * 2 128 256 ms 2048 ms - 16383 ms (~2s - ~16s)Below is a comparison of extending the TPM with 1000 measurements, using
msleep()vs.usleep_delay()when configured for 1000 hz vs. 250 hz, before and after commit500462a9de65.linux-4.7 | msleep() usleep_range()1000 hz: 0m44.628s | 1m34.497s 29.243s
250 hz: 1m28.510s | 4m49.269s 32.386slinux-4.7 | min-max (msleep) min-max (
usleep_range)
Quoted 8 lines
1000 hz: 0:017 - 2:760s | 0:015 - 3:967s 0:014 - 0:418s 250 hz: 0:028 - 1:954s | 0:040 - 4:096s 0:016 - 0:816sThis patch replaces the
msleep()withusleep_range()calls in the i2c nuvoton driver with a consistent max range value.Signed-of-by Mimi Zohar <[email protected]>Reviewed-by Nayna Jain <[email protected]>
So why doesn't it go to level 0 with msleep()? I quickly skimmed through __mod_timer() and for me it looked like that level 0 would be calculated (when it is eventually called starting from msleep()). What did I miss?
/Jarkko
Quoted 69 lines
--- drivers/char/tpm/tpm_i2c_nuvoton.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)drivers/char/tpm/tpm_i2c_nuvoton.c +10
-8@@ -49,9 +49,9 @@*/ #define TPM_I2C_MAX_BUF_SIZE 32#define TPM_I2C_RETRY_COUNT 32 -#define TPM_I2C_BUS_DELAY 1/* msec */ -#define TPM_I2C_RETRY_DELAY_SHORT 2/* msec */ -#define TPM_I2C_RETRY_DELAY_LONG 10/* msec */ +#define TPM_I2C_BUS_DELAY 1000/* usec */ +#define TPM_I2C_RETRY_DELAY_SHORT 2 * 1000/* usec */ +#define TPM_I2C_RETRY_DELAY_LONG 10 * 1000/* usec */ #define OF_IS_TPM2 ((void *)1)#define I2C_IS_TPM2 1@@ -123,7 +123,7 @@ static s32 i2c_nuvoton_write_status(struct i2c_client *client, u8 data)/* this causes the current command to be aborted */ for (i =0 , status =-1 ; i <TPM_I2C_RETRY_COUNT && status <0 ; i++) { status =i2c_nuvoton_write_buf (client,TPM_STS ,1 , &data); -msleep (TPM_I2C_BUS_DELAY ); +usleep_range (TPM_I2C_BUS_DELAY ,TPM_I2C_BUS_DELAY +300 ); }return status; }@@ -160,7 +160,7 @@ static int i2c_nuvoton_get_burstcount(struct i2c_client *client, burst_count =min_t (u8,TPM_I2C_MAX_BUF_SIZE , data);break ; } -msleep (TPM_I2C_BUS_DELAY ); +usleep_range (TPM_I2C_BUS_DELAY ,TPM_I2C_BUS_DELAY +300 ); }while (time_before (jiffies, stop));return burst_count;@@ -203,13 +203,15 @@ static int i2c_nuvoton_wait_for_stat(struct tpm_chip *chip, u8 mask, u8 value,return 0 ;/* use polling to wait for the event */ - ten_msec = jiffies +msecs_to_jiffies (TPM_I2C_RETRY_DELAY_LONG ); + ten_msec = jiffies +usecs_to_jiffies (TPM_I2C_RETRY_DELAY_LONG ); stop = jiffies + timeout; do { if (time_before(jiffies, ten_msec)) - msleep(TPM_I2C_RETRY_DELAY_SHORT); + usleep_range(TPM_I2C_RETRY_DELAY_SHORT, + TPM_I2C_RETRY_DELAY_SHORT + 300); else - msleep(TPM_I2C_RETRY_DELAY_LONG); + usleep_range(TPM_I2C_RETRY_DELAY_LONG, + TPM_I2C_RETRY_DELAY_LONG + 300); status_valid = i2c_nuvoton_check_status(chip, mask, value); if (status_valid)Signature · 10 lines
2.9.3 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Quoted 45 lines · Jarkko Sakkinen
Quoted 44 lines · Mimi Zohar
Commit
500462a9de65"timers: Switch to a non-cascading wheel" replaced the 'classic' timer wheel, which aimed for near 'exact' expiry of the timers. Their analysis was that the vast majority of timeout timers are used as safeguards, not as real timers, and are cancelled or rearmed before expiration. The only exception noted to this were networking timers with a small expiry time.Not included in the analysis was the TPM polling timer, which resulted in a longer normal delay and, every so often, a very long delay. The non-cascading wheel delay is based on
CONFIG_HZ. For a description of the different rings and their delays, refer to the comments inkernel/time/timer.c.Below are the delays given for rings 0 - 2, which explains the longer "normal" delays and the very, long delays as seen on systems with
CONFIG_HZ250.* HZ 1000 steps
* Level Offset Granularity Range* 0 0 1 ms 0 ms - 63 ms * 1 64 8 ms 64 ms - 511 ms * 2 128 64 ms 512 ms - 4095 ms (512ms - ~4s)* HZ 250
* Level Offset Granularity Range* 0 0 4 ms 0 ms - 255 ms * 1 64 32 ms 256 ms - 2047 ms (256ms - ~2s) * 2 128 256 ms 2048 ms - 16383 ms (~2s - ~16s)Below is a comparison of extending the TPM with 1000 measurements, using
msleep()vs.usleep_delay()when configured for 1000 hz vs. 250 hz, before and after commit500462a9de65.linux-4.7 | msleep() usleep_range()1000 hz: 0m44.628s | 1m34.497s 29.243s
250 hz: 1m28.510s | 4m49.269s 32.386slinux-4.7 | min-max (msleep) min-max (
usleep_range)1000 hz: 0:017 - 2:760s | 0:015 - 3:967s 0:014 - 0:418s 250 hz: 0:028 - 1:954s | 0:040 - 4:096s 0:016 - 0:816sThis patch replaces the
msleep()withusleep_range()calls in the i2c nuvoton driver with a consistent max range value.
Quoted 7 lines
Quoted 2 lines
Signed-of-by Mimi Zohar <[email protected]>Reviewed-by Nayna Jain <[email protected]>So why doesn't it go to level 0 with
msleep()? I quickly skimmed through__mod_timer()and for me it looked like that level 0 would be calculated (when it is eventually called starting frommsleep()). What did I miss?
I've just added some printk's in kernel/time/timer.c. It looks like it is level 0. The delay seems to be caused by schedule() in schedule_timeout().
setup_timer_on_stack(&timer, process_timeout, (unsigned
long)current);
__mod_timer(&timer, expire, false, false);
schedule(); <===
del_singleshot_timer_sync(&timer);
/* Remove the timer from the object tracker */
destroy_timer_on_stack(&timer);printks output:
124.901002] calc_wheel_index: level 0 timer: c000003fab32b150 expires 4294923520 new expires 4294923520 now 4294923518
[ 124.901003] __mod_timer: exit timer c000003fab32b1a0 now 4294923518
< call to schedule() >
[ 128.607463] schedule_timeout: before destroy timer: c000003fab32b150
expires 4294923520 now 4294924439 <=== notice that the "now" time is
way beyond the expires time.
Mimi
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
Jarkko Sakkinen
Reviewed-byQuoted 73 lines · Mimi Zohar
Quoted 45 lines · Jarkko Sakkinen
Quoted 44 lines · Mimi Zohar
Commit
500462a9de65"timers: Switch to a non-cascading wheel" replaced the 'classic' timer wheel, which aimed for near 'exact' expiry of the timers. Their analysis was that the vast majority of timeout timers are used as safeguards, not as real timers, and are cancelled or rearmed before expiration. The only exception noted to this were networking timers with a small expiry time.Not included in the analysis was the TPM polling timer, which resulted in a longer normal delay and, every so often, a very long delay. The non-cascading wheel delay is based on
CONFIG_HZ. For a description of the different rings and their delays, refer to the comments inkernel/time/timer.c.Below are the delays given for rings 0 - 2, which explains the longer "normal" delays and the very, long delays as seen on systems with
CONFIG_HZ250.* HZ 1000 steps
* Level Offset Granularity Range* 0 0 1 ms 0 ms - 63 ms * 1 64 8 ms 64 ms - 511 ms * 2 128 64 ms 512 ms - 4095 ms (512ms - ~4s)* HZ 250
* Level Offset Granularity Range* 0 0 4 ms 0 ms - 255 ms * 1 64 32 ms 256 ms - 2047 ms (256ms - ~2s) * 2 128 256 ms 2048 ms - 16383 ms (~2s - ~16s)Below is a comparison of extending the TPM with 1000 measurements, using
msleep()vs.usleep_delay()when configured for 1000 hz vs. 250 hz, before and after commit500462a9de65.linux-4.7 | msleep() usleep_range()1000 hz: 0m44.628s | 1m34.497s 29.243s
250 hz: 1m28.510s | 4m49.269s 32.386slinux-4.7 | min-max (msleep) min-max (
usleep_range)1000 hz: 0:017 - 2:760s | 0:015 - 3:967s 0:014 - 0:418s 250 hz: 0:028 - 1:954s | 0:040 - 4:096s 0:016 - 0:816sThis patch replaces the
msleep()withusleep_range()calls in the i2c nuvoton driver with a consistent max range value.Quoted 7 lines
Quoted 2 lines
Signed-of-by Mimi Zohar <[email protected]>Reviewed-by Nayna Jain <[email protected]>So why doesn't it go to level 0 with
msleep()? I quickly skimmed through__mod_timer()and for me it looked like that level 0 would be calculated (when it is eventually called starting frommsleep()). What did I miss?I've just added some printk's in
kernel/time/timer.c. It looks like it is level 0. The delay seems to be caused byschedule()inschedule_timeout().setup_timer_on_stack(&timer,
process_timeout, (unsignedlong)current); __mod_timer(&timer, expire, false, false); schedule(); <=== del_singleshot_timer_sync(&timer); /* Remove the timer from the object tracker */ destroy_timer_on_stack(&timer);printks output:
124.901002]calc_wheel_index: level 0 timer:c000003fab32b150expires 4294923520 new expires 4294923520 now 4294923518[ 124.901003] __mod_timer: exit timer c000003fab32b1a0 now 4294923518
Quoted 7 lines
< call to
schedule()>[ 128.607463] schedule_timeout: before destroy timer: c000003fab32b150expires 4294923520 now 4294924439 <=== notice that the "now" time is
way beyond the expires time.Mimi
Hey, I totally forgot this patch! Sorry.
/Jarkko
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
Quoted 80 lines · Jarkko Sakkinen
Quoted 79 lines · Mimi Zohar
Quoted 45 lines · Jarkko Sakkinen
Quoted 44 lines · Mimi Zohar
Commit
500462a9de65"timers: Switch to a non-cascading wheel" replaced the 'classic' timer wheel, which aimed for near 'exact' expiry of the timers. Their analysis was that the vast majority of timeout timers are used as safeguards, not as real timers, and are cancelled or rearmed before expiration. The only exception noted to this were networking timers with a small expiry time.Not included in the analysis was the TPM polling timer, which resulted in a longer normal delay and, every so often, a very long delay. The non-cascading wheel delay is based on
CONFIG_HZ. For a description of the different rings and their delays, refer to the comments inkernel/time/timer.c.Below are the delays given for rings 0 - 2, which explains the longer "normal" delays and the very, long delays as seen on systems with
CONFIG_HZ250.* HZ 1000 steps
* Level Offset Granularity Range* 0 0 1 ms 0 ms - 63 ms * 1 64 8 ms 64 ms - 511 ms * 2 128 64 ms 512 ms - 4095 ms (512ms - ~4s)* HZ 250
* Level Offset Granularity Range* 0 0 4 ms 0 ms - 255 ms * 1 64 32 ms 256 ms - 2047 ms (256ms - ~2s) * 2 128 256 ms 2048 ms - 16383 ms (~2s - ~16s)Below is a comparison of extending the TPM with 1000 measurements, using
msleep()vs.usleep_delay()when configured for 1000 hz vs. 250 hz, before and after commit500462a9de65.linux-4.7 | msleep() usleep_range()1000 hz: 0m44.628s | 1m34.497s 29.243s
250 hz: 1m28.510s | 4m49.269s 32.386slinux-4.7 | min-max (msleep) min-max (
usleep_range)1000 hz: 0:017 - 2:760s | 0:015 - 3:967s 0:014 - 0:418s 250 hz: 0:028 - 1:954s | 0:040 - 4:096s 0:016 - 0:816sThis patch replaces the
msleep()withusleep_range()calls in the i2c nuvoton driver with a consistent max range value.Quoted 7 lines
Quoted 2 lines
Signed-of-by Mimi Zohar <[email protected]>Reviewed-by Nayna Jain <[email protected]>So why doesn't it go to level 0 with
msleep()? I quickly skimmed through__mod_timer()and for me it looked like that level 0 would be calculated (when it is eventually called starting frommsleep()). What did I miss?I've just added some printk's in
kernel/time/timer.c. It looks like it is level 0. The delay seems to be caused byschedule()inschedule_timeout().setup_timer_on_stack(&timer,
process_timeout, (unsignedlong)current); __mod_timer(&timer, expire, false, false); schedule(); <=== del_singleshot_timer_sync(&timer); /* Remove the timer from the object tracker */ destroy_timer_on_stack(&timer);printks output:
124.901002]calc_wheel_index: level 0 timer:c000003fab32b150expires 4294923520 new expires 4294923520 now 4294923518[ 124.901003] __mod_timer: exit timer c000003fab32b1a0 now 4294923518< call to
schedule()>[ 128.607463] schedule_timeout: before destroy timer: c000003fab32b150expires 4294923520 now 4294924439 <=== notice that the "now" time is
way beyond the expires time.
Quoted 5 lines
Quoted 1 line
Mimi
Hey, I totally forgot this patch! Sorry.
Thanks, Jarkko! From looking at the code and adding some printks, the
TPM extends should have been in level 0. We were left wondering whymsleep() was performing so poorly. Unfortunately, we haven't gotten
very far. Initially we thought it might be in "is_idle", but can't even confirm that. Sprinkling "printks" isn't very useful as it changes the timing. Even adding "1" like in the change below improved the
performance a lot as shown in the table below. Thomas, any
suggestions?
Even with this improvement, it doesn't come near to that of using usleep_range(). I'm not sure what all this means for the rest of the msleep()s, but at this point, I do appreciate your upstreaming this patch. I hard coded the usleep_range to 300. Any suggestions on what the max usleep_range() should be?
4.10.1 | 4.10.1+ with "+ 1" change
---------------------------------------------------------------
real 3m33.510s 1m29.628s
user 0m1.273s 0m1.296s
sys 0m7.518s 0m5.363s
kernel/time/timer.c +3 -2
@@ -1504,7 +1504,7 @@ static u64 cmp_next_hrtimer_event(u64 basem, u64 expires)u64 get_next_timer_interrupt (unsigned long basej,u64 basem) {struct timer_base *base =this_cpu_ptr (&timer_bases[BASE_STD ]); -u64 expires =KTIME_MAX ; +u64 expire_time, expires =KTIME_MAX ;unsigned long nextevt;bool is_max_delta;
@@ -1545,7 +1545,8 @@ u64 get_next_timer_interrupt(unsigned long basej, u64 basem) }spin_unlock (&base->lock); -return cmp_next_hrtimer_event (basem, expires); + expire_time =cmp_next_hrtimer_event (basem, expires); +return (is_max_delta) ? expire_time : expire_time +1 ; }
Mimi
------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned dictionary content that is easy and intuitive to access. Sign up for an account today to start using our lexical data to power your apps and projects. Get started today and enter our developer competition.
http://sdm.link/oxford
Quoted 87 lines · Mimi Zohar
Quoted 80 lines · Jarkko Sakkinen
Quoted 79 lines · Mimi Zohar
Quoted 45 lines · Jarkko Sakkinen
Quoted 44 lines · Mimi Zohar
Commit
500462a9de65"timers: Switch to a non-cascading wheel" replaced the 'classic' timer wheel, which aimed for near 'exact' expiry of the timers. Their analysis was that the vast majority of timeout timers are used as safeguards, not as real timers, and are cancelled or rearmed before expiration. The only exception noted to this were networking timers with a small expiry time.Not included in the analysis was the TPM polling timer, which resulted in a longer normal delay and, every so often, a very long delay. The non-cascading wheel delay is based on
CONFIG_HZ. For a description of the different rings and their delays, refer to the comments inkernel/time/timer.c.Below are the delays given for rings 0 - 2, which explains the longer "normal" delays and the very, long delays as seen on systems with
CONFIG_HZ250.* HZ 1000 steps
* Level Offset Granularity Range* 0 0 1 ms 0 ms - 63 ms * 1 64 8 ms 64 ms - 511 ms * 2 128 64 ms 512 ms - 4095 ms (512ms - ~4s)* HZ 250
* Level Offset Granularity Range* 0 0 4 ms 0 ms - 255 ms * 1 64 32 ms 256 ms - 2047 ms (256ms - ~2s) * 2 128 256 ms 2048 ms - 16383 ms (~2s - ~16s)Below is a comparison of extending the TPM with 1000 measurements, using
msleep()vs.usleep_delay()when configured for 1000 hz vs. 250 hz, before and after commit500462a9de65.linux-4.7 | msleep() usleep_range()1000 hz: 0m44.628s | 1m34.497s 29.243s
250 hz: 1m28.510s | 4m49.269s 32.386slinux-4.7 | min-max (msleep) min-max (
usleep_range)1000 hz: 0:017 - 2:760s | 0:015 - 3:967s 0:014 - 0:418s 250 hz: 0:028 - 1:954s | 0:040 - 4:096s 0:016 - 0:816sThis patch replaces the
msleep()withusleep_range()calls in the i2c nuvoton driver with a consistent max range value.Quoted 7 lines
Quoted 2 lines
Signed-of-by Mimi Zohar <[email protected]>Reviewed-by Nayna Jain <[email protected]>So why doesn't it go to level 0 with
msleep()? I quickly skimmed through__mod_timer()and for me it looked like that level 0 would be calculated (when it is eventually called starting frommsleep()). What did I miss?I've just added some printk's in
kernel/time/timer.c. It looks like it is level 0. The delay seems to be caused byschedule()inschedule_timeout().setup_timer_on_stack(&timer,
process_timeout, (unsignedlong)current); __mod_timer(&timer, expire, false, false); schedule(); <=== del_singleshot_timer_sync(&timer); /* Remove the timer from the object tracker */ destroy_timer_on_stack(&timer);printks output:
124.901002]calc_wheel_index: level 0 timer:c000003fab32b150expires 4294923520 new expires 4294923520 now 4294923518[ 124.901003] __mod_timer: exit timer c000003fab32b1a0 now 4294923518< call to
schedule()>[ 128.607463] schedule_timeout: before destroy timer: c000003fab32b150expires 4294923520 now 4294924439 <=== notice that the "now" time is
way beyond the expires time.Quoted 5 lines
Quoted 1 line
Mimi
Hey, I totally forgot this patch! Sorry.
Reviewed-by Jarkko Sakkinen <[email protected]>
Quoted 8 lines
Thanks, Jarkko! From looking at the code and adding some printks, the
TPM extends should have been in level 0. We were left wondering whymsleep()was performing so poorly. Unfortunately, we haven't gotten
very far. Initially we thought it might be in "is_idle", but can't even confirm that. Sprinkling "printks" isn't very useful as it changes the timing. Even adding "1" like in the change below improved the
performance a lot as shown in the table below. Thomas, any
suggestions?
The documentation recommends to use usleep_range() for sleeping times that are shorter than 10 ms:
http://lxr.free-electrons.com/source/Documentation/timers/timers-howto.txt
"msleep(1~20) may not do what the caller intends, and will often sleep longer (~20 ms actual sleep for any value given in the 1~20ms range). In many cases this is not the desired behavior."
As for the value for 'max' I would consider it in te following way.
We should probably pick the largest possible value for 'max' that is still sufficient for tpm2_i2c_nuvoton because it is best for the overall system performance. What is in your opinion the largest value we could pick? Maybe 2x min?
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 106 lines · Jarkko Sakkinen
Quoted 87 lines · Mimi Zohar
Quoted 80 lines · Jarkko Sakkinen
Quoted 79 lines · Mimi Zohar
Quoted 45 lines · Jarkko Sakkinen
Quoted 44 lines · Mimi Zohar
Commit
500462a9de65"timers: Switch to a non-cascading wheel" replaced the 'classic' timer wheel, which aimed for near 'exact' expiry of the timers. Their analysis was that the vast majority of timeout timers are used as safeguards, not as real timers, and are cancelled or rearmed before expiration. The only exception noted to this were networking timers with a small expiry time.Not included in the analysis was the TPM polling timer, which resulted in a longer normal delay and, every so often, a very long delay. The non-cascading wheel delay is based on
CONFIG_HZ. For a description of the different rings and their delays, refer to the comments inkernel/time/timer.c.Below are the delays given for rings 0 - 2, which explains the longer "normal" delays and the very, long delays as seen on systems with
CONFIG_HZ250.* HZ 1000 steps
* Level Offset Granularity Range* 0 0 1 ms 0 ms - 63 ms * 1 64 8 ms 64 ms - 511 ms * 2 128 64 ms 512 ms - 4095 ms (512ms - ~4s)* HZ 250
* Level Offset Granularity Range* 0 0 4 ms 0 ms - 255 ms * 1 64 32 ms 256 ms - 2047 ms (256ms - ~2s) * 2 128 256 ms 2048 ms - 16383 ms (~2s - ~16s)Below is a comparison of extending the TPM with 1000 measurements, using
msleep()vs.usleep_delay()when configured for 1000 hz vs. 250 hz, before and after commit500462a9de65.linux-4.7 | msleep() usleep_range()1000 hz: 0m44.628s | 1m34.497s 29.243s
250 hz: 1m28.510s | 4m49.269s 32.386slinux-4.7 | min-max (msleep) min-max (
usleep_range)1000 hz: 0:017 - 2:760s | 0:015 - 3:967s 0:014 - 0:418s 250 hz: 0:028 - 1:954s | 0:040 - 4:096s 0:016 - 0:816sThis patch replaces the
msleep()withusleep_range()calls in the i2c nuvoton driver with a consistent max range value.Quoted 7 lines
Quoted 2 lines
Signed-of-by Mimi Zohar <[email protected]>Reviewed-by Nayna Jain <[email protected]>So why doesn't it go to level 0 with
msleep()? I quickly skimmed through__mod_timer()and for me it looked like that level 0 would be calculated (when it is eventually called starting frommsleep()). What did I miss?I've just added some printk's in
kernel/time/timer.c. It looks like it is level 0. The delay seems to be caused byschedule()inschedule_timeout().setup_timer_on_stack(&timer,
process_timeout, (unsignedlong)current); __mod_timer(&timer, expire, false, false); schedule(); <=== del_singleshot_timer_sync(&timer); /* Remove the timer from the object tracker */ destroy_timer_on_stack(&timer);printks output:
124.901002]calc_wheel_index: level 0 timer:c000003fab32b150expires 4294923520 new expires 4294923520 now 4294923518[ 124.901003] __mod_timer: exit timer c000003fab32b1a0 now 4294923518< call to
schedule()>[ 128.607463] schedule_timeout: before destroy timer: c000003fab32b150expires 4294923520 now 4294924439 <=== notice that the "now" time is
way beyond the expires time.Quoted 5 lines
Quoted 1 line
Mimi
Hey, I totally forgot this patch! Sorry.
Reviewed-by Jarkko Sakkinen <[email protected]>Quoted 8 lines
Thanks, Jarkko! From looking at the code and adding some printks, the
TPM extends should have been in level 0. We were left wondering whymsleep()was performing so poorly. Unfortunately, we haven't gotten
very far. Initially we thought it might be in "is_idle", but can't even confirm that. Sprinkling "printks" isn't very useful as it changes the timing. Even adding "1" like in the change below improved the
performance a lot as shown in the table below. Thomas, any
suggestions?The documentation recommends to use
usleep_range()for sleeping times that are shorter than 10 ms:http://lxr.free-electrons.com/source/Documentation/timers/timers-howto.txt
"msleep(1~20) may not do what the caller intends, and will often sleep longer (~20 ms actual sleep for any value given in the 1~20ms range). In many cases this is not the desired behavior."
Quoted 6 lines
As for the value for 'max' I would consider it in te following way.
We should probably pick the largest possible value for 'max' that is still sufficient for
tpm2_i2c_nuvotonbecause it is best for the overall system performance. What is in your opinion the largest value we could pick? Maybe 2x min?
In polling mode, we're waiting to check for a response from the TPM. This is different than the maximum amount of time to wait for a TPM response.
FYI, Nayna will be posting a cleaned up version of this patch, in addition to another one.
thanks,
Mimi
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html