guile: fix a bashism

PATCH New [email protected] 1 participant 1 message Feb 24, 2017

lore

Share & tools

lore

[email protected]

author

2017-02-24 11:57 UTC #0 lore raw

PATCH 1/1 guile: fix a bashism

From: Ming Liu <[email protected]>

A following flaw was detected by verify-bashisms script:
......
meta/recipes-devtools/guile/guile_2.0.13.bb
possible bashism in guile_cross_config line 94 ($'...' should be "$(printf '...')"):

   echo '#!'`which ${BUILD_SYS}-guile`$' \\\n--no-auto-compile -e main -s\n!#\n(define %guile-build-info '\'\( \
       > ${B}/guile-config.cross

......

Fixed by removing $'...' from echo command, using a printf instead.

Signed-off-by Ming Liu <[email protected]>

---
 meta/recipes-devtools/guile/guile_2.0.13.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

meta/recipes-devtools/guile/guile_2.0.13.bb +1 -1

index c29e752..bb73dcf 100644
@@ -90,7 +90,7 @@ guile_cross_config() {
 	then
 	        # Create guile-config returning target values instead of native values
 	        install -d ${SYSROOT_DESTDIR}${STAGING_BINDIR_CROSS}
-        	echo '#!'`which ${BUILD_SYS}-guile`$' \\\n--no-auto-compile -e main -s\n!#\n(define %guile-build-info '\'\( \
+        	printf '#!%s \\\n--no-auto-compile -e main -s\n!#\n(define %%guile-build-info %s(\n' $(which ${BUILD_SYS}-guile) "'" \
 			> ${B}/guile-config.cross
 	        sed -n -e 's:^[ \t]*{[ \t]*":  (:' \
 			-e 's:",[ \t]*": . ":' \

Signature · 1 line

1.9.1