Skip to contentSkip to conversation

ASoC: kirkwood: Add a blank line after declarations

PATCH In review Anda-Alexandra Dorneanu 2 participants 2 messages Feb 25, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: kirkwood: Add a blank line after declarations

From: andadrn <[email protected]>

This was reported by checkpatch.pl

---
 sound/soc/kirkwood/kirkwood-dma.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/kirkwood/kirkwood-dma.c +2 -0
index dafd22e..0af5d46 100644
@@ -24,6 +24,7 @@
 static struct kirkwood_dma_data *kirkwood_priv(struct snd_pcm_substream *subs)
 {
 	struct snd_soc_pcm_runtime *soc_runtime = subs->private_data;
+
 	return snd_soc_dai_get_drvdata(soc_runtime->cpu_dai);
 }
 
@@ -91,6 +92,7 @@ static irqreturn_t kirkwood_dma_irq(int irq, void *dev_id)
 	/* try to find matching cs for current dma address */
 	for (i = 0; i < dram->num_cs; i++) {
 		const struct mbus_dram_window *cs = dram->cs + i;
+
 		if ((cs->base & 0xffff0000) < (dma & 0xffff0000)) {
 			writel(cs->base & 0xffff0000,
 				base + KIRKWOOD_AUDIO_WIN_BASE_REG(win));
Signature · 1 line
1.9.1
#1 lore raw
Quoted 1 line · Anda-Alexandra Dorneanu

From: andadrn <[email protected]>

Drop the From line. The From line needs to match up with your Signed off by line. But the one generated by your mailer already does that, while the one you added does not.

julia

Quoted 32 lines

This was reported by checkpatch.pl

---
 sound/soc/kirkwood/kirkwood-dma.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/kirkwood/kirkwood-dma.c +2 -1
index dafd22e..0af5d46 100644
@@ -24,6 +24,7 @@
 static struct kirkwood_dma_data *kirkwood_priv(struct snd_pcm_substream *subs)
 {
 	struct snd_soc_pcm_runtime *soc_runtime = subs->private_data;
+
 	return snd_soc_dai_get_drvdata(soc_runtime->cpu_dai);
 }
 
@@ -91,6 +92,7 @@ static irqreturn_t kirkwood_dma_irq(int irq, void *dev_id)
 	/* try to find matching cs for current dma address */
 	for (i = 0; i < dram->num_cs; i++) {
 		const struct mbus_dram_window *cs = dram->cs + i;
+
 		if ((cs->base & 0xffff0000) < (dma & 0xffff0000)) {
 			writel(cs->base & 0xffff0000,
 				base + KIRKWOOD_AUDIO_WIN_BASE_REG(win));
--

1.9.1