netlink_delinearize: remove integer_type_postprocess()
Pablo Neira Ayuso
maintainerPATCH 1/1 netlink_delinearize: remove integer_type_postprocess()
Not required anymore since the set definition now comes with the right byteorder for integer types via NFTA_SET_USERDATA area. So we don't need to look at the lhs anymore. Note that this was a workaround that does not work with named sets, where we cannot assume we have a lhs, since it is valid to have a named set that is not referenced from any rule.
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- src/netlink_delinearize.c | 29 ----------------------------- 1 file changed, 29 deletions(-)
src/netlink_delinearize.c +0 -29
@@ -1277,33 +1277,6 @@ struct stmt *netlink_parse_set_expr(const struct set *set,static void expr_postprocess (struct rule_pp_ctx *ctx,struct expr **exprp); -static void integer_type_postprocess (struct expr *expr) -{ -struct expr *i; - -switch (expr->ops->type) { -case EXPR_VALUE : -if (expr->byteorder ==BYTEORDER_HOST_ENDIAN ) { -uint32_t len =div_round_up (expr->len,BITS_PER_BYTE ); - -mpz_switch_byteorder (expr->value, len); - } -break ; -case EXPR_SET_REF : -list_for_each_entry (i, &expr->set->init->expressions, list) { -expr_set_type (i, expr->dtype, expr->byteorder); -integer_type_postprocess (i); - } -break ; -case EXPR_SET_ELEM : -expr_set_type (expr->key, expr->dtype, expr->byteorder); -integer_type_postprocess (expr->key); -break ; -default : -break ; - } -} -static void payload_match_expand (struct rule_pp_ctx *ctx,struct expr *expr,struct expr *payload)
@@ -1392,8 +1365,6 @@ static void ct_meta_common_postprocess(const struct expr *expr)break ;case OP_LOOKUP :expr_set_type (right, left->dtype, left->byteorder); -if (right->dtype == &integer_type) -integer_type_postprocess (right);break ;default :
Signature · 1 line
2.1.4