xen/arm: warn if dom0_mem is not specified
PATCH v4 1/1 xen/arm: warn if dom0_mem is not specified
The default dom0_mem is 128M which is not sufficient to boot a Ubuntu based Dom0. It is not clear what a better default value could be.
Instead, loudly warn the user when dom0_mem is unspecified and wait 3 secs. Then use 512M.
Update the docs to specify that dom0_mem is required on ARM. (The current xen-command-line document does not actually reflect the current behavior of dom0_mem on ARM correctly.)
---
Changes in v4:
- use warning_add
Changes in v3:
- update docs
--- docs/misc/xen-command-line.markdown | 8 +++++++- xen/arch/arm/domain_build.c | 15 ++++++++++----- 2 files changed, 17 insertions(+), 6 deletions(-)
docs/misc/xen-command-line.markdown +7 -1
@@ -603,7 +603,13 @@ For example, with `dom0_max_vcpus=4-8`: > 8 | 8 > 10 | 8 -### dom0\_mem +### dom0\_mem (ARM) +> `= <size>` + +Set the amount of memory for the initial domain (dom0). It must be +greater than zero. This parameter is required. + +### dom0\_mem (x86) > `= List of ( min:<size> | max:<size> | <size> )` Set the amount of memory for the initial domain (dom0). If a size is
xen/arch/arm/domain_build.c +10 -5
@@ -13,6 +13,7 @@#include <xen/guest_access.h> #include <xen/iocap.h> #include <xen/acpi.h> +#include <xen/warning.h> #include <acpi/actables.h> #include <asm/device.h> #include <asm/setup.h>
@@ -31,14 +32,11 @@ integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);int dom0_11_mapping =1 ; -#define DOM0_MEM_DEFAULT 0x8000000/* 128 MiB */ -static u64 __initdata dom0_mem =DOM0_MEM_DEFAULT ; +static u64 __initdata dom0_mem;static void __init parse_dom0_mem (const char *s) { dom0_mem =parse_size_and_unit (s, &s); -if ( dom0_mem ==0 ) - dom0_mem =DOM0_MEM_DEFAULT ; }custom_param ("dom0_mem" , parse_dom0_mem);
@@ -2125,7 +2123,14 @@ int construct_dom0(struct domain *d)BUG_ON (d->vcpu[0 ] ==NULL );BUG_ON (v->is_initialised); -printk ("*** LOADING DOMAIN 0 ***\n" ); +if ( dom0_mem >0 ) +printk ("*** LOADING DOMAIN 0 ***\n" ); +else + { +warning_add ("PLEASE SPECIFY dom0_mem PARAMETER - USING 512M FOR NOW\n" ); + dom0_mem =MB (512 ); + } +iommu_hwdom_init (d);
Signature · 7 lines
1.9.1 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
Quoted 11 lines · Stefano Stabellini
The default
dom0_memis 128M which is not sufficient to boot a Ubuntu based Dom0. It is not clear what a better default value could be.Instead, loudly warn the user when
dom0_memis unspecified and wait 3 secs. Then use 512M.Update the docs to specify that
dom0_memis required on ARM. (The current xen-command-line document does not actually reflect the current behavior ofdom0_memon ARM correctly.)Signed-off-by Stefano Stabellini <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
Hi Stefano,
Quoted 70 lines · Stefano Stabellini
The default
dom0_memis 128M which is not sufficient to boot a Ubuntu based Dom0. It is not clear what a better default value could be.Instead, loudly warn the user when
dom0_memis unspecified and wait 3 secs. Then use 512M.Update the docs to specify that
dom0_memis required on ARM. (The current xen-command-line document does not actually reflect the current behavior ofdom0_memon ARM correctly.)Signed-off-by Stefano Stabellini <[email protected]>---
Changes in v4:
- usewarning_addChanges in v3:
- update docs--- docs/misc/xen-command-line.markdown | 8 +++++++- xen/arch/arm/domain_build.c | 15 ++++++++++----- 2 files changed, 17 insertions(+), 6 deletions(-)docs/misc/xen-command-line.markdown +7
-1@@ -603,7 +603,13 @@ For example, with `dom0_max_vcpus=4-8`: > 8 | 8 > 10 | 8 -### dom0\_mem +### dom0\_mem (ARM) +> `= <size>` + +Set the amount of memory for the initial domain (dom0). It must be +greater than zero. This parameter is required. + +### dom0\_mem (x86) > `= List of ( min:<size> | max:<size> | <size> )` Set the amount of memory for the initial domain (dom0). If a size isxen/arch/arm/domain_build.c +2
-4@@ -13,6 +13,7 @@#include <xen/guest_access.h> #include <xen/iocap.h> #include <xen/acpi.h> +#include <xen/warning.h> #include <acpi/actables.h> #include <asm/device.h> #include <asm/setup.h> @@ -31,14 +32,11 @@ integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);int dom0_11_mapping =1 ; -#define DOM0_MEM_DEFAULT 0x8000000/* 128 MiB */ -static u64 __initdata dom0_mem =DOM0_MEM_DEFAULT ; +static u64 __initdata dom0_mem;static void __init parse_dom0_mem (const char *s) { dom0_mem =parse_size_and_unit (s, &s); -if ( dom0_mem ==0 ) - dom0_mem =DOM0_MEM_DEFAULT ; }custom_param ("dom0_mem" , parse_dom0_mem);
xen/arch/arm/domain_build.c int construct_dom0(struct domain *d) · line 2127
Quoted 6 lines
xen/arch/arm/domain_build.c +2
-1@@ -2125,7 +2123,14 @@ int construct_dom0(struct domain *d)BUG_ON (d->vcpu[0 ] ==NULL );BUG_ON (v->is_initialised); -printk ("*** LOADING DOMAIN 0 ***\n" ); +if ( dom0_mem >0 ) +printk ("*** LOADING DOMAIN 0 ***\n" );
warning_add will not print the message until Xen has boot so we have no way to know when DOM0 is getting loaded when dom0_mem is not set.
So I would keep this printk in all the case.
With that:
Cheers,
Signature · 6 lines
Julien Grall _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel