media: dt-bindings: extend the vpif bindings
Subsystems (2)
v3 cover media: dt-bindings: extend the vpif bindings
This series adds pdata quirks and other changes required to make vpif work on the da850-evm board.
v1 -> v2:
- added patch 3/3
- specified the purpose of port@0 and port@1 nodes
v2 -> v3:
- removed patch 3/3 - it may take some more time to determine the correct solution for enable-gpios, so I decided to respin the series without it and send it later as a follow-up
- added Rob Herring's acks
Bartosz Golaszewski (2):
media: dt-bindings: vpif: fix whitespace errors
media: dt-bindings: vpif: extend the example with an output port
.../devicetree/bindings/media/ti,da850-vpif.txt | 50 ++++++++++++++++------ 1 file changed, 37 insertions(+), 13 deletions(-)
Signature · 1 line
2.9.3
PATCH v3 1/2 media: dt-bindings: vpif: fix whitespace errors
The examples have been copied from the DT with whitespace errors. Fix them.
--- Documentation/devicetree/bindings/media/ti,da850-vpif.txt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/media/ti,da850-vpif.txt +6 -6
@@ -30,15 +30,15 @@ I2C-connected TVP5147 decoder: port { vpif_ch0: endpoint@0 { - reg = <0>; - bus-width = <8>; - remote-endpoint = <&composite>; + reg = <0>; + bus-width = <8>; + remote-endpoint = <&composite>; }; vpif_ch1: endpoint@1 { - reg = <1>; - bus-width = <8>; - data-shift = <8>; + reg = <1>; + bus-width = <8>; + data-shift = <8>; }; }; };
Signature · 1 line
2.9.3
PATCH v3 2/2 media: dt-bindings: vpif: extend the example with an output port
In reply to Bartosz GolaszewskiThis makes the example more or less correspond with the da850-evm hardware setup.
--- .../devicetree/bindings/media/ti,da850-vpif.txt | 40 +++++++++++++++++----- 1 file changed, 32 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/media/ti,da850-vpif.txt +32 -8
@@ -16,8 +16,10 @@ Required properties: Video Capture: VPIF has a 16-bit parallel bus input, supporting 2 8-bit channels or a -single 16-bit channel. It should contain at least one port child node -with child 'endpoint' node. Please refer to the bindings defined in +single 16-bit channel. It should contain one or two port child nodes +with child 'endpoint' node. If there are two ports then port@0 must +describe the input and port@1 output channels. Please refer to the +bindings defined in Documentation/devicetree/bindings/media/video-interfaces.txt. Example using 2 8-bit input channels, one of which is connected to an
@@ -28,19 +30,26 @@ I2C-connected TVP5147 decoder: reg = <0x217000 0x1000>; interrupts = <92>; - port { - vpif_ch0: endpoint@0 { + port@0 { + vpif_input_ch0: endpoint@0 { reg = <0>; bus-width = <8>; - remote-endpoint = <&composite>; + remote-endpoint = <&composite_in>; }; - vpif_ch1: endpoint@1 { + vpif_input_ch1: endpoint@1 { reg = <1>; bus-width = <8>; data-shift = <8>; }; }; + + port@1 { + vpif_output_ch0: endpoint { + bus-width = <8>; + remote-endpoint = <&composite_out>; + }; + }; }; [ ... ]
@@ -53,13 +62,28 @@ I2C-connected TVP5147 decoder: status = "okay"; port { - composite: endpoint { + composite_in: endpoint { hsync-active = <1>; vsync-active = <1>; pclk-sample = <0>; /* VPIF channel 0 (lower 8-bits) */ - remote-endpoint = <&vpif_ch0>; + remote-endpoint = <&vpif_input_ch0>; + bus-width = <8>; + }; + }; + }; + + adv7343@2a { + compatible = "adi,adv7343"; + reg = <0x2a>; + + port { + composite_out: endpoint { + adi,dac-enable = <1 1 1>; + adi,sd-dac-enable = <1>; + + remote-endpoint = <&vpif_output_ch0>; bus-width = <8>; }; };
Signature · 1 line
2.9.3