Skip to contentSkip to conversation

perf bench numa: Add more comment for -c option

PATCH New Jiri Olsa 2 participants 2 messages Mar 5, 2017 – Mar 7, 2017 perf events

lore
Share & tools
lore

Jiri Olsa

author reviewer
#0 lore raw

PATCH 1/1 perf bench numa: Add more comment for -c option

Adding more commentary for -c/--show_convergence option, to explain how the convergence is defined.

Before:
-c, --show_convergence
show convergence details

Now:

    -c, --show_convergence
                          show convergence details, convergence is reached \

when each process (all its threads) are running on the single NUMA node

Suggested--by Jiri Hladky <[email protected]>
Signed-off-by Jiri Olsa <[email protected]>
Cc David Ahern <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Link http://lkml.kernel.org/n/[email protected] open here
---
 tools/perf/bench/numa.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/bench/numa.c +2 -1
index 3083fc36282b..18b855ae5df6 100644
@@ -187,7 +187,8 @@ static const struct option options[] = {
 	OPT_INCR   ('d', "show_details"	, &p0.show_details,	"Show details"),
 	OPT_INCR   ('a', "all"		, &p0.run_all,		"Run all tests in the suite"),
 	OPT_INTEGER('H', "thp"		, &p0.thp,		"MADV_NOHUGEPAGE < 0 < MADV_HUGEPAGE"),
-	OPT_BOOLEAN('c', "show_convergence", &p0.show_convergence, "show convergence details"),
+	OPT_BOOLEAN('c', "show_convergence", &p0.show_convergence, "show convergence details, "
+		    "convergence is reached when each process (all its threads) are running on the single NUMA node"),
 	OPT_BOOLEAN('m', "measure_convergence",	&p0.measure_convergence, "measure convergence latency"),
 	OPT_BOOLEAN('q', "quiet"	, &p0.show_quiet,	"quiet mode"),
 	OPT_BOOLEAN('S', "serialize-startup", &p0.serialize_startup,"serialize thread startup"),
Signature · 1 line
2.7.4
merge bot
#1 lore raw
perf bench numa: Add more comment for -c option
Commit-ID:  001916b94a04809a94abb07daba6f9ace01906ba
Gitweb:     http://git.kernel.org/tip/001916b94a04809a94abb07daba6f9ace01906ba
Author:     Jiri Olsa <[email protected]>
AuthorDate: Sun, 5 Mar 2017 17:40:11 +0100
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 6 Mar 2017 12:39:30 -0300

perf bench numa: Add more comment for -c option

Adding more commentary for -c/--show_convergence option, to explain how the convergence is defined.

Before:
-c, --show_convergence
show convergence details

Now:

    -c, --show_convergence
                          convergence is reached when each process \
	(all its threads) is running on a single NUMA node.
Suggested--by Jiri Hladky <[email protected]>
Signed-off-by Jiri Olsa <[email protected]>
Cc David Ahern <[email protected]>
Cc Jiri Hladky <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
[ Rephrased a bit based on a IRC conversation with Jiri ]
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/bench/numa.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/bench/numa.c +2 -1
index 3083fc3..6bd0581 100644
@@ -187,7 +187,8 @@ static const struct option options[] = {
 	OPT_INCR   ('d', "show_details"	, &p0.show_details,	"Show details"),
 	OPT_INCR   ('a', "all"		, &p0.run_all,		"Run all tests in the suite"),
 	OPT_INTEGER('H', "thp"		, &p0.thp,		"MADV_NOHUGEPAGE < 0 < MADV_HUGEPAGE"),
-	OPT_BOOLEAN('c', "show_convergence", &p0.show_convergence, "show convergence details"),
+	OPT_BOOLEAN('c', "show_convergence", &p0.show_convergence, "show convergence details, "
+		    "convergence is reached when each process (all its threads) is running on a single NUMA node."),
 	OPT_BOOLEAN('m', "measure_convergence",	&p0.measure_convergence, "measure convergence latency"),
 	OPT_BOOLEAN('q', "quiet"	, &p0.show_quiet,	"quiet mode"),
 	OPT_BOOLEAN('S', "serialize-startup", &p0.serialize_startup,"serialize thread startup"),