Skip to contentSkip to conversation

avr32: Fix build error caused by include file reshuffling

PATCH In review Guenter Roeck 3 participants 3 messages Mar 6, 2017 – Mar 7, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 avr32: Fix build error caused by include file reshuffling

Various avr32 builds fail as follows.

arch/avr32/oprofile/backtrace.c:58: error:
dereferencing pointer to incomplete type
arch/avr32/oprofile/backtrace.c:60: error:
implicit declaration of function 'user_mode'

Fixes f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
Cc Ingo Molnar <[email protected]>

---
Please feel free to ignore if av32 is going to be removed.

 arch/avr32/oprofile/backtrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/avr32/oprofile/backtrace.c +1 -1
index 75d9ad6f99cf..29cf2f191bfd 100644
@@ -14,7 +14,7 @@
  */
 
 #include <linux/oprofile.h>
-#include <linux/sched.h>
+#include <linux/ptrace.h>
 #include <linux/uaccess.h>
 
 /* The first two words of each frame on the stack look like this if we have
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Guenter Roeck

Various avr32 builds fail as follows.

arch/avr32/oprofile/backtrace.c:58: error:
dereferencing pointer to incomplete type
arch/avr32/oprofile/backtrace.c:60: error:
implicit declaration of function 'user_mode'

Fixes f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
Cc Ingo Molnar <[email protected]>
Quoted 2 lines

---
Please feel free to ignore if av32 is going to be removed.

AVR32 is not going away for 4.11, we started the FYI and review process too late to make the window.

I think I will push it, to make sure AVR32 leaves the kernel in as good state as possible.

Quoted 16 lines
 arch/avr32/oprofile/backtrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/avr32/oprofile/backtrace.c +1 -1
index 75d9ad6f99cf..29cf2f191bfd 100644
@@ -14,7 +14,7 @@
  */
 
 #include <linux/oprofile.h>
-#include <linux/sched.h>
+#include <linux/ptrace.h>
 #include <linux/uaccess.h>
 
 /* The first two words of each frame on the stack look like this if we have
Signature · 2 lines
mvh
Hans-Christian Noren Egtvedt
#2 lore raw
In reply to Guenter Roeck
avr32: Fix build error caused by include file reshuffling
Commit-ID:  1fbdbcea80056acfc8c8506594744f5ec52208c1
Gitweb:     http://git.kernel.org/tip/1fbdbcea80056acfc8c8506594744f5ec52208c1
Author:     Guenter Roeck <[email protected]>
AuthorDate: Sun, 5 Mar 2017 17:05:57 -0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 7 Mar 2017 08:35:48 +0100

avr32: Fix build error caused by include file reshuffling

Various avr32 builds fail:

arch/avr32/oprofile/backtrace.c:58: error: dereferencing pointer to incomplete type arch/avr32/oprofile/backtrace.c:60: error: implicit declaration of function 'user_mode'

Cc Haavard Skinnemoen <[email protected]>
Cc Hans-Christian Egtvedt <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Robert Richter <[email protected]>
Cc Thomas Gleixner <[email protected]>
Fixes f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
---
 arch/avr32/oprofile/backtrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/avr32/oprofile/backtrace.c +1 -1
index 75d9ad6..29cf2f1 100644
@@ -14,7 +14,7 @@
  */
 
 #include <linux/oprofile.h>
-#include <linux/sched.h>
+#include <linux/ptrace.h>
 #include <linux/uaccess.h>
 
 /* The first two words of each frame on the stack look like this if we have