Skip to contentSkip to conversation

Revert "kref: double kref_put() in my_data_handler()"

PATCH New Thomas Hellstrom 1 participant 1 message Mar 6, 2017 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "kref: double kref_put() in my_data_handler()"

This reverts commit 8f1ecc9fbc5b223e4f5d5bb8bcd6f5672c4bc4b6.

The correction is incorrect, see discussion at

http://stackoverflow.com/questions/20093127/why-kref-doc-of-linux-kernel-omits-kref-put-when-kthread-run-fail

---
 Documentation/kref.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/kref.txt +1 -0
index ddf85a5..d26a27c 100644
@@ -84,6 +84,7 @@ int my_data_handler(void)
 	task = kthread_run(more_data_handling, data, "more_data_handling");
 	if (task == ERR_PTR(-ENOMEM)) {
 		rv = -ENOMEM;
+	        kref_put(&data->refcount, data_release);
 		goto out;
 	}
 
Signature · 1 line
2.4.11