Skip to contentSkip to conversation

sanity.bbclass: allow s3 protocol when sanity checking MIRRORS, etc

PATCH In review Andre McCurdy 2 participants 3 messages Mar 6, 2017

lore
Share & tools
lore

Andre McCurdy

author
#0 lore raw

PATCH 1/1 sanity.bbclass: allow s3 protocol when sanity checking MIRRORS, etc

Bitbake now supports an Amazon AWS S3 fetcher:

http://git.openembedded.org/bitbake/commit/?id=6fe07ed25457dd7952b60f4b2153d56b15d5eea6

Signed-off-by Andre McCurdy <[email protected]>
---
 meta/classes/sanity.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/sanity.bbclass +1 -1
index 1fe172f..b5f4756 100644
@@ -874,7 +874,7 @@ def check_sanity_everybuild(status, d):
     mirror_vars = ['MIRRORS', 'PREMIRRORS', 'SSTATE_MIRRORS']
     protocols = ['http', 'ftp', 'file', 'https', \
                  'git', 'gitsm', 'hg', 'osc', 'p4', 'svn', \
-                 'bzr', 'cvs', 'npm', 'sftp', 'ssh']
+                 'bzr', 'cvs', 'npm', 'sftp', 'ssh', 's3' ]
     for mirror_var in mirror_vars:
         mirrors = (d.getVar(mirror_var) or '').replace('\\n', ' ').split()
Signature · 1 line
1.9.1
#1 lore raw

meta/classes/sanity.bbclass def check_sanity_everybuild(status, d): · line 877

Quoted 5 lines · Andre McCurdy
     protocols = ['http', 'ftp', 'file', 'https', \
                  'git', 'gitsm', 'hg', 'osc', 'p4', 'svn', \
meta/classes/sanity.bbclass +1 -1
-                 'bzr', 'cvs', 'npm', 'sftp', 'ssh']
+                 'bzr', 'cvs', 'npm', 'sftp', 'ssh', 's3' ]

Maybe bb.fetch2 needs a "list the protocols you support" method?

Ross

author
#2 lore raw
Quoted 10 lines · Ross

meta/classes/sanity.bbclass def check_sanity_everybuild(status, d): · line 877

Quoted 5 lines · Andre McCurdy
     protocols = ['http', 'ftp', 'file', 'https', \
                  'git', 'gitsm', 'hg', 'osc', 'p4', 'svn', \
meta/classes/sanity.bbclass +1 -1
-                 'bzr', 'cvs', 'npm', 'sftp', 'ssh']
+                 'bzr', 'cvs', 'npm', 'sftp', 'ssh', 's3' ]

Maybe bb.fetch2 needs a "list the protocols you support" method?

Yes. Although there should perhaps be a distinction between protocols which can be used for MIRRORS etc and those which can not (I'm not sure if the current list in the sanity.bbclass gets that right?).

Quoted 1 line

Ross