Skip to contentSkip to conversation

Patch "MIPS: Fix is_jump_ins() handling of 16b microMIPS instructions" has been added to the 4.10-stable tree

PATCH [email protected] 1 participant 1 message Mar 8, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

MIPS: Fix is_jump_ins() handling of 16b microMIPS instructions

to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mips-fix-is_jump_ins-handling-of-16b-micromips-instructions.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 67c75057709a6d85c681c78b9b2f9b71191f01a2 Mon Sep 17 00:00:00 2001

From: Paul Burton <[email protected]>
Date: Mon, 7 Nov 2016 15:07:05 +0000
Subject: MIPS: Fix is_jump_ins() handling of 16b microMIPS instructions

From: Paul Burton <[email protected]>

commit 67c75057709a6d85c681c78b9b2f9b71191f01a2 upstream.

is_jump_ins() checks 16b instruction fields without verifying that the instruction is indeed 16b, as is done by is_ra_save_ins() & is_sp_move_ins(). Add the appropriate check.

Fixes 34c2f668d0f6 ("MIPS: microMIPS: Add unaligned access support.")
Cc Leonid Yegoshin <[email protected]>

Patchwork: https://patchwork.linux-mips.org/patch/14531/

---
 arch/mips/kernel/process.c |   11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
arch/mips/kernel/process.c +8 -3
@@ -241,9 +241,14 @@ static inline int is_jump_ins(union mips
 	 *
 	 * microMIPS is kind of more fun...
 	 */
-	if ((ip->mm16_r5_format.opcode == mm_pool16c_op &&
-	    (ip->mm16_r5_format.rt & mm_jr16_op) == mm_jr16_op) ||
-	    ip->j_format.opcode == mm_jal32_op)
+	if (mm_insn_16bit(ip->halfword[1])) {
+		if ((ip->mm16_r5_format.opcode == mm_pool16c_op &&
+		    (ip->mm16_r5_format.rt & mm_jr16_op) == mm_jr16_op))
+			return 1;
+		return 0;
+	}
+
+	if (ip->j_format.opcode == mm_jal32_op)
 		return 1;
 	if (ip->r_format.opcode != mm_pool32a_op ||
 			ip->r_format.func != mm_pool32axf_op)

Patches currently in stable-queue which might be from [email protected] are

queue-4.10/mips-calculate-micromips-ra-properly-when-unwinding-the-stack.patch queue-4.10/mips-fix-get_frame_info-handling-of-micromips-function-size.patch queue-4.10/mips-handle-micromips-jumps-in-the-same-way-as-mips32-mips64-jumps.patch queue-4.10/mips-fix-is_jump_ins-handling-of-16b-micromips-instructions.patch queue-4.10/mips-clear-isa-bit-correctly-in-get_frame_info.patch queue-4.10/mips-prevent-unaligned-accesses-during-stack-unwinding.patch