Skip to contentSkip to conversation

Patch "[media] am437x-vpfe: always assign bpp variable" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Mar 8, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

[media] am437x-vpfe: always assign bpp variable

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
am437x-vpfe-always-assign-bpp-variable.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6ebf75774f823ddbdbd10921006989d4df222f4a Mon Sep 17 00:00:00 2001

From: Nicolas Iooss <[email protected]>
Date: Tue, 27 Dec 2016 16:02:36 -0200
Subject: [media] am437x-vpfe: always assign bpp variable

From: Nicolas Iooss <[email protected]>

commit 6ebf75774f823ddbdbd10921006989d4df222f4a upstream.

In vpfe_s_fmt(), when the sensor format and the requested format were the same, bpp was assigned to vpfe->bpp without being initialized first.

Grab the bpp value that is currently used by using __vpfe_get_format() instead of its wrapper, vpfe_try_fmt().

This use of uninitialized variable has been found by compiling the kernel with clang.

Fixes 417d2e507edc ("[media] media: platform: add VPFE capture driver

support for AM437X")

---
 drivers/media/platform/am437x/am437x-vpfe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/am437x/am437x-vpfe.c +1 -1
@@ -1576,7 +1576,7 @@ static int vpfe_s_fmt(struct file *file,
 		return -EBUSY;
 	}
 
-	ret = vpfe_try_fmt(file, priv, &format);
+	ret = __vpfe_get_format(vpfe, &format, &bpp);
 	if (ret)
 		return ret;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/am437x-vpfe-always-assign-bpp-variable.patch