Skip to contentSkip to conversation

Patch "spi: s3c64xx: fix inconsistency between binding and driver" has been added to the 4.10-stable tree

PATCH [email protected] 1 participant 1 message Mar 8, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

spi: s3c64xx: fix inconsistency between binding and driver

to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
spi-s3c64xx-fix-inconsistency-between-binding-and-driver.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 379f831a927817c130a62e3ca0082ae685557324 Mon Sep 17 00:00:00 2001

From: Andi Shyti <[email protected]>
Date: Fri, 10 Feb 2017 11:20:19 +0900
Subject: spi: s3c64xx: fix inconsistency between binding and driver

From: Andi Shyti <[email protected]>

commit 379f831a927817c130a62e3ca0082ae685557324 upstream.

Commit a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected") introduced an inconsistency between the binding, where the disconnected CS line was marked as 'no-cs-readback', and the driver.

The driver is erroneously checking for that attribute with property name of 'broken-cs'.

Check for 'no-cs-readback' in the driver as well.

Fixes a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected")
---
 drivers/spi/spi-s3c64xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-s3c64xx.c +1 -1
@@ -996,7 +996,7 @@ static struct s3c64xx_spi_info *s3c64xx_
 		sci->num_cs = temp;
 	}
 
-	sci->no_cs = of_property_read_bool(dev->of_node, "broken-cs");
+	sci->no_cs = of_property_read_bool(dev->of_node, "no-cs-readback");
 
 	return sci;
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.10/lirc_dev-lirc_-g-s-et_rec_mode-do-not-work.patch queue-4.10/spi-s3c64xx-fix-inconsistency-between-binding-and-driver.patch