Skip to contentSkip to conversation

FAILED: patch "[PATCH] hwmon: (it87) Ensure that pwm control cache is current before" failed to apply to 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 8, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 82dbe987b70042b340f851bdc969a971081e5f02 Mon Sep 17 00:00:00 2001

From: Guenter Roeck <[email protected]>
Date: Wed, 8 Feb 2017 14:02:59 -0800
Subject: [PATCH] hwmon: (it87) Ensure that pwm control cache is current before
updating values

If sensor attributes were never read, the pwm control data has not been initiialized, which can cause wrong driver behavior. Ensure that cached data is current before acting on it.

drivers/hwmon/it87.c +2 -0
index 11a28b233006..85918d8a747a 100644
@@ -1360,6 +1360,7 @@ static ssize_t set_pwm(struct device *dev, struct device_attribute *attr,
 		return -EINVAL;
 
 	mutex_lock(&data->update_lock);
+	it87_update_pwm_ctrl(data, nr);
 	if (has_newer_autopwm(data)) {
 		/*
 		 * If we are in automatic mode, the PWM duty cycle register
@@ -1472,6 +1473,7 @@ static ssize_t set_pwm_temp_map(struct device *dev,
 	}
 
 	mutex_lock(&data->update_lock);
+	it87_update_pwm_ctrl(data, nr);
 	data->pwm_temp_map[nr] = reg;
 	/*
 	 * If we are in automatic mode, write the temp mapping immediately;