WTF: patch "[PATCH] scsi: aacraid: Skip wellness sync on controller failure" was seriously submitted to be applied to the 4.10-stable tree?

The patch below was submitted to be applied to the 4.10-stable tree.

I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable_kernel_rules.rst.

I could be totally wrong, and if so, please respond to <[email protected]> and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From: Raghava Aditya Renukunta <[email protected]>
Date: Thu, 16 Feb 2017 12:51:17 -0800
Subject: [PATCH] scsi: aacraid: Skip wellness sync on controller failure

aac_command_thread checks on the health of controller periodically, using aac_check_health. If the status is an error state KERNEL_PANIC or anything else. The driver will attempt to restart the adapter, but the response is not checked in aac_command_thread. This allows the periodic sync to go thru and lead the driver to a hung state.

Fixed by terminating the periodic loop(intended per original design), if the controller is not restored to a healthy state.

index c10954b3cd46..eb4d8cfc3194 100644
@@ -2481,7 +2481,7 @@ int aac_command_thread(void *data)
 
 			/* Don't even try to talk to adapter if its sick */
 			ret = aac_check_health(dev);
-			if (!dev->queues)
+			if (ret || !dev->queues)
 				break;
 			next_check_jiffies = jiffies
 					   + ((long)(unsigned)check_interval)