Patch "scsi: aacraid: Reorder Adapter status check" has been added to the 4.10-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
scsi: aacraid: Reorder Adapter status check
to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
scsi-aacraid-reorder-adapter-status-check.patch
and it can be found in the queue-4.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
c421530bf848604e97d0785a03b3fe2c62775083Mon Sep 17 00:00:00 2001
From: Raghava Aditya Renukunta <[email protected]>
Date: Thu, 16 Feb 2017 12:51:21 -0800
Subject: scsi: aacraid: Reorder Adapter status check
From: Raghava Aditya Renukunta <[email protected]>
commit c421530bf848604e97d0785a03b3fe2c62775083 upstream.
The driver currently checks the SELF_TEST_FAILED first and then KERNEL_PANIC next. Under error conditions(boot code failure) both SELF_TEST_FAILED and KERNEL_PANIC can be set at the same time.
The driver has the capability to reset the controller on an KERNEL_PANIC, but not on SELF_TEST_FAILED.
Fixed by first checking KERNEL_PANIC and then the others.
--- drivers/scsi/aacraid/src.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)
drivers/scsi/aacraid/src.c +17 -4
@@ -414,16 +414,23 @@ static int aac_src_check_health(struct au32 status =src_readl (dev, MUnit.OMR);/* +* Check to see if the board panic'd. +*/ +if (unlikely (status &KERNEL_PANIC )) + goto err_blink; + +/* * Check to see if the board failed any self tests. */ if (unlikely (status &SELF_TEST_FAILED )) -return -1 ; + goto err_out;/* -* Check to see if the board panic'd. +* Check to see if the board failed any self tests. */ -if (unlikely (status &KERNEL_PANIC )) -return (status >>16 ) &0xFF ; +if (unlikely (status &MONITOR_PANIC )) + goto err_out; +/* * Wait for the adapter to be up and running. */
@@ -433,6 +440,12 @@ static int aac_src_check_health(struct a* Everything is OK */ return 0 ; + +err_out: +return -1 ; + +err_blink: +return (status >16 ) &0xFF ; }/**
Patches currently in stable-queue which might be from [email protected] are
queue-4.10/scsi-aacraid-reorder-adapter-status-check.patch