patch "USB: serial: io_ti: fix NULL-deref in interrupt callback" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: serial: io_ti: fix NULL-deref in interrupt callback
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
0b1d250afb8eb9d65afb568bac9b9f9253a82b49Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Mon, 6 Mar 2017 17:36:37 +0100
Subject: USB: serial: io_ti: fix NULL-deref in interrupt callback
Fix a NULL-pointer dereference in the interrupt callback should a malicious device send data containing a bad port number by adding the missing sanity check.
--- drivers/usb/serial/io_ti.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/usb/serial/io_ti.c +6 -0
@@ -1674,6 +1674,12 @@ static void edge_interrupt_callback(struct urb *urb) function =TIUMP_GET_FUNC_FROM_CODE (data[0 ]);dev_dbg (dev,"%s - port_number %d, function %d, info 0x%x\n" , __func__, port_number, function, data[1 ]); + +if (port_number >= edge_serial->serial->num_ports) { +dev_err (dev,"bad port number %d\n" , port_number); + goto exit; + } + port = edge_serial->serial->port[port_number]; edge_port =usb_get_serial_port_data (port);if (!edge_port) {
Signature · 1 line
2.12.0