patch "USB: serial: omninet: fix reference leaks at open" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: serial: omninet: fix reference leaks at open
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
30572418b445d85fcfe6c8fe84c947d2606767d8Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Mon, 6 Mar 2017 17:36:38 +0100
Subject: USB: serial: omninet: fix reference leaks at open
This driver needlessly took another reference to the tty on open, a reference which was then never released on close. This lead to not just a leak of the tty, but also a driver reference leak that prevented the driver from being unloaded after a port had once been opened.
--- drivers/usb/serial/omninet.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/usb/serial/omninet.c +0 -6
@@ -142,12 +142,6 @@ static int omninet_port_remove(struct usb_serial_port *port)static int omninet_open (struct tty_struct *tty,struct usb_serial_port *port) { -struct usb_serial *serial = port->serial; -struct usb_serial_port *wport; - - wport = serial->port[1 ]; -tty_port_tty_set (&wport->port, tty); -return usb_serial_generic_open (tty, port); }
Signature · 1 line
2.12.0