Skip to contentSkip to conversation

72042a8c7b01 x86/purgatory: Make functions and variables static

regression Mike Galbraith 4 participants 7 messages Mar 9, 2017

lore
Share & tools
lore
#0 lore raw

Greetings,

I bisected kdump breakage to $subject, and verified the identified culprit via revert. Seems kexec needs those variables as they were.

-Mike

#1 lore raw
Quoted 4 lines · Mike Galbraith

Greetings,

I bisected kdump breakage to $subject, and verified the identified culprit via revert. Seems kexec needs those variables as they were.

Yuck. That does not make any sense at all. I'll try to figure out why.

Thanks,

tglx

#2 lore raw
Quoted 8 lines · Thomas Gleixner
Quoted 4 lines · Mike Galbraith

Greetings,

I bisected kdump breakage to $subject, and verified the identified culprit via revert. Seems kexec needs those variables as they were.

Yuck. That does not make any sense at all. I'll try to figure out why.

Dunno, but I did find this.

git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",

#3 lore raw
Quoted 8 lines · Mike Galbraith
Quoted 7 lines · Thomas Gleixner
Quoted 4 lines · Mike Galbraith

Greetings,

I bisected kdump breakage to $subject, and verified the identified culprit via revert. Seems kexec needs those variables as they were.

Quoted 8 lines
Quoted 1 line

Yuck. That does not make any sense at all. I'll try to figure out why.

Dunno, but I did find this.

git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",

Came so far as well. Lovely undocumented dependencies.....

#4 lore raw
Quoted 11 lines · Thomas Gleixner
Quoted 10 lines · Mike Galbraith
Quoted 8 lines · Thomas Gleixner
Quoted 4 lines · Mike Galbraith

Greetings,

I bisected kdump breakage to $subject, and verified the identified culprit via revert. Seems kexec needs those variables as they were.

Yuck. That does not make any sense at all. I'll try to figure out why.

Quoted 8 lines
Quoted 6 lines

Dunno, but I did find this.

git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",

Came so far as well. Lovely undocumented dependencies.....

I'm out of my depth on this one. If there is some task I can do to save you time or effort, point me at it.

thanks,
Tobin.

#5 lore raw
In reply to Thomas Gleixner
Quoted 6 lines · Thomas Gleixner
Quoted 4 lines

git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",

Came so far as well. Lovely undocumented dependencies.....

Maybe that'll help a little:

https://lkml.kernel.org/r/[email protected]

And yap, that thing needs a bunch of text ontop saying sh*t and why it is magical.

Signature · 4 lines
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.
#6 lore raw
Quoted 6 lines · Borislav Petkov
Quoted 5 lines · Thomas Gleixner
Quoted 4 lines

git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_start",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_src_size",
./kexec/arch/x86_64/kexec-x86_64.c: elf_rel_set_symbol(&info->rhdr, "backup_start",

Quoted 8 lines
Quoted 1 line

Came so far as well. Lovely undocumented dependencies.....

Maybe that'll help a little:

https://lkml.kernel.org/r/[email protected]

And yap, that thing needs a bunch of text ontop saying sh*t and why it is magical.

I know how to fix it, but I'll do that tomorrow with brain awake