Skip to contentSkip to conversation

Patch "NFSv4: fix getacl head length estimation" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 10, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

NFSv4: fix getacl head length estimation

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
nfsv4-fix-getacl-head-length-estimation.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6682c14bbe505a8b912c57faf544f866777ee48d Mon Sep 17 00:00:00 2001

From: "J. Bruce Fields" <[email protected]>
Date: Thu, 23 Feb 2017 14:53:39 -0500
Subject: NFSv4: fix getacl head length estimation

From: J. Bruce Fields <[email protected]>

commit 6682c14bbe505a8b912c57faf544f866777ee48d upstream.

Bitmap and attrlen follow immediately after the op reply header. This was an oversight from commit bf118a342f.

Consequences of this are just minor efficiency (extra calls to xdr_shrink_bufhead).

Fixes bf118a342f10 "NFSv4: include bitmap in nfsv4 get acl data"
---
 fs/nfs/nfs4xdr.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/nfs4xdr.c +1 -1
@@ -2487,7 +2487,7 @@ static void nfs4_xdr_enc_getacl(struct r
 	encode_compound_hdr(xdr, req, &hdr);
 	encode_sequence(xdr, &args->seq_args, &hdr);
 	encode_putfh(xdr, args->fh, &hdr);
-	replen = hdr.replen + op_decode_hdr_maxsz + 1;
+	replen = hdr.replen + op_decode_hdr_maxsz;
 	encode_getattr_two(xdr, FATTR4_WORD0_ACL, 0, &hdr);
 
 	xdr_inline_pages(&req->rq_rcv_buf, replen << 2,

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/nfsd-minor-nfsd_setattr-cleanup.patch queue-4.4/nfsv4-fix-getacl-head-length-estimation.patch queue-4.4/nfsv4-fix-getacl-erange-for-some-acl-buffer-sizes.patch queue-4.4/nfsd-special-case-truncates-some-more.patch