i40e/i40evf updates
Subsystems (2)
cover i40e/i40evf updates
Alexander Duyck adds code to clean up handling of private flags.
Christopher Bednarz adds code to check for new arq elements before leaving the adminq subtask loop.
Jacob Keller removes a useless goto statement & removes FDIR_REQUIRES_REINIT driver flag.
Paul M Stillwell adds code to use register for XL722 control register read/write.
Preethi Banala adds code to enforce descriptor write-back mechanism for VF.
drivers/net/ethernet/intel/i40e/i40e.h | 9 - drivers/net/ethernet/intel/i40e/i40e_common.c | 8 +- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 189 ++++++++++++--------- drivers/net/ethernet/intel/i40e/i40e_main.c | 10 +- drivers/net/ethernet/intel/i40evf/i40e_common.c | 8 +- drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 64 +------ drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 14 -- .../net/ethernet/intel/i40evf/i40evf_virtchnl.c | 4 - 8 files changed, 135 insertions(+), 171 deletions(-)
Signature · 1 line
2.4.11
PATCH 1/6 i40evf: enforce descriptor write-back mechanism for VF
From: Preethi Banala <[email protected]>
The current driver mode is to use a write-back mechanism for the head register which indicates transmit completions. The VF driver needs to be able to work on hardware that exclusively uses descriptor write-back, so change the default driver mode of operation to descriptor write-back for VF. In our analysis, performance wasn't significantly different with either write-back method.
Testing Hints:
1) load PF driver in host
2) create two VMs and load VF driver in both
3) create SRIOV VFs in host and direct attach one VF to each VM
4) Assign ip address in the same subnet for both VFs.
5) Use iperf to send TCP/UDP traffic.
--- drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 64 +++------------------- drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 14 ----- .../net/ethernet/intel/i40evf/i40evf_virtchnl.c | 4 -- 3 files changed, 7 insertions(+), 75 deletions(-)
drivers/net/ethernet/intel/i40evf/i40e_txrx.c +7 -57
@@ -137,10 +137,7 @@ u32 i40evf_get_tx_pending(struct i40e_ring *ring, bool in_sw) {u32 head, tail; -if (!in_sw) - head =i40e_get_head (ring); -else - head = ring->next_to_clean; + head = ring->next_to_clean; tail =readl (ring->tail);if (head != tail)
@@ -165,7 +162,6 @@ static bool i40e_clean_tx_irq(struct i40e_vsi *vsi, {u16 i = tx_ring->next_to_clean;struct i40e_tx_buffer *tx_buf; -struct i40e_tx_desc *tx_head;struct i40e_tx_desc *tx_desc;unsigned int total_bytes =0 , total_packets =0 ;unsigned int budget = vsi->work_limit;
@@ -174,8 +170,6 @@ static bool i40e_clean_tx_irq(struct i40e_vsi *vsi, tx_desc =I40E_TX_DESC (tx_ring, i); i -= tx_ring->count; - tx_head =I40E_TX_DESC (tx_ring,i40e_get_head (tx_ring)); - do { struct i40e_tx_desc *eop_desc = tx_buf->next_to_watch;
@@ -186,8 +180,9 @@ static bool i40e_clean_tx_irq(struct i40e_vsi *vsi,/* prevent any other reads prior to eop_desc */ read_barrier_depends (); -/* we have caught up to head, no work left to do */ -if (tx_head == tx_desc) +/* if the descriptor isn't done, no work yet to do */ +if (!(eop_desc->cmd_type_offset_bsz & +cpu_to_le64 (I40E_TX_DESC_DTYPE_DESC_DONE )))break ;/* clear next_to_watch to prevent false hangs */
@@ -464,10 +459,6 @@ int i40evf_setup_tx_descriptors(struct i40e_ring *tx_ring)/* round up to nearest 4K */ tx_ring->size = tx_ring->count *sizeof (struct i40e_tx_desc ); -/* add u32 for head writeback, align after this takes care of -* guaranteeing this is at least one cache line in size -*/ - tx_ring->size +=sizeof (u32); tx_ring->size =ALIGN (tx_ring->size,4096 ); tx_ring->desc =dma_alloc_coherent (dev, tx_ring->size, &tx_ring->dma,GFP_KERNEL );
@@ -2012,7 +2003,6 @@ static inline void i40evf_tx_map(struct i40e_ring *tx_ring, struct sk_buff *skb,u16 i = tx_ring->next_to_use;u32 td_tag =0 ;dma_addr_t dma; -u16 desc_count =1 ;if (tx_flags &I40E_TX_FLAGS_HW_VLAN ) { td_cmd |=I40E_TX_DESC_CMD_IL2TAG1 ;
@@ -2048,7 +2038,6 @@ static inline void i40evf_tx_map(struct i40e_ring *tx_ring, struct sk_buff *skb, tx_desc++; i++; - desc_count++;if (i == tx_ring->count) { tx_desc =I40E_TX_DESC (tx_ring,0 );
@@ -2070,7 +2059,6 @@ static inline void i40evf_tx_map(struct i40e_ring *tx_ring, struct sk_buff *skb, tx_desc++; i++; - desc_count++;if (i == tx_ring->count) { tx_desc =I40E_TX_DESC (tx_ring,0 );
@@ -2096,46 +2084,8 @@ static inline void i40evf_tx_map(struct i40e_ring *tx_ring, struct sk_buff *skb,i40e_maybe_stop_tx (tx_ring,DESC_NEEDED ); -/* write last descriptor with EOP bit */ - td_cmd |=I40E_TX_DESC_CMD_EOP ; - -/* We can OR these values together as they both are checked against -* 4 below and at this point desc_count will be used as a boolean value -* after this if/else block. -*/ - desc_count |= ++tx_ring->packet_stride; - -/* Algorithm to optimize tail and RS bit setting: -* if queue is stopped -* mark RS bit -* reset packet counter -* else if xmit_more is supported and is true -* advance packet counter to 4 -* reset desc_count to 0 -* -* if desc_count >= 4 -* mark RS bit -* reset packet counter -* if desc_count > 0 -* update tail -* -* Note: If there are less than 4 descriptors -* pending and interrupts were disabled the service task will -* trigger a force WB. -*/ -if (netif_xmit_stopped (txring_txq (tx_ring))) { - goto do_rs; - }else if (skb->xmit_more) { -/* set stride to arm on next packet and reset desc_count */ - tx_ring->packet_stride =WB_STRIDE ; - desc_count =0 ; - }else if (desc_count >=WB_STRIDE ) { -do_rs: -/* write last descriptor with RS bit set */ - td_cmd |=I40E_TX_DESC_CMD_RS ; - tx_ring->packet_stride =0 ; - } - +/* write last descriptor with RS and EOP bits */ + td_cmd |=I40E_TXD_CMD ; tx_desc->cmd_type_offset_bsz =build_ctob (td_cmd, td_offset, size, td_tag);
@@ -2151,7 +2101,7 @@ static inline void i40evf_tx_map(struct i40e_ring *tx_ring, struct sk_buff *skb, first->next_to_watch = tx_desc;/* notify HW of packet */ -if (desc_count) { +if (netif_xmit_stopped (txring_txq (tx_ring)) || !skb->xmit_more) {writel (i, tx_ring->tail);/* we need this if more than one processor can write to our tail
drivers/net/ethernet/intel/i40evf/i40e_txrx.h +0 -14
@@ -393,20 +393,6 @@ int __i40evf_maybe_stop_tx(struct i40e_ring *tx_ring, int size);bool __i40evf_chk_linearize (struct sk_buff *skb);/** -* i40e_get_head - Retrieve head from head writeback -* @tx_ring: Tx ring to fetch head of -* -* Returns value of Tx ring head based on value stored -* in head write-back location -**/ -static inline u32 i40e_get_head (struct i40e_ring *tx_ring) -{ -void *head = (struct i40e_tx_desc *)tx_ring->desc + tx_ring->count; - -return le32_to_cpu (*(volatile __le32 *)head); -} - -/** * i40e_xmit_descriptor_count - calculate number of Tx descriptors needed * @skb: send buffer * @tx_ring: ring to send buffer on
drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +0 -4
@@ -260,10 +260,6 @@ void i40evf_configure_queues(struct i40evf_adapter *adapter) vqpi->txq.queue_id = i; vqpi->txq.ring_len = adapter->tx_rings[i].count; vqpi->txq.dma_ring_addr = adapter->tx_rings[i].dma; - vqpi->txq.headwb_enabled =1 ; - vqpi->txq.dma_headwb_addr = vqpi->txq.dma_ring_addr + - (vqpi->txq.ring_len *sizeof (struct i40e_tx_desc )); - vqpi->rxq.vsi_id = vqci->vsi_id; vqpi->rxq.queue_id = i; vqpi->rxq.ring_len = adapter->rx_rings[i].count;
Signature · 1 line
2.4.11
Bowers
PATCH 1/6 i40evf: enforce descriptor write-back mechanism for VF
Quoted 24 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Bimmy Pujari
Sent: Friday, March 10, 2017 12:22 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH S62 1/6] i40evf: enforce descriptor write-back mechanism for VFFrom: Preethi Banala <[email protected]>
The current driver mode is to use a write-back mechanism for the head register which indicates transmit completions. The VF driver needs to be able to work on hardware that exclusively uses descriptor write-back, so change the default driver mode of operation to descriptor write-back for VF. In our analysis, performance wasn't significantly different with either write-back method.
Testing Hints:
1) load PF driver in host
2) create two VMs and load VF driver in both
3) create SRIOV VFs in host and direct attach one VF to each VM
4) Assign ip address in the same subnet for both VFs.
5) Use iperf to send TCP/UDP traffic.
Quoted 7 lines
Signed-off-by Preethi Banala <[email protected]>Change-ID Ia92e4ec77c2df8dc4515c71d53746d57d77759af--- drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 64 +++------------------- drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 14 ----- .../net/ethernet/intel/i40evf/i40evf_virtchnl.c | 4 -- 3 files changed, 7 insertions(+), 75 deletions(-)
PATCH 2/6 i40e: Clean up handling of private flags
In reply to Bimmy PujariFrom: Alexander Duyck <[email protected]>
This patch cleans up and addresses several issues in the way that i40e handles private flags. Previously the code was choosing fixed bits and trying to match them up with strings in a somewhat haphazard way. This resulted in the possibility for adding a new bit and causing a mismatch as the private flags are linear bits starting at 0, and the private flags in the driver were split up over a group specific to the PF and a group that was global.
What this change does is define an array of structs used to represent the private flags. Contained within the structs are the bits necessary to know which flags to set and/or clear depending on the state of the bit. By doing this we can add new bits in the future with minimal overhead and avoid creating possible mis-matches should we need to remove a flag based on compile options.
--- drivers/net/ethernet/intel/i40e/i40e.h | 8 -- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 189 +++++++++++++++---------- 2 files changed, 112 insertions(+), 85 deletions(-)
drivers/net/ethernet/intel/i40e/i40e.h +0 -8
@@ -91,14 +91,6 @@#define I40E_QUEUE_WAIT_RETRY_LIMIT 10#define I40E_INT_NAME_STR_LEN (IFNAMSIZ + 16) -/* Ethtool Private Flags */ -#define I40E_PRIV_FLAGS_MFP_FLAG BIT(0) -#define I40E_PRIV_FLAGS_LINKPOLL_FLAG BIT(1) -#define I40E_PRIV_FLAGS_FD_ATR BIT(2) -#define I40E_PRIV_FLAGS_VEB_STATS BIT(3) -#define I40E_PRIV_FLAGS_HW_ATR_EVICT BIT(4) -#define I40E_PRIV_FLAGS_TRUE_PROMISC_SUPPORT BIT(5) -#define I40E_NVM_VERSION_LO_SHIFT 0#define I40E_NVM_VERSION_LO_MASK (0xff << I40E_NVM_VERSION_LO_SHIFT)#define I40E_NVM_VERSION_HI_SHIFT 12
drivers/net/ethernet/intel/i40e/i40e_ethtool.c +112 -77
240 lines not on this page · raw message
Signature · 1 line
2.4.11
Bowers
PATCH 2/6 i40e: Clean up handling of private flags
Quoted 24 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Bimmy Pujari
Sent: Friday, March 10, 2017 12:22 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH S62 2/6] i40e: Clean up handling of private flagsFrom: Alexander Duyck <[email protected]>
This patch cleans up and addresses several issues in the way that i40e handles private flags. Previously the code was choosing fixed bits and trying to match them up with strings in a somewhat haphazard way. This resulted in the possibility for adding a new bit and causing a mismatch as the private flags are linear bits starting at 0, and the private flags in the driver were split up over a group specific to the PF and a group that was global.
What this change does is define an array of structs used to represent the private flags. Contained within the structs are the bits necessary to know which flags to set and/or clear depending on the state of the bit. By doing this we can add new bits in the future with minimal overhead and avoid creating possible mis-matches should we need to remove a flag based on compile options.
Quoted 7 lines
Signed-off-by Alexander Duyck <[email protected]>Change-ID Ia3214ab04f0ab2f70354ac0997a135f1d01b0acd--- drivers/net/ethernet/intel/i40e/i40e.h | 8 -- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 189 +++++++++++++++---- ------ 2 files changed, 112 insertions(+), 85 deletions(-)
PATCH 3/6 i40e: use register for XL722 control register read/write
In reply to Bimmy PujariFrom: Paul M Stillwell Jr <[email protected]>
The XL722 doesn't support the AQ command to read/write the control register so enable it to bypass the check and use the direct read/write method.
--- drivers/net/ethernet/intel/i40e/i40e_common.c | 8 ++++++-- drivers/net/ethernet/intel/i40evf/i40e_common.c | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_common.c +6 -2
@@ -4963,7 +4963,9 @@ u32 i40e_read_rx_ctl(struct i40e_hw *hw, u32 reg_addr)int retry =5 ;u32 val =0 ; - use_register = (hw->aq.api_maj_ver ==1 ) && (hw->aq.api_min_ver <5 ); + use_register = (((hw->aq.api_maj_ver ==1 ) && + (hw->aq.api_min_ver <5 )) || + (hw->mac.type ==I40E_MAC_X722 ));if (!use_register) { do_retry: status =i40e_aq_rx_ctl_read_register (hw, reg_addr, &val,NULL );
@@ -5022,7 +5024,9 @@ void i40e_write_rx_ctl(struct i40e_hw *hw, u32 reg_addr, u32 reg_val)bool use_register;int retry =5 ; - use_register = (hw->aq.api_maj_ver ==1 ) && (hw->aq.api_min_ver <5 ); + use_register = (((hw->aq.api_maj_ver ==1 ) && + (hw->aq.api_min_ver <5 )) || + (hw->mac.type ==I40E_MAC_X722 ));if (!use_register) { do_retry: status = i40e_aq_rx_ctl_write_register(hw, reg_addr,
drivers/net/ethernet/intel/i40evf/i40e_common.c +6 -2
@@ -958,7 +958,9 @@ u32 i40evf_read_rx_ctl(struct i40e_hw *hw, u32 reg_addr)int retry =5 ;u32 val =0 ; - use_register = (hw->aq.api_maj_ver ==1 ) && (hw->aq.api_min_ver <5 ); + use_register = (((hw->aq.api_maj_ver ==1 ) && + (hw->aq.api_min_ver <5 )) || + (hw->mac.type ==I40E_MAC_X722 ));if (!use_register) { do_retry: status = i40evf_aq_rx_ctl_read_register(hw, reg_addr,
@@ -1019,7 +1021,9 @@ void i40evf_write_rx_ctl(struct i40e_hw *hw, u32 reg_addr, u32 reg_val)bool use_register;int retry =5 ; - use_register = (hw->aq.api_maj_ver ==1 ) && (hw->aq.api_min_ver <5 ); + use_register = (((hw->aq.api_maj_ver ==1 ) && + (hw->aq.api_min_ver <5 )) || + (hw->mac.type ==I40E_MAC_X722 ));if (!use_register) { do_retry: status = i40evf_aq_rx_ctl_write_register(hw, reg_addr,
Signature · 1 line
2.4.11
Bowers
PATCH 3/6 i40e: use register for XL722 control register read/write
Quoted 15 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Bimmy Pujari
Sent: Friday, March 10, 2017 12:22 PM
To: intel-wired-lan at lists.osuosl.org
Cc: Stillwell Jr, Paul M <[email protected]>
Subject: [Intel-wired-lan] [next PATCH S62 3/6] i40e: use register for XL722 control register read/writeFrom: Paul M Stillwell Jr <[email protected]>
The XL722 doesn't support the AQ command to read/write the control register so enable it to bypass the check and use the direct read/write method.
Quoted 6 lines
Signed-off-by Paul M Stillwell Jr <[email protected]>Change-ID Iefecc737b57207485c90845af5989d5af518bf16--- drivers/net/ethernet/intel/i40e/i40e_common.c | 8 ++++++-- drivers/net/ethernet/intel/i40evf/i40e_common.c | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-)
PATCH 4/6 i40e: Check for new arq elements before leaving the adminq subtask loop
In reply to Bimmy PujariFrom: "Christopher Bednarz" <[email protected]>
Fix a case where we miss an arq element if a new one is added before we enable interrupts and exit the arq subtask loop. This occurs frequently with Rdma running on Windows VF and causes long delays that prevent SMB from establishing connections.
--- drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +4 -2
@@ -6524,9 +6524,11 @@ static void i40e_clean_adminq_subtask(struct i40e_pf *pf) opcode);break ; } - }while (pending && (i++ < pf->adminq_work_limit)); + }while (i++ < pf->adminq_work_limit); + +if (i < pf->adminq_work_limit) +clear_bit (__I40E_ADMINQ_EVENT_PENDING, &pf->state); -clear_bit (__I40E_ADMINQ_EVENT_PENDING, &pf->state);/* re-enable Admin queue interrupt cause */ val =rd32 (hw,I40E_PFINT_ICR0_ENA ); val |=I40E_PFINT_ICR0_ENA_ADMINQ_MASK ;
Signature · 1 line
2.4.11
Bowers
PATCH 4/6 i40e: Check for new arq elements before leaving the adminq subtask loop
Quoted 16 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Bimmy Pujari
Sent: Friday, March 10, 2017 12:22 PM
To: intel-wired-lan at lists.osuosl.org
Cc: Bednarz, Christopher N <[email protected]>
Subject: [Intel-wired-lan] [next PATCH S62 4/6] i40e: Check for new arq elements before leaving the adminq subtask loopFrom: "Christopher Bednarz" <[email protected]>
Fix a case where we miss an arq element if a new one is added before we enable interrupts and exit the arq subtask loop. This occurs frequently with Rdma running on Windows VF and causes long delays that prevent SMB from establishing connections.
Quoted 5 lines
Signed-off-by Christopher N Bednarz <[email protected]>Change-ID I3e1c8b2b960c12857d9b8275bea2c1563674392e--- drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
PATCH 5/6 i40e: remove a useless goto statement
In reply to Bimmy PujariFrom: Jacob Keller <[email protected]>
The goto found here for when in MFP mode is pointless. It jumps to the end of a series of if blocks. However, right after this statement is a closing '}' for this if block, which will result in the program flow going to the exact same location as the goto statement indicates. Thus, regardless of whether we are in MFP mode, the program flow will resume from the same location.
This arose due to various refactoring which did not notice that this goto became essentially a no-op.
To properly understand this diff you will need to view a larger context than is given by default.
--- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +0 -4
@@ -5175,10 +5175,6 @@ static int i40e_init_pf_dcb(struct i40e_pf *pf) (hw->dcbx_status == I40E_DCBX_STATUS_DISABLED)) { dev_info(&pf->pdev->dev, "DCBX offload is not supported or is disabled for this PF.\n"); - - if (pf->flags & I40E_FLAG_MFP_ENABLED) - goto out; - } else {/* When status is not DISABLED then DCBX in FW */ pf->dcbx_cap = DCB_CAP_DCBX_LLD_MANAGED |
Signature · 1 line
2.4.11
Bowers
PATCH 5/6 i40e: remove a useless goto statement
Quoted 19 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Bimmy Pujari
Sent: Friday, March 10, 2017 12:22 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH S62 5/6] i40e: remove a useless goto statementFrom: Jacob Keller <[email protected]>
The goto found here for when in MFP mode is pointless. It jumps to the end of a series of if blocks. However, right after this statement is a closing '}' for this if block, which will result in the program flow going to the exact same location as the goto statement indicates. Thus, regardless of whether we are in MFP mode, the program flow will resume from the same location.
This arose due to various refactoring which did not notice that this goto became essentially a no-op.
Quoted 8 lines
To properly understand this diff you will need to view a larger context than is given by default.
Signed-off-by Jacob Keller <[email protected]>Change-ID I088f73c3831aa5c4e2281380c7a3ce605594300c--- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ---- 1 file changed, 4 deletions(-)
PATCH 6/6 i40e: remove FDIR_REQUIRES_REINIT driver flag
In reply to Bimmy PujariFrom: Jacob Keller <[email protected]>
This flag hasn't been used since commit 1e1be8f622ee ("i40e: ATR policy change to flush the table to clean stale ATR rules").
Lets simplify things and just remove it.
--- drivers/net/ethernet/intel/i40e/i40e.h | 1 - 1 file changed, 1 deletion(-)
drivers/net/ethernet/intel/i40e/i40e.h +0 -1
@@ -389,7 +389,6 @@ struct i40e_pf {#define I40E_FLAG_MSIX_ENABLED BIT_ULL(3)#define I40E_FLAG_RSS_ENABLED BIT_ULL(6)#define I40E_FLAG_VMDQ_ENABLED BIT_ULL(7) -#define I40E_FLAG_FDIR_REQUIRES_REINIT BIT_ULL(8)#define I40E_FLAG_NEED_LINK_UPDATE BIT_ULL(9)#define I40E_FLAG_IWARP_ENABLED BIT_ULL(10)#define I40E_FLAG_CLEAN_ADMINQ BIT_ULL(14)
Signature · 1 line
2.4.11
Bowers
PATCH 6/6 i40e: remove FDIR_REQUIRES_REINIT driver flag
Quoted 13 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Bimmy Pujari
Sent: Friday, March 10, 2017 12:22 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH S62 6/6] i40e: removeFDIR_REQUIRES_REINITdriver flagFrom: Jacob Keller <[email protected]>
This flag hasn't been used since commit
1e1be8f622ee("i40e: ATR policy change to flush the table to clean stale ATR rules").
Quoted 7 lines
Lets simplify things and just remove it.
Signed-off-by Jacob Keller <[email protected]>Change-ID I76279d84db8a2fd96f445b96aa413059f9256879--- drivers/net/ethernet/intel/i40e/i40e.h | 1 - 1 file changed, 1 deletion(-)