Patch "drm/vmwgfx: Work around drm removal of control nodes" has been added to the 4.9-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
drm/vmwgfx: Work around drm removal of control nodes
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-vmwgfx-work-around-drm-removal-of-control-nodes.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
31788ca803a0c89078f9e604e64286fbd9077926Mon Sep 17 00:00:00 2001
From: Thomas Hellstrom <[email protected]>
Date: Tue, 21 Feb 2017 17:42:27 +0700
Subject: drm/vmwgfx: Work around drm removal of control nodes
From: Thomas Hellstrom <[email protected]>
commit 31788ca803a0c89078f9e604e64286fbd9077926 upstream.
vmware tools has a daemon that gets layout information from the GUI and forwards it to DRM so that the modesetting code can set preferred connector locations and modes. This daemon was using control nodes but since control nodes were just removed, make it possible for the daemon to use render- or primary nodes instead. This is a bit ugly but will allow drm to proceed with removal of the mostly unused control-node code and allow vmware to proceed with fixing up automatic layout settings for gnome-shell/wayland.
We bump minor to inform user-space about the api change.
--- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 11 ++++++++++- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 4 ++-- 2 files changed, 12 insertions(+), 3 deletions(-)
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +10 -1
@@ -199,9 +199,14 @@ static const struct drm_ioctl_desc vmw_iVMW_IOCTL_DEF (VMW_PRESENT_READBACK , vmw_present_readback_ioctl,DRM_MASTER |DRM_AUTH ), +/* +* The permissions of the below ioctl are overridden in +* vmw_generic_ioctl(). We require either +* DRM_MASTER or capable(CAP_SYS_ADMIN). +*/ VMW_IOCTL_DEF (VMW_UPDATE_LAYOUT , vmw_kms_update_layout_ioctl, -DRM_MASTER |DRM_CONTROL_ALLOW ), +DRM_RENDER_ALLOW ),VMW_IOCTL_DEF (VMW_CREATE_SHADER , vmw_shader_define_ioctl, DRM_AUTH | DRM_RENDER_ALLOW),
@@ -1125,6 +1130,10 @@ static long vmw_generic_ioctl(struct filreturn (long )vmw_execbuf_ioctl (dev, arg, file_priv,_IOC_SIZE (cmd)); + }else if (nr ==DRM_COMMAND_BASE +DRM_VMW_UPDATE_LAYOUT ) { +if (!drm_is_current_master (file_priv) && + !capable (CAP_SYS_ADMIN )) +return -EACCES ; }if (unlikely (ioctl->cmd != cmd))
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h +2 -2
@@ -41,9 +41,9 @@#include <drm/ttm/ttm_module.h> #include "vmwgfx_fence.h" -#define VMWGFX_DRIVER_DATE "20160210" +#define VMWGFX_DRIVER_DATE "20170221"#define VMWGFX_DRIVER_MAJOR 2 -#define VMWGFX_DRIVER_MINOR 11 +#define VMWGFX_DRIVER_MINOR 12#define VMWGFX_DRIVER_PATCHLEVEL 0#define VMWGFX_FILE_PAGE_OFFSET 0x00100000#define VMWGFX_FIFO_STATIC_SIZE (1024*1024)
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/drm-ttm-make-sure-bos-being-swapped-out-are-cacheable.patch queue-4.9/drm-vmwgfx-work-around-drm-removal-of-control-nodes.patch