Patch "libceph: use BUG() instead of BUG_ON(1)" has been added to the 4.9-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
libceph: use BUG() instead of BUG_ON(1)
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
libceph-use-bug-instead-of-bug_on-1.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
d24cdcd3e40a6825135498e11c20c7976b9bf545Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <[email protected]>
Date: Mon, 16 Jan 2017 12:06:09 +0100
Subject: libceph: use BUG() instead of BUG_ON(1)
From: Arnd Bergmann <[email protected]>
commit d24cdcd3e40a6825135498e11c20c7976b9bf545 upstream.
I ran into this compile warning, which is the result of BUG_ON(1) not always leading to the compiler treating the code path as unreachable:
include/linux/ceph/osdmap.h: In function 'ceph_can_shift_osds':
include/linux/ceph/osdmap.h:62:1: error: control reaches end of non-void function [-Werror=return-type]
Using BUG() here avoids the warning.
--- include/linux/ceph/osdmap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/ceph/osdmap.h +1 -1
@@ -57,7 +57,7 @@ static inline bool ceph_can_shift_osds(scase CEPH_POOL_TYPE_EC :return false;default : -BUG_ON (1 ); +BUG (); } }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/libceph-use-bug-instead-of-bug_on-1.patch