tpm: Add sysfs interface to show TPM hardware version
PATCH 1/1 tpm: Add sysfs interface to show TPM hardware version
From: Limeng <[email protected]>
So far, there is not a sysfs interface for user space code to check the TPM hardware version(TPM1.x or TPM2). So, add a file named description in /sys/class/tpm/tpmX/ to show it.
--- drivers/char/tpm/tpm-chip.c | 85 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 85 insertions(+)
drivers/char/tpm/tpm-chip.c +85 -0
@@ -36,6 +36,83 @@dev_t tpm_devt;/** +* show_description - sysfs interface for checking current TPM hardware version. +* @dev: pointer to tpm chip device +* @attr: unused +* @buf: char buffer to be filled with TPM hardware version info +* +* Provides sysfs interface for showing current TPM hardware version. +*/ +static ssize_t show_description (struct device *dev, +struct device_attribute *attr,char *buf) +{ + struct tpm_chip *chip = (struct tpm_chip *)container_of(dev,struct tpm_chip,dev); +int ret; + +if (chip->flags &TPM_CHIP_FLAG_TPM2 ) + ret =sprintf (buf,"TPM 2.0" ); +else + ret =sprintf (buf,"TPM 1.x" ); + +return ret; +} + +/** +* store_description - interface for manually setting data. +* @dev: unused +* @attr: unused +* @buf: unused +* @count: unused +* +* There is not any process in this function, reserve for feature. +*/ +static ssize_t store_description (struct device *dev,struct device_attribute *attr, +const char *buf,size_t count) +{ +return count; +} + +static struct device_attribute tpm_attrs[] = { +__ATTR (description,S_IRUGO |S_IWUSR , show_description, store_description), +}; + +/** +* tpm_create_sysfs - Create tpm sysfs interface. +* @dev: pointer to tpm chip device +* +* Create sysfs interface for checking current TPM hardware version. +*/ +static int tpm_create_sysfs (struct device *dev) +{ +int r, t; + +for (t =0 ; t <ARRAY_SIZE (tpm_attrs); t++) { + r =device_create_file (dev, &tpm_attrs[t]); +if (r) { +dev_err (dev,"failed to create sysfs file\n" ); +return r; + } + } + +return 0 ; +} + +/** +* tpm_remove_sysfs - Remove tpm sysfs interface. +* @dev: pointer to tpm chip device +* +* Remove sysfs interface for checking current TPM hardware version. +*/ +static void tpm_remove_sysfs (struct device *dev) +{ +int t; + +for (t =0 ; t <ARRAY_SIZE (tpm_attrs); t++) { +device_remove_file (dev, &tpm_attrs[t]); + } +} + +/** * tpm_try_get_ops() - Get a ref to the tpm_chip * @chip: Chip to ref *
@@ -363,6 +440,13 @@ int tpm_chip_register(struct tpm_chip *chip)return rc; } + rc =tpm_create_sysfs (&chip->dev); +if (rc) { +tpm_del_legacy_sysfs (chip); +tpm_chip_unregister (chip); +return rc; + } +return 0 ; }EXPORT_SYMBOL_GPL (tpm_chip_register);
@@ -382,6 +466,7 @@ int tpm_chip_register(struct tpm_chip *chip)*/ void tpm_chip_unregister (struct tpm_chip *chip) { +tpm_remove_sysfs (&chip->dev);tpm_del_legacy_sysfs (chip);tpm_bios_log_teardown (chip);tpm_del_char_device (chip);
Signature · 1 line
1.7.9.5
Peter Huewe
maintainerHi,
Thanks for your patch.
Am 13. März 2017 06:21:57 MEZ schrieb [email protected]:
Quoted 5 lines
From: Limeng <[email protected]>
So far, there is not a sysfs interface for user space code to check the TPM hardware version(TPM1.x or TPM2). So, add a file named description in
/sys/class/tpm/tpmX/to show it.
It's not really the hardware version but the "TPM Family" according to tcg.
And yes you are right there is currently no way, except for trial and error, for the userspace to determine this. So an interface to get this information makes sense to me.
Quoted 49 lines
Signed-off-by Meng Li <[email protected]>---
drivers/char/tpm/tpm-chip.c| 85
+++++++++++++++++++++++++++++++++++++++++++1 file changed, 85 insertions(+)drivers/char/tpm/tpm-chip.c +1
-0@@ -36,6 +36,83 @@dev_t tpm_devt;/** +* show_description - sysfs interface for checking current TPM hardware version.
+ * @dev: pointer to tpm chip device
+ * @attr: unused
+ * @buf: char buffer to be filled with TPM hardware version info
+ *
+ * Provides sysfs interface for showing current TPM hardware version.
+ */drivers/char/tpm/tpm-chip.c +4
-0+static ssize_t show_description (struct device *dev, +struct device_attribute *attr,char *buf) +{ + struct tpm_chip *chip = (struct tpm_chip *)container_of(dev,structtpm_chip,dev);
drivers/char/tpm/tpm-chip.c +20
-0+int ret; + +if (chip->flags &TPM_CHIP_FLAG_TPM2 ) + ret =sprintf (buf,"TPM 2.0" ); +else + ret =sprintf (buf,"TPM 1.x" ); + +return ret; +} + +/** +* store_description - interface for manually setting data. +* @dev: unused +* @attr: unused +* @buf: unused +* @count: unused +* +* There is not any process in this function, reserve for feature. +*/ +static ssize_t store_description(struct device *dev, struct
device_attribute*attr,
drivers/char/tpm/tpm-chip.c line 73
Quoted 4 lines
drivers/char/tpm/tpm-chip.c +4
-0+ const char *buf, size_t count) +{ +return count; +}
Since it does not do anything
I would not create this function and leave the sysfs node as S_IRUGO.
Quoted 68 lines
drivers/char/tpm/tpm-chip.c +3
-0+ +static struct device_attribute tpm_attrs[] = { + __ATTR(description, S_IRUGO | S_IWUSR, show_description,
store_description),drivers/char/tpm/tpm-chip.c +47
-0+}; + +/** +* tpm_create_sysfs - Create tpm sysfs interface. +* @dev: pointer to tpm chip device +* +* Create sysfs interface for checking current TPM hardware version. +*/ +static int tpm_create_sysfs (struct device *dev) +{ +int r, t; + +for (t =0 ; t <ARRAY_SIZE (tpm_attrs); t++) { + r =device_create_file (dev, &tpm_attrs[t]); +if (r) { +dev_err (dev,"failed to create sysfs file\n" ); +return r; + } + } + +return 0 ; +} + +/** +* tpm_remove_sysfs - Remove tpm sysfs interface. +* @dev: pointer to tpm chip device +* +* Remove sysfs interface for checking current TPM hardware version. +*/ +static void tpm_remove_sysfs (struct device *dev) +{ +int t; + +for (t =0 ; t <ARRAY_SIZE (tpm_attrs); t++) { +device_remove_file (dev, &tpm_attrs[t]); + } +} + +/** * tpm_try_get_ops() - Get a ref to the tpm_chip * @chip: Chip to ref * @@ -363,6 +440,13 @@ int tpm_chip_register(struct tpm_chip *chip)return rc; } + rc =tpm_create_sysfs (&chip->dev); +if (rc) { +tpm_del_legacy_sysfs (chip); +tpm_chip_unregister (chip); +return rc; + } +return 0 ; }EXPORT_SYMBOL_GPL (tpm_chip_register);@@ -382,6 +466,7 @@ int tpm_chip_register(struct tpm_chip *chip)*/ void tpm_chip_unregister (struct tpm_chip *chip) { +tpm_remove_sysfs (&chip->dev);tpm_del_legacy_sysfs (chip);tpm_bios_log_teardown (chip);tpm_del_char_device (chip);
Signature · 12 lines
Sent from my mobile ------------------------------------------------------------------------------ Announcing the Oxford Dictionaries API! The API offers world-renowned dictionary content that is easy and intuitive to access. Sign up for an account today to start using our lexical data to power your apps and projects. Get started today and enter our developer competition. http://sdm.link/oxford _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Quoted 11 lines
-----Original Message-----
From: Peter Huewe [mailto:[email protected]]
Sent: Monday, March 13, 2017 3:11 PM
To: Li, Meng; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] tpm: Add sysfs interface to show TPM hardware version
Quoted 2 lines
Hi,
Thanks for your patch.
Hi Peter,
Thanks for reviewing this patch in your busy time.
I will do modification according to your comment and then send the next patch reviewing.
Thanks,
Limeng
Quoted 135 lines
Am 13. März 2017 06:21:57 MEZ schrieb [email protected]:
Quoted 5 lines
From: Limeng <[email protected]>
So far, there is not a sysfs interface for user space code to check the TPM hardware version(TPM1.x or TPM2). So, add a file named description in
/sys/class/tpm/tpmX/to show it.It's not really the hardware version but the "TPM Family" according to tcg.
And yes you are right there is currently no way, except for trial and error, for the userspace to determine this.
So an interface to get this information makes sense to me.Quoted 48 lines
Signed-off-by Meng Li <[email protected]>---
drivers/char/tpm/tpm-chip.c| 85
+++++++++++++++++++++++++++++++++++++++++++1 file changed, 85 insertions(+)drivers/char/tpm/tpm-chip.c +1
-0@@ -36,6 +36,83 @@dev_t tpm_devt;/** +* show_description - sysfs interface for checking current TPM hardware version.
+ * @dev: pointer to tpm chip device
+ * @attr: unused
+ * @buf: char buffer to be filled with TPM hardware version info
+ *
+ * Provides sysfs interface for showing current TPM hardware version.
+ */drivers/char/tpm/tpm-chip.c +3
-0+static ssize_t show_description (struct device *dev, +struct device_attribute *attr,char *buf) { + struct tpm_chip *chip = (struct tpm_chip *)container_of(dev,structtpm_chip,dev);
drivers/char/tpm/tpm-chip.c +20
-0+int ret; + +if (chip->flags &TPM_CHIP_FLAG_TPM2 ) + ret =sprintf (buf,"TPM 2.0" ); +else + ret =sprintf (buf,"TPM 1.x" ); + +return ret; +} + +/** +* store_description - interface for manually setting data. +* @dev: unused +* @attr: unused +* @buf: unused +* @count: unused +* +* There is not any process in this function, reserve for feature. +*/ +static ssize_t store_description(struct device *dev, struct
device_attribute*attr,drivers/char/tpm/tpm-chip.c line 73
Quoted 4 lines
drivers/char/tpm/tpm-chip.c +4
-0+ const char *buf, size_t count) +{ +return count; +}Since it does not do anything
I would not create this function and leave the sysfs node asS_IRUGO.Quoted 59 lines
drivers/char/tpm/tpm-chip.c +3
-0+ +static struct device_attribute tpm_attrs[] = { + __ATTR(description, S_IRUGO | S_IWUSR, show_description,
store_description),drivers/char/tpm/tpm-chip.c +44
-0+}; + +/** +* tpm_create_sysfs - Create tpm sysfs interface. +* @dev: pointer to tpm chip device +* +* Create sysfs interface for checking current TPM hardware version. +*/ +static int tpm_create_sysfs (struct device *dev) { +int r, t; + +for (t =0 ; t <ARRAY_SIZE (tpm_attrs); t++) { + r =device_create_file (dev, &tpm_attrs[t]); +if (r) { +dev_err (dev,"failed to create sysfs file\n" ); +return r; + } + } + +return 0 ; +} + +/** +* tpm_remove_sysfs - Remove tpm sysfs interface. +* @dev: pointer to tpm chip device +* +* Remove sysfs interface for checking current TPM hardware version. +*/ +static void tpm_remove_sysfs (struct device *dev) { +int t; + +for (t =0 ; t <ARRAY_SIZE (tpm_attrs); t++) { +device_remove_file (dev, &tpm_attrs[t]); + } +} + +/** * tpm_try_get_ops() - Get a ref to the tpm_chip * @chip: Chip to ref * @@ -363,6 +440,13 @@ int tpm_chip_register(struct tpm_chip *chip)return rc; } + rc =tpm_create_sysfs (&chip->dev); +if (rc) { +tpm_del_legacy_sysfs (chip); +tpm_chip_unregister (chip); +return rc; + } +return 0 ; }EXPORT_SYMBOL_GPL (tpm_chip_register);drivers/char/tpm/tpm-chip.c int tpm_chip_register(struct tpm_chip *chip) · line 471
Quoted 6 lines
drivers/char/tpm/tpm-chip.c +1
-0@@ -382,6 +466,7 @@ int tpm_chip_register(struct tpm_chip *chip)*/ void tpm_chip_unregister (struct tpm_chip *chip) { +tpm_remove_sysfs (&chip->dev);tpm_del_legacy_sysfs (chip);tpm_bios_log_teardown (chip);tpm_del_char_device (chip);--
Sent from my mobile
Quoted 3 lines · Peter Huewe
And yes you are right there is currently no way, except for trial and error, for the userspace to determine this. So an interface to get this information makes sense to me.
In practice, I suspect that a single user space application won't support both TPMs. It will send the first command, get an error response code that says it's the wrong TPM, and exit.
Note that, although there is no overlap in the command API, the packet format is compatible enough that a meaningful response can be returned.
Peter Huewe
maintainerAm 14. März 2017 19:18:15 MEZ schrieb Ken Goldman <[email protected]>:
Quoted 8 lines · Peter Huewe
Quoted 4 lines
And yes you are right there is currently no way, except for trial and error, for the userspace to determine this. So an interface to get this information makes sense to me.
In practice, I suspect that a single user space application won't support both TPMs.
Think of init scripts.
Which daemon should it start?
Quoted 16 lines
It will send the first command, get an error response code that says it's the wrong TPM, and exit.
Note that, although there is no overlap in the command API, the packet format is compatible enough that a meaningful response can be returned.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
tpmdd-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Signature · 9 lines
Sent from my mobile ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
Quoted 4 lines · Peter Huewe
Quoted 2 lines
In practice, I suspect that a single user space application won't support both TPMs.
Think of init scripts.
Which daemon should it start?
Right, ideally we'd have a udev rule that triggers systemd to start the userspace daemons when a TPM is detected, as other hardware does.
So whatever format we use has to be compatible with udev's matcher..
Jason
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Quoted 11 lines · Jason Gunthorpe
Quoted 4 lines · Peter Huewe
Quoted 2 lines
In practice, I suspect that a single user space application won't support both TPMs.
Think of init scripts.
Which daemon should it start?Right, ideally we'd have a udev rule that triggers systemd to start the userspace daemons when a TPM is detected, as other hardware does.
So whatever format we use has to be compatible with udev's matcher..
Technically, we have that already: my TPM2.0 detection stuff for udev triggers off the presence of the SUBSYSTEM=="tpmrm" that matches any TPM2 device but not a 1.x one.
James
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Quoted 8 lines · James Bottomley
Quoted 7 lines · Jason Gunthorpe
Quoted 4 lines · Peter Huewe
Quoted 2 lines
In practice, I suspect that a single user space application won't support both TPMs.
Think of init scripts.
Which daemon should it start?
Quoted 8 lines
Quoted 4 lines
Right, ideally we'd have a udev rule that triggers systemd to start the userspace daemons when a TPM is detected, as other hardware does.
So whatever format we use has to be compatible with udev's matcher..
Technically, we have that already: my TPM2.0 detection stuff for udev triggers off the presence of the SUBSYSTEM=="tpmrm" that matches any TPM2 device but not a 1.x one.
but long term tpmrm won't be TPM2 exclusive..
Jason
drivers/char/tpm/tpm-chip.c
Quoted 15 lines · On Mon, Mar 13, 2017 at 01:21:57PM +0800, [email protected] wrote:
From: Limeng <[email protected]>
So far, there is not a sysfs interface for user space code to check the TPM hardware version(TPM1.x or TPM2). So, add a file named description in
/sys/class/tpm/tpmX/to show it.Signed-off-by Meng Li <[email protected]>--- drivers/char/tpm/tpm-chip.c | 85 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 85 insertions(+)drivers/char/tpm/tpm-chip.c +0
-0
tpm-sysfs.c Probably makes sense to rename legacy group there as tpm1_
drivers/char/tpm/tpm-chip.c line 47
Quoted 13 lines
drivers/char/tpm/tpm-chip.c +9
-0@@ -36,6 +36,83 @@dev_t tpm_devt;/** +* show_description - sysfs interface for checking current TPM hardware version. +* @dev: pointer to tpm chip device +* @attr: unused +* @buf: char buffer to be filled with TPM hardware version info +* +* Provides sysfs interface for showing current TPM hardware version. +*/ +static ssize_t show_description (struct device *dev, +struct device_attribute *attr,char *buf)
family
Quoted 16 lines
drivers/char/tpm/tpm-chip.c +16
-0+{ + struct tpm_chip *chip = (struct tpm_chip *)container_of(dev,struct tpm_chip,dev); +int ret; + +if (chip->flags &TPM_CHIP_FLAG_TPM2 ) + ret =sprintf (buf,"TPM 2.0" ); +else + ret =sprintf (buf,"TPM 1.x" ); + +return ret; +} + +/** +* store_description - interface for manually setting data. +* @dev: unused +* @attr: unused
drivers/char/tpm/tpm-chip.c line 73
Quoted 10 lines
drivers/char/tpm/tpm-chip.c +10
-0+* @buf: unused +* @count: unused +* +* There is not any process in this function, reserve for feature. +*/ +static ssize_t store_description (struct device *dev,struct device_attribute *attr, +const char *buf,size_t count) +{ +return count; +}
What is this??
Quoted 69 lines
drivers/char/tpm/tpm-chip.c +50
-0+ +static struct device_attribute tpm_attrs[] = { +__ATTR (description,S_IRUGO |S_IWUSR , show_description, store_description), +}; + +/** +* tpm_create_sysfs - Create tpm sysfs interface. +* @dev: pointer to tpm chip device +* +* Create sysfs interface for checking current TPM hardware version. +*/ +static int tpm_create_sysfs (struct device *dev) +{ +int r, t; + +for (t =0 ; t <ARRAY_SIZE (tpm_attrs); t++) { + r =device_create_file (dev, &tpm_attrs[t]); +if (r) { +dev_err (dev,"failed to create sysfs file\n" ); +return r; + } + } + +return 0 ; +} + +/** +* tpm_remove_sysfs - Remove tpm sysfs interface. +* @dev: pointer to tpm chip device +* +* Remove sysfs interface for checking current TPM hardware version. +*/ +static void tpm_remove_sysfs (struct device *dev) +{ +int t; + +for (t =0 ; t <ARRAY_SIZE (tpm_attrs); t++) { +device_remove_file (dev, &tpm_attrs[t]); + } +} + +/** * tpm_try_get_ops() - Get a ref to the tpm_chip * @chip: Chip to ref * @@ -363,6 +440,13 @@ int tpm_chip_register(struct tpm_chip *chip)return rc; } + rc =tpm_create_sysfs (&chip->dev); +if (rc) { +tpm_del_legacy_sysfs (chip); +tpm_chip_unregister (chip); +return rc; + } +return 0 ; }EXPORT_SYMBOL_GPL (tpm_chip_register);@@ -382,6 +466,7 @@ int tpm_chip_register(struct tpm_chip *chip)*/ void tpm_chip_unregister (struct tpm_chip *chip) { +tpm_remove_sysfs (&chip->dev);tpm_del_legacy_sysfs (chip);tpm_bios_log_teardown (chip);tpm_del_char_device (chip);Signature · 1 line
1.7.9.5
You should put the attributes to chip->groups instead of racy creation of them.
/Jarkko
Quoted 23 lines
-----Original Message-----
From: Jarkko Sakkinen [mailto:jarkko.sakkinen-VuQAYsv1563Yd54FQh9/[email protected]]
Sent: Monday, March 13, 2017 7:49 PM
To: Li, Meng
Cc: [email protected]; [email protected]; [email protected]; jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org; tpmdd- [email protected]
Subject: Re: [PATCH] tpm: Add sysfs interface to show TPM hardware
versionQuoted 9 lines · On Mon, Mar 13, 2017 at 01:21:57PM +0800…
From: Limeng <[email protected]>
So far, there is not a sysfs interface for user space code to check the TPM hardware version(TPM1.x or TPM2). So, add a file named description in
/sys/class/tpm/tpmX/to show it.Signed-off-by Meng Li <[email protected]>--- drivers/char/tpm/tpm-chip.c | 85+++++++++++++++++++++++++++++++++++++++++++
Quoted 8 lines
drivers/char/tpm/tpm-chip.c
Quoted 6 lines
1 file changed, 85 insertions(+)drivers/char/tpm/tpm-chip.c +0
-0
tpm-sysfs.cProbably makes sense to rename legacy group there astpm1_
Thanks for this advice.
Quoted 110 lines
drivers/char/tpm/tpm-chip.c line 39
Quoted 6 lines
drivers/char/tpm/tpm-chip.c +1
-0@@ -36,6 +36,83 @@dev_t tpm_devt;/** +* show_description - sysfs interface for checking current TPM hardware version.
drivers/char/tpm/tpm-chip.c line 47
Quoted 8 lines
drivers/char/tpm/tpm-chip.c +8
-0+* @dev: pointer to tpm chip device +* @attr: unused +* @buf: char buffer to be filled with TPM hardware version info +* +* Provides sysfs interface for showing current TPM hardware version. +*/ +static ssize_t show_description (struct device *dev, +struct device_attribute *attr,char *buf)family
drivers/char/tpm/tpm-chip.c line 49
Quoted 2 lines
drivers/char/tpm/tpm-chip.c +2
-0+{ + struct tpm_chip *chip = (struct tpm_chip *)container_of(dev,structtpm_chip,dev);
Quoted 10 lines
drivers/char/tpm/tpm-chip.c +10
-0+int ret; + +if (chip->flags &TPM_CHIP_FLAG_TPM2 ) + ret =sprintf (buf,"TPM 2.0" ); +else + ret =sprintf (buf,"TPM 1.x" ); + +return ret; +} +drivers/char/tpm/tpm-chip.c
Quoted 10 lines
drivers/char/tpm/tpm-chip.c +10
-0+/** +* store_description - interface for manually setting data. +* @dev: unused +* @attr: unused +* @buf: unused +* @count: unused +* +* There is not any process in this function, reserve for feature. +*/ +static ssize_t store_description(struct device *dev, struct
device_attribute*attr,drivers/char/tpm/tpm-chip.c line 73
Quoted 4 lines
drivers/char/tpm/tpm-chip.c +4
-0+ const char *buf, size_t count) +{ +return count; +}What is this??
Quoted 61 lines
drivers/char/tpm/tpm-chip.c +48
-0+ +static struct device_attribute tpm_attrs[] = { +__ATTR (description,S_IRUGO |S_IWUSR , show_description, +store_description), }; + +/** +* tpm_create_sysfs - Create tpm sysfs interface. +* @dev: pointer to tpm chip device +* +* Create sysfs interface for checking current TPM hardware version. +*/ +static int tpm_create_sysfs (struct device *dev) { +int r, t; + +for (t =0 ; t <ARRAY_SIZE (tpm_attrs); t++) { + r =device_create_file (dev, &tpm_attrs[t]); +if (r) { +dev_err (dev,"failed to create sysfs file\n" ); +return r; + } + } + +return 0 ; +} + +/** +* tpm_remove_sysfs - Remove tpm sysfs interface. +* @dev: pointer to tpm chip device +* +* Remove sysfs interface for checking current TPM hardware version. +*/ +static void tpm_remove_sysfs (struct device *dev) { +int t; + +for (t =0 ; t <ARRAY_SIZE (tpm_attrs); t++) { +device_remove_file (dev, &tpm_attrs[t]); + } +} + +/** * tpm_try_get_ops() - Get a ref to the tpm_chip * @chip: Chip to ref * @@ -363,6 +440,13 @@ int tpm_chip_register(struct tpm_chip *chip)return rc; } + rc =tpm_create_sysfs (&chip->dev); +if (rc) { +tpm_del_legacy_sysfs (chip); +tpm_chip_unregister (chip); +return rc; + } +return 0 ; }EXPORT_SYMBOL_GPL (tpm_chip_register);@@ -382,6 +466,7 @@ int tpm_chip_register(struct tpm_chip *chip)*/ void tpm_chip_unregister (struct tpm_chip *chip) { +tpm_remove_sysfs (&chip->dev);
Quoted 8 lines
Quoted 5 lines
drivers/char/tpm/tpm-chip.c +0
-1tpm_del_legacy_sysfs (chip);tpm_bios_log_teardown (chip);tpm_del_char_device (chip); --1.7.9.5
You should put the attributes to
chip->groupsinstead of racy creation of them.
Thanks for your advice. It is more reasonable in to chip->groups.
Regards,
Limeng
Quoted 2 lines
/Jarkko
------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned dictionary content that is easy and intuitive to access. Sign up for an account today to start using our lexical data to power your apps and projects. Get started today and enter our developer competition.
http://sdm.link/oxford