Patch "kasan: resched in quarantine_remove_cache()" has been added to the 4.10-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
kasan: resched in quarantine_remove_cache()
to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
kasan-resched-in-quarantine_remove_cache.patch
and it can be found in the queue-4.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
68fd814a3391c7e017ae6ace8855788748edd981Mon Sep 17 00:00:00 2001
From: Dmitry Vyukov <[email protected]>
Date: Thu, 9 Mar 2017 16:17:28 -0800
Subject: kasan: resched in quarantine_remove_cache()
From: Dmitry Vyukov <[email protected]>
commit 68fd814a3391c7e017ae6ace8855788748edd981 upstream.
We see reported stalls/lockups in quarantine_remove_cache() on machines with large amounts of RAM. quarantine_remove_cache() needs to scan whole quarantine in order to take out all objects belonging to the cache. Quarantine is currently 1/32-th of RAM, e.g. on a machine with 256GB of memory that will be 8GB. Moreover quarantine scanning is a walk over uncached linked list, which is slow.
Add cond_resched() after scanning of each non-empty batch of objects. Batches are specifically kept of reasonable size for quarantine_put(). On a machine with 256GB of RAM we should have ~512 non-empty batches, each with 16MB of objects.
--- mm/kasan/quarantine.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
mm/kasan/quarantine.c +8 -1
@@ -282,8 +282,15 @@ void quarantine_remove_cache(struct kmemon_each_cpu (per_cpu_remove_cache, cache,1 );spin_lock_irqsave (&quarantine_lock, flags); -for (i =0 ; i <QUARANTINE_BATCHES ; i++) +for (i =0 ; i <QUARANTINE_BATCHES ; i++) { +if (qlist_empty (&global_quarantine[i])) +continue ;qlist_move_cache (&global_quarantine[i], &to_free, cache); +/* Scanning whole quarantine can take a while. */ +spin_unlock_irqrestore (&quarantine_lock, flags); +cond_resched (); +spin_lock_irqsave (&quarantine_lock, flags); + }spin_unlock_irqrestore (&quarantine_lock, flags);qlist_free_all (&to_free, cache);
Patches currently in stable-queue which might be from [email protected] are
queue-4.10/kasan-resched-in-quarantine_remove_cache.patch