libiio: Disable MATLAB Bindings on Target

PATCH New Matthew Fornero 4 participants 4 messages Mar 13, 2017 – Mar 14, 2017

Share & tools

Matthew Fornero

author

2017-03-13 19:35 UTC #0 lore raw

PATCH 1/1 libiio: Disable MATLAB Bindings on Target

If building on a machine with MATLAB installed, the MATLAB bindings will default to ON, which is not the desired behavior for a cross build.

The bindings are designed to be called from within MATLAB, and we are not currently running MATLAB on buildroot-generated targets.

This does not preclude the use of the bindings from a host connecting over the network backend (assuming libiio on the host has the bindings enabled).

Signed-off-by Matthew Fornero <[email protected]>

---
 package/libiio/libiio.mk | 1 +
 1 file changed, 1 insertion(+)

package/libiio/libiio.mk +1 -0

index 8977610..aaa6c70 100644
@@ -14,6 +14,7 @@ LIBIIO_CONF_OPTS = -DENABLE_IPV6=ON \
 	-DWITH_LOCAL_BACKEND=$(if $(BR2_PACKAGE_LIBIIO_LOCAL_BACKEND),ON,OFF) \
 	-DWITH_NETWORK_BACKEND=$(if $(BR2_PACKAGE_LIBIIO_NETWORK_BACKEND),ON,OFF) \
 	-DWITH_MATLAB_BINDINGS_API=OFF \
+	-DMATLAB_BINDINGS=OFF \
 	-DINSTALL_UDEV_RULE=$(if $(BR2_PACKAGE_HAS_UDEV),ON,OFF) \
 	-DWITH_TESTS=$(if $(BR2_PACKAGE_LIBIIO_TESTS),ON,OFF) \
 	-DWITH_DOC=OFF

Signature · 1 line

2.1.4

Cercueil

2017-03-14 15:05 UTC #1 lore raw

PATCH 1/1 libiio: Disable MATLAB Bindings on Target

Makes sense.

Acked-by Paul Cercueil <[email protected]>

Signature · 6 lines

???__????____??____
? /__\??(??_ \(_??_)??| Paul Cercueil        paul.cercueil at analog.com
?/(__)\??)(_) )_)(_???| Software Engineer    github.com/pcercuei
(__)(__)(____/(____)??| Analog Devices, S.L. Paterna (Valencia) SPAIN

Le lundi 13 mars 2017 ? 15:35 -0400, Matthew Fornero a ?crit?:

Quoted 28 lines

If building on a machine with MATLAB installed, the MATLAB bindings will
default to ON, which is not the desired behavior for a cross build.
The bindings are designed to be called from within MATLAB, and we are not currently running MATLAB on buildroot-generated targets.
This does not preclude the use of the bindings from a host connecting over the network backend (assuming libiio on the host has the bindings
enabled).
Signed-off-by Matthew Fornero <[email protected]>
---
?package/libiio/libiio.mk | 1 +
?1 file changed, 1 insertion(+)
package/libiio/libiio.mk +0 -0
index 8977610..aaa6c70 100644
@@ -14,6 +14,7 @@ LIBIIO_CONF_OPTS = -DENABLE_IPV6=ON \
? -DWITH_LOCAL_BACKEND=$(if
$(BR2_PACKAGE_LIBIIO_LOCAL_BACKEND),ON,OFF) \
? -DWITH_NETWORK_BACKEND=$(if
$(BR2_PACKAGE_LIBIIO_NETWORK_BACKEND),ON,OFF) \
? -DWITH_MATLAB_BINDINGS_API=OFF \
package/libiio/libiio.mk +1 -0
+	-DMATLAB_BINDINGS=OFF \

Quoted 3 lines

? -DINSTALL_UDEV_RULE=$(if $(BR2_PACKAGE_HAS_UDEV),ON,OFF) \
? -DWITH_TESTS=$(if $(BR2_PACKAGE_LIBIIO_TESTS),ON,OFF) \
? -DWITH_DOC=OFF

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170314/ce4dda88/attachment.asc>

Thomas Petazzoni

Applied

2017-03-14 22:41 UTC #2 lore raw

PATCH 1/1 libiio: Disable MATLAB Bindings on Target

In reply to Matthew Fornero

Hello,

Quoted 6 lines · Matthew Fornero

If building on a machine with MATLAB installed, the MATLAB bindings will default to ON, which is not the desired behavior for a cross build.
The bindings are designed to be called from within MATLAB, and we are not currently running MATLAB on buildroot-generated targets.

Quoted 8 lines

This does not preclude the use of the bindings from a host connecting over the network backend (assuming libiio on the host has the bindings enabled).
Signed-off-by Matthew Fornero <[email protected]>
---
 package/libiio/libiio.mk | 1 +
 1 file changed, 1 insertion(+)

Applied to master, after slightly tweaking the commit title. Thanks!

Peter: perhaps we want this for the LTS branch? Not sure.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Peter Korsgaard

2017-03-14 23:22 UTC #3 lore raw

PATCH 1/1 libiio: Disable MATLAB Bindings on Target

Quoted 14 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Hello,
Quoted 10 lines · Matthew Fornero
If building on a machine with MATLAB installed, the MATLAB bindings will default to ON, which is not the desired behavior for a cross build.
The bindings are designed to be called from within MATLAB, and we are not currently running MATLAB on buildroot-generated targets.
This does not preclude the use of the bindings from a host connecting over the network backend (assuming libiio on the host has the bindings enabled).

Quoted 8 lines

Quoted 4 lines
Signed-off-by Matthew Fornero <[email protected]>
---
package/libiio/libiio.mk | 1 +
1 file changed, 1 insertion(+)
Applied to master, after slightly tweaking the commit title. Thanks!
Peter: perhaps we want this for the LTS branch? Not sure.

It seems pretty safe to add it. Committed to 2017.02.x, thanks.

Signature · 1 line

Bye, Peter Korsgaard