Skip to contentSkip to conversation

drm: qxl: add missing return check

PATCH Applied Dan Carpenter 2 participants 3 messages Mar 14, 2017

Subsystems (5)
DRM drivers DRM misc Kernel janitors virtio core +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm: qxl: add missing return check

My static checker complains that "release" is uninitialized if qxl_alloc_release_reserved() fails, so let's add a check for that.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/qxl/qxl_display.c +2 -0
index 9548bb58d3bc..058340a002c2 100644
@@ -572,6 +572,8 @@ static void qxl_cursor_atomic_update(struct drm_plane *plane,
 	ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd),
 					 QXL_RELEASE_CURSOR_CMD,
 					 &release, NULL);
+	if (ret)
+		return;
 
 	cmd = (struct qxl_cursor_cmd *) qxl_release_map(qdev, release);
maintainer Applied
#1 lore raw
Quoted 2 lines · Dan Carpenter

My static checker complains that "release" is uninitialized if qxl_alloc_release_reserved() fails, so let's add a check for that.

applied to drm-misc-next.

thanks,
Gerd

maintainer Applied
#2 lore raw
In reply to Dan Carpenter
Quoted 2 lines · Dan Carpenter

My static checker complains that "release" is uninitialized if qxl_alloc_release_reserved() fails, so let's add a check for that.

applied to drm-misc-next.

thanks,
Gerd