drm/amdgpu/gfx8: enable cp/rlc ints after we disable clockgating
Subsystems (2)
PATCH 1/2 drm/amdgpu/gfx8: enable cp/rlc ints after we disable clockgating
Even if we disable clockgating, we still need to make sure the cp/rlc interrupts are enabled for powergating which might still be enabled.
--- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +2 -0
@@ -6258,6 +6258,8 @@ static void gfx_v8_0_update_coarse_grain_clock_gating(struct amdgpu_device *adev RLC_CGCG_CGLS_CTRL__CGLS_EN_MASK);if (temp != data)WREG32 (mmRLC_CGCG_CGLS_CTRL, data); +/* enable interrupts again for PG */ +gfx_v8_0_enable_gui_idle_interrupt (adev, true); }gfx_v8_0_wait_for_rlc_serdes (adev);
Signature · 6 lines
2.5.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1489519966-14076-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org
PATCH 2/2 drm/amdgpu/gfx7: enable cp/rlc ints after we disable clockgating
Even if we disable clockgating, we still need to make sure the cp/rlc interrupts are enabled for powergating which might still be enabled.
--- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c +7 -4
@@ -3797,6 +3797,9 @@ static void gfx_v7_0_enable_cgcg(struct amdgpu_device *adev, bool enable)gfx_v7_0_update_rlc (adev, tmp); data |=RLC_CGCG_CGLS_CTRL__CGCG_EN_MASK |RLC_CGCG_CGLS_CTRL__CGLS_EN_MASK ; +if (orig != data) +WREG32 (mmRLC_CGCG_CGLS_CTRL, data); + }else {gfx_v7_0_enable_gui_idle_interrupt (adev, false);
@@ -3806,11 +3809,11 @@ static void gfx_v7_0_enable_cgcg(struct amdgpu_device *adev, bool enable)RREG32 (mmCB_CGTT_SCLK_CTRL); data &= ~(RLC_CGCG_CGLS_CTRL__CGCG_EN_MASK |RLC_CGCG_CGLS_CTRL__CGLS_EN_MASK ); - } - -if (orig != data) -WREG32 (mmRLC_CGCG_CGLS_CTRL, data); +if (orig != data) +WREG32 (mmRLC_CGCG_CGLS_CTRL, data); +gfx_v7_0_enable_gui_idle_interrupt (adev, true); + } }static void gfx_v7_0_enable_mgcg (struct amdgpu_device *adev,bool enable)
Signature · 6 lines
2.5.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 5 lines · Alex Deucher
Even if we disable clockgating, we still need to make sure the cp/rlc interrupts are enabled for powergating which might still be enabled.
Signed-off-by Alex Deucher <[email protected]>
Anyone?
Quoted 18 lines
--- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +2
-1@@ -6258,6 +6258,8 @@ static void gfx_v8_0_update_coarse_grain_clock_gating(struct amdgpu_device *adev RLC_CGCG_CGLS_CTRL__CGLS_EN_MASK);if (temp != data)WREG32 (mmRLC_CGCG_CGLS_CTRL, data); +/* enable interrupts again for PG */ +gfx_v8_0_enable_gui_idle_interrupt (adev, true); }gfx_v8_0_wait_for_rlc_serdes (adev); --
Quoted 2 lines
2.5.5
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_OLYbf8mAfquxfLgSaPfSjRi0f-UQXQbOsAe+2kU1oQjg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 8 lines · Alex Deucher
Quoted 5 lines · Alex Deucher
Even if we disable clockgating, we still need to make sure the cp/rlc interrupts are enabled for powergating which might still be enabled.
Signed-off-by Alex Deucher <[email protected]>Anyone?
Haven't had a chance to try it out (only one devel board...).
In principle that should work provided this is called when CGCG is disabled.
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Ping?
Quoted 23 lines · Alex Deucher
Even if we disable clockgating, we still need to make sure the cp/rlc interrupts are enabled for powergating which might still be enabled.
Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +2
-1@@ -6258,6 +6258,8 @@ static void gfx_v8_0_update_coarse_grain_clock_gating(struct amdgpu_device *adev RLC_CGCG_CGLS_CTRL__CGLS_EN_MASK);if (temp != data)WREG32 (mmRLC_CGCG_CGLS_CTRL, data); +/* enable interrupts again for PG */ +gfx_v8_0_enable_gui_idle_interrupt (adev, true); }gfx_v8_0_wait_for_rlc_serdes (adev); --
Quoted 2 lines
2.5.5
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx