Skip to contentSkip to conversation

Patch "USB: serial: io_ti: fix NULL-deref in interrupt callback" has been added to the 4.10-stable tree

PATCH [email protected] 1 participant 1 message Mar 15, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: serial: io_ti: fix NULL-deref in interrupt callback

to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-serial-io_ti-fix-null-deref-in-interrupt-callback.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 0b1d250afb8eb9d65afb568bac9b9f9253a82b49 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Mon, 6 Mar 2017 17:36:37 +0100
Subject: USB: serial: io_ti: fix NULL-deref in interrupt callback

From: Johan Hovold <[email protected]>

commit 0b1d250afb8eb9d65afb568bac9b9f9253a82b49 upstream.

Fix a NULL-pointer dereference in the interrupt callback should a malicious device send data containing a bad port number by adding the missing sanity check.

Fixes 1da177e4c3f4 ("Linux-2.6.12-rc2")
---
 drivers/usb/serial/io_ti.c |    6 ++++++
 1 file changed, 6 insertions(+)
drivers/usb/serial/io_ti.c +6 -0
@@ -1674,6 +1674,12 @@ static void edge_interrupt_callback(stru
 	function    = TIUMP_GET_FUNC_FROM_CODE(data[0]);
 	dev_dbg(dev, "%s - port_number %d, function %d, info 0x%x\n", __func__,
 		port_number, function, data[1]);
+
+	if (port_number >= edge_serial->serial->num_ports) {
+		dev_err(dev, "bad port number %d\n", port_number);
+		goto exit;
+	}
+
 	port = edge_serial->serial->port[port_number];
 	edge_port = usb_get_serial_port_data(port);
 	if (!edge_port) {

Patches currently in stable-queue which might be from [email protected] are

queue-4.10/usb-serial-digi_acceleport-fix-oob-event-processing.patch queue-4.10/usb-serial-omninet-fix-reference-leaks-at-open.patch queue-4.10/usb-serial-digi_acceleport-fix-oob-data-sanity-check.patch queue-4.10/usb-iowarrior-fix-null-deref-in-write.patch queue-4.10/usb-iowarrior-fix-null-deref-at-probe.patch queue-4.10/usb-serial-io_ti-fix-null-deref-in-interrupt-callback.patch queue-4.10/usb-serial-io_ti-fix-information-leak-in-completion-handler.patch queue-4.10/usb-serial-safe_serial-fix-information-leak-in-completion-handler.patch