Skip to contentSkip to conversation

Patch "USB: iowarrior: fix NULL-deref in write" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 15, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: iowarrior: fix NULL-deref in write

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-iowarrior-fix-null-deref-in-write.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From de46e56653de7b3b54baa625bd582635008b8d05 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Tue, 7 Mar 2017 16:11:04 +0100
Subject: USB: iowarrior: fix NULL-deref in write

From: Johan Hovold <[email protected]>

commit de46e56653de7b3b54baa625bd582635008b8d05 upstream.

Make sure to verify that we have the required interrupt-out endpoint for IOWarrior56 devices to avoid dereferencing a NULL-pointer in write should a malicious device lack such an endpoint.

Fixes 946b960d13c1 ("USB: add driver for iowarrior devices.")
---
 drivers/usb/misc/iowarrior.c |    8 ++++++++
 1 file changed, 8 insertions(+)
drivers/usb/misc/iowarrior.c +8 -0
@@ -804,6 +804,14 @@ static int iowarrior_probe(struct usb_in
 		goto error;
 	}
 
+	if (dev->product_id == USB_DEVICE_ID_CODEMERCS_IOW56) {
+		if (!dev->int_out_endpoint) {
+			dev_err(&interface->dev, "no interrupt-out endpoint found\n");
+			retval = -ENODEV;
+			goto error;
+		}
+	}
+
 	/* we have to check the report_size often, so remember it in the endianness suitable for our machine */
 	dev->report_size = usb_endpoint_maxp(dev->int_in_endpoint);
 	if ((dev->interface->cur_altsetting->desc.bInterfaceNumber == 0) &&

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/usb-serial-digi_acceleport-fix-oob-event-processing.patch queue-4.4/usb-serial-omninet-fix-reference-leaks-at-open.patch queue-4.4/usb-serial-digi_acceleport-fix-oob-data-sanity-check.patch queue-4.4/usb-iowarrior-fix-null-deref-in-write.patch queue-4.4/usb-iowarrior-fix-null-deref-at-probe.patch queue-4.4/usb-serial-io_ti-fix-null-deref-in-interrupt-callback.patch queue-4.4/usb-serial-io_ti-fix-information-leak-in-completion-handler.patch queue-4.4/usb-serial-safe_serial-fix-information-leak-in-completion-handler.patch