Skip to contentSkip to conversation

Patch "USB: serial: safe_serial: fix information leak in completion handler" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 15, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: serial: safe_serial: fix information leak in completion handler

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-serial-safe_serial-fix-information-leak-in-completion-handler.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8c76d7cd520ebffc1ea9ea0850d87a224a50c7f2 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Mon, 6 Mar 2017 17:36:41 +0100
Subject: USB: serial: safe_serial: fix information leak in completion handler

From: Johan Hovold <[email protected]>

commit 8c76d7cd520ebffc1ea9ea0850d87a224a50c7f2 upstream.

Add missing sanity check to the bulk-in completion handler to avoid an integer underflow that could be triggered by a malicious device.

This avoids leaking up to 56 bytes from after the URB transfer buffer to user space.

Fixes 1da177e4c3f4 ("Linux-2.6.12-rc2")
---
 drivers/usb/serial/safe_serial.c |    5 +++++
 1 file changed, 5 insertions(+)
drivers/usb/serial/safe_serial.c +5 -0
@@ -205,6 +205,11 @@ static void safe_process_read_urb(struct
 	if (!safe)
 		goto out;
 
+	if (length < 2) {
+		dev_err(&port->dev, "malformed packet\n");
+		return;
+	}
+
 	fcs = fcs_compute10(data, length, CRC10_INITFCS);
 	if (fcs) {
 		dev_err(&port->dev, "%s - bad CRC %x\n", __func__, fcs);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/usb-serial-digi_acceleport-fix-oob-event-processing.patch queue-4.4/usb-serial-omninet-fix-reference-leaks-at-open.patch queue-4.4/usb-serial-digi_acceleport-fix-oob-data-sanity-check.patch queue-4.4/usb-iowarrior-fix-null-deref-in-write.patch queue-4.4/usb-iowarrior-fix-null-deref-at-probe.patch queue-4.4/usb-serial-io_ti-fix-null-deref-in-interrupt-callback.patch queue-4.4/usb-serial-io_ti-fix-information-leak-in-completion-handler.patch queue-4.4/usb-serial-safe_serial-fix-information-leak-in-completion-handler.patch