usb: gadget: Correct usb EP argument for BOT status request
PATCH 1/1 usb: gadget: Correct usb EP argument for BOT status request
This patch corrects the argument in usb_ep_free_request as it is mistakenly set to ep_out. It should be ep_in for status request.
--- drivers/usb/gadget/function/f_tcm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/gadget/function/f_tcm.c +1 -1
@@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)usb_ep_free_request (fu->ep_in, fu->bot_req_in);usb_ep_free_request (fu->ep_out, fu->bot_req_out);usb_ep_free_request (fu->ep_out, fu->cmd.req); -usb_ep_free_request (fu->ep_out, fu->bot_status.req); +usb_ep_free_request (fu->ep_in, fu->bot_status.req);kfree (fu->cmd.buf);
Signature · 1 line
1.7.1
Nicholas A. Bellinger
AppliedHi Manish,
(Added target-devel CC')
Quoted 13 lines · Manish Narani
This patch corrects the argument in
usb_ep_free_requestas it is mistakenly set toep_out. It should beep_infor status request.Signed-off-by Manish Narani <[email protected]>--- drivers/usb/gadget/function/f_tcm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/gadget/function/f_tcm.c +0
-0
drivers/usb/gadget/function/f_tcm.c static void bot_cleanup_old_alt(struct f_uas *fu) · line 379
Quoted 8 lines
drivers/usb/gadget/function/f_tcm.c +1
-1@@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)usb_ep_free_request (fu->ep_in, fu->bot_req_in);usb_ep_free_request (fu->ep_out, fu->bot_req_out);usb_ep_free_request (fu->ep_out, fu->cmd.req); -usb_ep_free_request (fu->ep_out, fu->bot_status.req); +usb_ep_free_request (fu->ep_in, fu->bot_status.req);kfree (fu->cmd.buf);
Applied to target-pending/master.
Thanks!
Felipe Balbi
Acked-byHi,
Quoted 24 lines · Nicholas A. Bellinger
Hi Manish,
(Added target-devel CC')
Quoted 19 lines · Manish Narani
This patch corrects the argument in
usb_ep_free_requestas it is mistakenly set toep_out. It should beep_infor status request.Signed-off-by Manish Narani <[email protected]>--- drivers/usb/gadget/function/f_tcm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/gadget/function/f_tcm.c +1
-1@@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)usb_ep_free_request (fu->ep_in, fu->bot_req_in);usb_ep_free_request (fu->ep_out, fu->bot_req_out);usb_ep_free_request (fu->ep_out, fu->cmd.req); -usb_ep_free_request (fu->ep_out, fu->bot_status.req); +usb_ep_free_request (fu->ep_in, fu->bot_status.req);
Quoted 4 lines
drivers/usb/gadget/function/f_tcm.c static void bot_cleanup_old_alt(struct f_uas *fu) · line 379
Quoted 2 lines
drivers/usb/gadget/function/f_tcm.c +0
-0kfree (fu->cmd.buf);Applied to target-pending/master.
Oh, so you're taking patches for f_tcm? Fair enough:
Signature · 1 line
balbi