patch "iio: magnetometer: ak8974: remove incorrect __exit markups" added to staging-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
iio: magnetometer: ak8974: remove incorrect __exit markups
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
3ff861f59f6c1f5bf2bc03d2cd36ac3f992cbc06Mon Sep 17 00:00:00 2001
From: Dmitry Torokhov <[email protected]>
Date: Wed, 1 Mar 2017 15:37:57 -0800
Subject: iio: magnetometer: ak8974: remove incorrect __exit markups
Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes.
--- drivers/iio/magnetometer/ak8974.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/magnetometer/ak8974.c +2 -2
@@ -763,7 +763,7 @@ static int ak8974_probe(struct i2c_client *i2c,return ret; } -static int __exit ak8974_remove(struct i2c_client *i2c) +static int ak8974_remove (struct i2c_client *i2c) {struct iio_dev *indio_dev =i2c_get_clientdata (i2c);struct ak8974 *ak8974 =iio_priv (indio_dev);
@@ -845,7 +845,7 @@ static struct i2c_driver ak8974_driver = { .of_match_table = of_match_ptr(ak8974_of_match), }, .probe = ak8974_probe, - .remove = __exit_p(ak8974_remove), + .remove = ak8974_remove, .id_table = ak8974_id, };module_i2c_driver (ak8974_driver);
Signature · 1 line
2.12.0