Skip to contentSkip to conversation

native.bbclass: clear MACHINE_FEATURES

PATCH In review Andre McCurdy 3 participants 5 messages Mar 22, 2017 – Mar 23, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 native.bbclass: clear MACHINE_FEATURES

Try to avoid native recipes accidentally being dependent on MACHINE_FEATURES. This simple change doesn't prevent MACHINE_FEATURES set via MACHINE_FEATURES_BACKFILL sneaking through, but it's better than nothing.

---
 meta/classes/native.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/native.bbclass +1 -0
index 6becf82..1919fbc 100644
@@ -112,6 +112,7 @@ PKG_CONFIG_SYSTEM_INCLUDE_PATH[unexport] = "1"
 LIBCOVERRIDE = ""
 CLASSOVERRIDE = "class-native"
 MACHINEOVERRIDES = ""
+MACHINE_FEATURES = ""
 
 PATH_prepend = "${COREBASE}/scripts/native-intercept:"
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 4 lines · Andre McCurdy

Try to avoid native recipes accidentally being dependent on MACHINE_FEATURES. This simple change doesn't prevent MACHINE_FEATURES set via MACHINE_FEATURES_BACKFILL sneaking through, but it's better than nothing.

Maybe this would work:

MACHINE_FEATURES_BACKFILL_CONSIDERED = "${MACHINE_FEATURES_BACKFILL}"

Quoted 12 lines
---
 meta/classes/native.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/native.bbclass +0 -0
index 6becf82..1919fbc 100644

meta/classes/native.bbclass PKG_CONFIG_SYSTEM_INCLUDE_PATH[unexport] = "1" · line 118

Quoted 7 lines
meta/classes/native.bbclass +1 -0
@@ -112,6 +112,7 @@ PKG_CONFIG_SYSTEM_INCLUDE_PATH[unexport] = "1"
 LIBCOVERRIDE = ""
 CLASSOVERRIDE = "class-native"
 MACHINEOVERRIDES = ""
+MACHINE_FEATURES = ""
 
 PATH_prepend = "${COREBASE}/scripts/native-intercept:"
 

Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: [email protected]
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

#2 lore raw
Quoted 10 lines · Mike Looijmans
Quoted 5 lines · Andre McCurdy

Try to avoid native recipes accidentally being dependent on MACHINE_FEATURES. This simple change doesn't prevent MACHINE_FEATURES set via MACHINE_FEATURES_BACKFILL sneaking through, but it's better than nothing.

Maybe this would work:

MACHINE_FEATURES_BACKFILL_CONSIDERED = "${MACHINE_FEATURES_BACKFILL}"

I guess it doesn't work if MACHINE_FEATURES_BACKFILL_CONSIDERED is set elsewhere using _append.

The real solution would probably be to skip backfilling MACHINE_FEATURES entirely for class-native?

Quoted 45 lines
Quoted 12 lines
---
 meta/classes/native.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/native.bbclass +0 -0
index 6becf82..1919fbc 100644

meta/classes/native.bbclass PKG_CONFIG_SYSTEM_INCLUDE_PATH[unexport] = "1" · line 118

Quoted 7 lines
meta/classes/native.bbclass +1 -0
@@ -112,6 +112,7 @@ PKG_CONFIG_SYSTEM_INCLUDE_PATH[unexport] = "1"
 LIBCOVERRIDE = ""
 CLASSOVERRIDE = "class-native"
 MACHINEOVERRIDES = ""
+MACHINE_FEATURES = ""
 
 PATH_prepend = "${COREBASE}/scripts/native-intercept:"
 

Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: [email protected]
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 10 lines · Andre McCurdy
Quoted 9 lines · Mike Looijmans
Quoted 5 lines · Andre McCurdy

Try to avoid native recipes accidentally being dependent on MACHINE_FEATURES. This simple change doesn't prevent MACHINE_FEATURES set via MACHINE_FEATURES_BACKFILL sneaking through, but it's better than nothing.

Maybe this would work:

Quoted 7 lines
Quoted 1 line

MACHINE_FEATURES_BACKFILL_CONSIDERED = "${MACHINE_FEATURES_BACKFILL}"

I guess it doesn't work if MACHINE_FEATURES_BACKFILL_CONSIDERED is set elsewhere using _append.

The real solution would probably be to skip backfilling MACHINE_FEATURES entirely for class-native?

Perhaps set MACHINE_FEATURES_forcevariable = "" in native.bbclass?

Signature · 6 lines
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
#4 lore raw
Quoted 13 lines · Patrick Ohly
Quoted 12 lines · Andre McCurdy
Quoted 10 lines · Mike Looijmans
Quoted 5 lines · Andre McCurdy

Try to avoid native recipes accidentally being dependent on MACHINE_FEATURES. This simple change doesn't prevent MACHINE_FEATURES set via MACHINE_FEATURES_BACKFILL sneaking through, but it's better than nothing.

Maybe this would work:

MACHINE_FEATURES_BACKFILL_CONSIDERED = "${MACHINE_FEATURES_BACKFILL}"

Quoted 7 lines
Quoted 5 lines

I guess it doesn't work if MACHINE_FEATURES_BACKFILL_CONSIDERED is set elsewhere using _append.

The real solution would probably be to skip backfilling MACHINE_FEATURES entirely for class-native?

Perhaps set MACHINE_FEATURES_forcevariable = "" in native.bbclass?

Over-riding MACHINE_FEATURES doesn't work, presumably because the ConfigParsed event handler which does the backfilling runs after over-rides have been applied?

Quoted 10 lines

--
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter.