Skip to contentSkip to conversation

Patch "gfs2: Avoid alignment hole in struct lm_lockname" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 24, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

gfs2: Avoid alignment hole in struct lm_lockname

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
gfs2-avoid-alignment-hole-in-struct-lm_lockname.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 28ea06c46fbcab63fd9a55531387b7928a18a590 Mon Sep 17 00:00:00 2001

From: Andreas Gruenbacher <[email protected]>
Date: Mon, 6 Mar 2017 12:58:42 -0500
Subject: gfs2: Avoid alignment hole in struct lm_lockname

From: Andreas Gruenbacher <[email protected]>

commit 28ea06c46fbcab63fd9a55531387b7928a18a590 upstream.

Commit 88ffbf3e03 switches to using rhashtables for glocks, hashing over the entire struct lm_lockname instead of its individual fields. On some architectures, struct lm_lockname contains a hole of uninitialized memory due to alignment rules, which now leads to incorrect hash values. Get rid of that hole.

---
 fs/gfs2/incore.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/gfs2/incore.h +1 -1
@@ -207,7 +207,7 @@ struct lm_lockname {
 	struct gfs2_sbd *ln_sbd;
 	u64 ln_number;
 	unsigned int ln_type;
-};
+} __packed __aligned(sizeof(int));
 
 #define lm_name_equal(name1, name2) \
         (((name1)->ln_number == (name2)->ln_number) &&	\

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/gfs2-avoid-alignment-hole-in-struct-lm_lockname.patch