Skip to contentSkip to conversation

RDMA/ocrdma: fix a type issue in ocrdma_put_pd_num()

PATCH Applied Dan Carpenter 3 participants 3 messages Feb 23, 2017 – Mar 25, 2017

Subsystems (3)
Kernel janitors InfiniBand Emulex oneconnect RoCE driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 RDMA/ocrdma: fix a type issue in ocrdma_put_pd_num()

We want to return zero on success or negative error codes. The type should be int and not u8.

Signed-off-by Dan Carpenter <[email protected]>
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +1 -1
index e06ad7250963..b1b075763eaa 100644
@@ -371,7 +371,7 @@ static int _ocrdma_pd_mgr_put_bitmap(struct ocrdma_dev *dev, u16 pd_id,
 	return 0;
 }
 
-static u8 ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
+static int ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
 				   bool dpp_pool)
 {
 	int status;
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Dan Carpenter

We want to return zero on success or negative error codes. The type should be int and not u8.

Signed-off-by Dan Carpenter <[email protected]>
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +0 -0
index e06ad7250963..b1b075763eaa 100644

drivers/infiniband/hw/ocrdma/ocrdma_verbs.c static int _ocrdma_pd_mgr_put_bitmap(struct ocrdma_dev *dev, u16 pd_id,

Quoted 9 lines
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +1 -2
@@ -371,7 +371,7 @@ static int _ocrdma_pd_mgr_put_bitmap(struct ocrdma_dev *dev, u16 pd_id,
 	return 0;
 }
 
-static u8 ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
+static int ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
 				   bool dpp_pool)
 {
 	int status;
--
Reviewed-by Yuval Shaia <[email protected]>
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied
#2 lore raw
In reply to Dan Carpenter
Quoted 17 lines · Dan Carpenter

We want to return zero on success or negative error codes.  The type should be int and not u8.

Signed-off-by Dan Carpenter <[email protected]>
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +0 -0
index e06ad7250963..b1b075763eaa 100644
@@ -371,7 +371,7 @@ static int _ocrdma_pd_mgr_put_bitmap(struct
 ocrdma_dev *dev, u16 pd_id,
  	return 0;
  }

drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +1 -1
-static u8 ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
+static int ocrdma_put_pd_num(struct ocrdma_dev *dev, u16 pd_id,
Quoted 3 lines

     bool dpp_pool)
 {
  int status;

Thanks, applied for -rc.

Signature · 4 lines
Doug Ledford <[email protected]>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD