Skip to contentSkip to conversation

ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

PATCH In review Sinan Kaya 3 participants 7 messages Mar 25, 2017 – Mar 28, 2017

Subsystems (2)
lore
Share & tools
lore

Sinan Kaya

author
#0 lore raw

PATCH v3 1/1 ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces.

IPMI_SSIF is an alternative BMC communication method. It allows BMC to be accessed over an I2C bus instead of a standard interface.

Change the dependency to IPMI_HANDLER so that ACPI_IPMI works with all IPMI providers.

---
 drivers/acpi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/Kconfig +1 -1
index 83e5f7e..3e15bf8 100644
@@ -256,7 +256,7 @@ config ACPI_PROCESSOR
 
 config ACPI_IPMI
 	tristate "IPMI"
-	depends on IPMI_SI
+	depends on IPMI_HANDLER
 	default n
 	help
 	  This driver enables the ACPI to access the BMC controller. And it
Signature · 1 line
1.9.1
Acked-by on v3 1/1
#1 lore raw
Quoted 9 lines · Sinan Kaya

ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces.

IPMI_SSIF is an alternative BMC communication method. It allows BMC to be accessed over an I2C bus instead of a standard interface.

Change the dependency to IPMI_HANDLER so that ACPI_IPMI works with all IPMI providers.

If the ACPI people ack this, I can queue it, or they can take it with:

Thanks,

-corey

Quoted 18 lines
---
  drivers/acpi/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/Kconfig +1 -1
index 83e5f7e..3e15bf8 100644
@@ -256,7 +256,7 @@ config ACPI_PROCESSOR
 
  config ACPI_IPMI
  	tristate "IPMI"
-	depends on IPMI_SI
+	depends on IPMI_HANDLER
  	default n
  	help
  	  This driver enables the ACPI to access the BMC controller. And it
author
#2 lore raw

Rafael,

Quoted 3 lines · Corey Minyard

If the ACPI people ack this, I can queue it, or they can take it with:

What's your preference?

Sinan

Signature · 3 lines
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
#3 lore raw
Quoted 7 lines · Sinan Kaya

Rafael,

Quoted 3 lines · Corey Minyard

If the ACPI people ack this, I can queue it, or they can take it with:

What's your preference?

I can take it, it's all ready, I just need the ack.

-corey

#4 lore raw
Quoted 10 lines · Corey Minyard
Quoted 7 lines · Sinan Kaya

Rafael,

Quoted 3 lines · Corey Minyard

If the ACPI people ack this, I can queue it, or they can take it with:

What's your preference?

I can take it, it's all ready, I just need the ack.

OK, feel free to add an ACK from me then.

Thanks,
Rafael

#5 lore raw
Quoted 11 lines · Rafael J. Wysocki
Quoted 9 lines · Corey Minyard
Quoted 7 lines · Sinan Kaya

Rafael,

Quoted 3 lines · Corey Minyard

If the ACPI people ack this, I can queue it, or they can take it with:

What's your preference?

I can take it, it's all ready, I just need the ack.

OK, feel free to add an ACK from me then.

Thanks, queued and going to the linux-next tomorrow.

-corey

Quoted 3 lines

Thanks,
Rafael

author
#6 lore raw
Quoted 3 lines · Corey Minyard
Quoted 1 line

OK, feel free to add an ACK from me then.

Thanks, queued and going to the linux-next tomorrow.

thanks, does this include both of the ACPI/IPMI patches or just this one?

Signature · 3 lines
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.