Skip to contentSkip to conversation

bitbake.conf: add sudo to HOSTTOOLS

PATCH In review Robert Yang 3 participants 6 messages Mar 27, 2017 – Mar 28, 2017

lore
Share & tools
lore
#0 lore raw

cover bitbake.conf: add sudo to HOSTTOOLS

The following changes since commit 78928016f4cf38cf6751cb089200bf950d07ae93:

classes: Replace "if test" file tests with POSIX file tests (2017-03-27 11:08:28 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/tools
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/tools

Robert Yang (1):
bitbake.conf: add sudo to HOSTTOOLS

 meta/conf/bitbake.conf | 3 +++
 1 file changed, 3 insertions(+)
Signature · 1 line
2.11.0.rc2.dirty
#1 lore raw

PATCH 1/1 bitbake.conf: add sudo to HOSTTOOLS

Fixed:

$ bitbake meta-ide-support
$ . ./tmp/environment-setup-i586-poky-linux
$ runqemu tmp/deploy/images/qemux86/core-image-sato-qemux86.qemuboot.conf

[snip]
/bin/sh: sudo: command not found
runqemu - ERROR - Failed to setup tap device. Run runqemu-gen-tapdevs to manually create. [snip]

The qemu can start, but the IP was wrong, this patch fixes the problem.

[YOCTO #11232]

---
 meta/conf/bitbake.conf | 3 +++
 1 file changed, 3 insertions(+)
meta/conf/bitbake.conf +3 -0
index fa5445b65b..0b1d8d82e0 100644
@@ -468,6 +468,9 @@ HOSTTOOLS += " \
 # Tools needed to run testimage runtime image testing
 HOSTTOOLS += "ps stty ip ssh scp ping"
 
+# Tools needed by runqemu in meta-ide-support environment
+HOSTTOOLS += "sudo"
+
 # Link to these if present
 HOSTTOOLS_NONFATAL += "ccache ld.bfd ld.gold gcc-ar gpg sftp nc socat sudo"
 
Signature · 1 line
2.11.0.rc2.dirty
#2 lore raw
Quoted 6 lines · Robert Yang

[snip]
/bin/sh: sudo: command not found
runqemu - ERROR - Failed to setup tap device. Run runqemu-gen-tapdevs to manually create.
[snip]

This only happens if the tapdevs haven't already been generated, in which case sudo isn't required. Should it be a NONFATAL tool?

Ross

#3 lore raw
In reply to Robert Yang
Quoted 33 lines · Robert Yang

Fixed:

$ bitbake meta-ide-support
$ . ./tmp/environment-setup-i586-poky-linux
$ runqemu tmp/deploy/images/qemux86/core-image-sato-
qemux86.qemuboot.conf

[snip]
/bin/sh: sudo: command not found
runqemu - ERROR - Failed to setup tap device. Run runqemu-gen-tapdevs to manually create.
[snip]

The qemu can start, but the IP was wrong, this patch fixes the problem.

[YOCTO #11232]

---
 meta/conf/bitbake.conf | 3 +++

 1 file changed, 3 insertions(+)
meta/conf/bitbake.conf +0 -0
index fa5445b65b..0b1d8d82e0 100644
@@ -468,6 +468,9 @@ HOSTTOOLS += " \
  # Tools needed to run testimage runtime image testing

 HOSTTOOLS += "ps stty ip ssh scp ping"

meta/conf/bitbake.conf +3 -0
+# Tools needed by runqemu in meta-ide-support environment
+HOSTTOOLS += "sudo"
+
Quoted 3 lines

 # Link to these if present
 HOSTTOOLS_NONFATAL += "ccache ld.bfd ld.gold gcc-ar gpg sftp nc socat sudo"

sudo is already in HOSTTOOLS_NONFATAL?

Cheers,

Richard

#4 lore raw
Quoted 2 lines · Richard Purdie

sudo is already in HOSTTOOLS_NONFATAL?

Good point well made.

Ross

#5 lore raw
In reply to Richard Purdie
Quoted 31 lines · Richard Purdie
Quoted 30 lines · Robert Yang

Fixed:

$ bitbake meta-ide-support
$ . ./tmp/environment-setup-i586-poky-linux
$ runqemu tmp/deploy/images/qemux86/core-image-sato-
qemux86.qemuboot.conf

[snip]
/bin/sh: sudo: command not found
runqemu - ERROR - Failed to setup tap device. Run runqemu-gen-tapdevs to manually create.
[snip]

The qemu can start, but the IP was wrong, this patch fixes the problem.

[YOCTO #11232]

---
 meta/conf/bitbake.conf | 3 +++
 1 file changed, 3 insertions(+)
meta/conf/bitbake.conf +0 -0
index fa5445b65b..0b1d8d82e0 100644
@@ -468,6 +468,9 @@ HOSTTOOLS += " \
 # Tools needed to run testimage runtime image testing
 HOSTTOOLS += "ps stty ip ssh scp ping"
 
Quoted 8 lines
Quoted 6 lines
meta/conf/bitbake.conf +3 -0
+# Tools needed by runqemu in meta-ide-support environment
+HOSTTOOLS += "sudo"
+
 # Link to these if present
 HOSTTOOLS_NONFATAL += "ccache ld.bfd ld.gold gcc-ar gpg sftp nc

socat sudo"

sudo is already in HOSTTOOLS_NONFATAL?

Sorry, it isn't there when I added it last week, please drop my patch.

// Robert

Quoted 5 lines

Cheers,

Richard