Patch "ACM gadget: fix endianness in notifications" has been added to the 4.10-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ACM gadget: fix endianness in notifications
to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
acm-gadget-fix-endianness-in-notifications.patch
and it can be found in the queue-4.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
cdd7928df0d2efaa3270d711963773a08a4cc8abMon Sep 17 00:00:00 2001
From: Oliver Neukum <[email protected]>
Date: Tue, 14 Mar 2017 12:09:56 +0100
Subject: ACM gadget: fix endianness in notifications
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Oliver Neukum <[email protected]>
commit cdd7928df0d2efaa3270d711963773a08a4cc8ab upstream.
The gadget code exports the bitfield for serial status changes over the wire in its internal endianness. The fix is to convert to little endian before sending it over the wire.
--- drivers/usb/gadget/function/f_acm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/gadget/function/f_acm.c +3 -1
@@ -535,13 +535,15 @@ static int acm_notify_serial_state(struc {struct usb_composite_dev *cdev = acm->port.func.config->cdev;int status; +__le16 serial_state;spin_lock (&acm->lock);if (acm->notify_req) {dev_dbg (&cdev->gadget->dev,"acm ttyGS%d serial state %04x\n" , acm->port_num, acm->serial_state); + serial_state =cpu_to_le16 (acm->serial_state); status =acm_cdc_notify (acm,USB_CDC_NOTIFY_SERIAL_STATE , -0 , &acm->serial_state,sizeof (acm->serial_state)); +0 , &serial_state,sizeof (acm->serial_state)); }else { acm->pending = true; status =0 ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.10/acm-gadget-fix-endianness-in-notifications.patch