Skip to contentSkip to conversation

Patch "mmc: ushc: fix NULL-deref at probe" has been added to the 4.10-stable tree

PATCH [email protected] 1 participant 1 message Mar 27, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mmc: ushc: fix NULL-deref at probe

to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mmc-ushc-fix-null-deref-at-probe.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 181302dc7239add8ab1449c23ecab193f52ee6ab Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Mon, 13 Mar 2017 13:40:22 +0100
Subject: mmc: ushc: fix NULL-deref at probe

From: Johan Hovold <[email protected]>

commit 181302dc7239add8ab1449c23ecab193f52ee6ab upstream.

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints.

Fixes 53f3a9e26ed5 ("mmc: USB SD Host Controller (USHC) driver")
Cc David Vrabel <[email protected]>
---
 drivers/mmc/host/ushc.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/host/ushc.c +3 -0
@@ -426,6 +426,9 @@ static int ushc_probe(struct usb_interfa
 	struct ushc_data *ushc;
 	int ret;
 
+	if (intf->cur_altsetting->desc.bNumEndpoints < 1)
+		return -ENODEV;
+
 	mmc = mmc_alloc_host(sizeof(struct ushc_data), &intf->dev);
 	if (mmc == NULL)
 		return -ENOMEM;

Patches currently in stable-queue which might be from [email protected] are

queue-4.10/usb-serial-option-add-quectel-uc15-uc20-ec21-and-ec25-modems.patch queue-4.10/input-ims-pcu-validate-number-of-endpoints-before-using-them.patch queue-4.10/usb-usbtmc-add-missing-endpoint-sanity-check.patch queue-4.10/input-cm109-validate-number-of-endpoints-before-using-them.patch queue-4.10/input-iforce-validate-number-of-endpoints-before-using-them.patch queue-4.10/mmc-ushc-fix-null-deref-at-probe.patch queue-4.10/input-kbtab-validate-number-of-endpoints-before-using-them.patch queue-4.10/usb-usbtmc-fix-probe-error-path.patch queue-4.10/input-sur40-validate-number-of-endpoints-before-using-them.patch queue-4.10/uwb-i1480-dfu-fix-null-deref-at-probe.patch queue-4.10/input-hanwang-validate-number-of-endpoints-before-using-them.patch queue-4.10/usb-idmouse-fix-null-deref-at-probe.patch queue-4.10/uwb-hwa-rc-fix-null-deref-at-probe.patch queue-4.10/usb-lvtest-fix-null-deref-at-probe.patch queue-4.10/input-yealink-validate-number-of-endpoints-before-using-them.patch queue-4.10/usb-serial-qcserial-add-dell-dw5811e.patch queue-4.10/usb-uss720-fix-null-deref-at-probe.patch queue-4.10/usb-wusbcore-fix-null-deref-at-probe.patch